Kaynağa Gözat

qcacld-3.0: Remove key debug logs

wlan_hdd_cfg80211_set_key_wapi() and sme_roam_set_key() prints
key information in default host logs.

Fix to remove debug logs which prints sensitive key information.

Change-Id: Ib71da962761f9b6b5fd8ba214676b649529bcaa7
CRs-Fixed: 2058305
Sreelakshmi Konamki 7 yıl önce
ebeveyn
işleme
df43ff8c80

+ 0 - 4
core/hdd/src/wlan_hdd_cfg80211.c

@@ -11653,7 +11653,6 @@ void wlan_hdd_cfg80211_set_key_wapi(hdd_adapter_t *pAdapter, uint8_t key_index,
 	int status = 0;
 	uint32_t roamId = 0xFF;
 	uint8_t *pKeyPtr = NULL;
-	int n = 0;
 
 	hdd_debug("Device_mode %s(%d)",
 		hdd_device_mode_to_string(pAdapter->device_mode),
@@ -11674,9 +11673,6 @@ void wlan_hdd_cfg80211_set_key_wapi(hdd_adapter_t *pAdapter, uint8_t key_index,
 	memcpy(pKeyPtr, key, key_Len);
 
 	hdd_debug("WAPI KEY LENGTH:0x%04x", key_Len);
-	for (n = 0; n < key_Len; n++)
-		hdd_debug("WAPI KEY Data[%d]:%02x ",
-			   n, setKey.Key[n]);
 
 	pHddStaCtx->roam_info.roamingState = HDD_ROAM_STATE_SETTING_KEY;
 	if (isConnected) {

+ 0 - 3
core/sme/src/common/sme_api.c

@@ -4742,7 +4742,6 @@ QDF_STATUS sme_roam_set_key(tHalHandle hal,  uint8_t session_id,
 	QDF_STATUS status = QDF_STATUS_E_FAILURE;
 	tpAniSirGlobal mac_ctx = PMAC_STRUCT(hal);
 	uint32_t roam_id;
-	uint32_t i;
 	tCsrRoamSession *session = NULL;
 	struct ps_global_info *ps_global_info = &mac_ctx->sme.ps_global_info;
 
@@ -4765,8 +4764,6 @@ QDF_STATUS sme_roam_set_key(tHalHandle hal,  uint8_t session_id,
 		*ptr_roam_id = roam_id;
 
 	sme_debug("keyLength: %d", set_key->keyLength);
-	for (i = 0; i < set_key->keyLength; i++)
-		sme_debug("%02x", set_key->Key[i]);
 
 	sme_debug("Session_id: %d roam_id: %d", session_id, roam_id);
 	session = CSR_GET_SESSION(mac_ctx, session_id);