msm: camera: common: logging improvement

After flushed, KMD reports ERR including isp, actuator, sensor, flash.
However many CRs don't have fatal KMD error log, but participant is KMD.
Remove the non-fatal KMD error log.

CRs-Fixed: 3095401
Change-Id: I0e5e370c0c4d1daceb72d9eed8d0c45baad5179e
Signed-off-by: Wang Kan <quic_wkan@quicinc.com>
Этот коммит содержится в:
Wang Kan
2021-12-21 16:49:59 +08:00
коммит произвёл Camera Software Integration
родитель e89f48aea2
Коммит df174ddd8a
11 изменённых файлов: 105 добавлений и 35 удалений

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include <linux/module.h>
@@ -383,9 +384,14 @@ static int cam_actuator_update_req_mgr(
a_ctrl->bridge_intf.crm_cb->add_req) {
rc = a_ctrl->bridge_intf.crm_cb->add_req(&add_req);
if (rc) {
CAM_ERR(CAM_ACTUATOR,
"Adding request: %llu failed: rc: %d",
csl_packet->header.request_id, rc);
if (rc == -EBADR)
CAM_INFO(CAM_ACTUATOR,
"Adding request: %llu failed: rc: %d, it has been flushed",
csl_packet->header.request_id, rc);
else
CAM_ERR(CAM_ACTUATOR,
"Adding request: %llu failed: rc: %d",
csl_packet->header.request_id, rc);
return rc;
}
CAM_DBG(CAM_ACTUATOR, "Request Id: %lld added to CRM",
@@ -983,7 +989,12 @@ int32_t cam_actuator_driver_cmd(struct cam_actuator_ctrl_t *a_ctrl,
ACT_APPLY_SETTINGS_LATER;
rc = cam_actuator_i2c_pkt_parse(a_ctrl, arg);
if (rc < 0) {
CAM_ERR(CAM_ACTUATOR, "Failed in actuator Parsing");
if (rc == -EBADR)
CAM_INFO(CAM_ACTUATOR,
"Failed in actuator Parsing, it has been flushed");
else
CAM_ERR(CAM_ACTUATOR,
"Failed in actuator Parsing");
goto release_mutex;
}

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include "cam_actuator_dev.h"
@@ -52,9 +53,15 @@ static long cam_actuator_subdev_ioctl(struct v4l2_subdev *sd,
switch (cmd) {
case VIDIOC_CAM_CONTROL:
rc = cam_actuator_driver_cmd(a_ctrl, arg);
if (rc)
CAM_ERR(CAM_ACTUATOR,
"Failed for driver_cmd: %d", rc);
if (rc) {
if (rc == -EBADR)
CAM_INFO(CAM_ACTUATOR,
"Failed for driver_cmd: %d, it has been flushed",
rc);
else
CAM_ERR(CAM_ACTUATOR,
"Failed for driver_cmd: %d", rc);
}
break;
case CAM_SD_SHUTDOWN:
if (!cam_req_mgr_is_shutdown()) {

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include <linux/module.h>
@@ -1272,9 +1273,14 @@ update_req_mgr:
fctrl->bridge_intf.crm_cb->add_req) {
rc = fctrl->bridge_intf.crm_cb->add_req(&add_req);
if (rc) {
CAM_ERR(CAM_FLASH,
"Failed in adding request: %llu to request manager",
csl_packet->header.request_id);
if (rc == -EBADR)
CAM_INFO(CAM_FLASH,
"Failed in adding request: %llu to request manager, it has been flushed",
csl_packet->header.request_id);
else
CAM_ERR(CAM_FLASH,
"Failed in adding request: %llu to request manager",
csl_packet->header.request_id);
return rc;
}
CAM_DBG(CAM_FLASH,
@@ -1765,10 +1771,15 @@ int cam_flash_pmic_pkt_parser(struct cam_flash_ctrl *fctrl, void *arg)
if (fctrl->bridge_intf.crm_cb &&
fctrl->bridge_intf.crm_cb->add_req) {
rc = fctrl->bridge_intf.crm_cb->add_req(&add_req);
if (rc) {
CAM_ERR(CAM_FLASH,
"Failed in adding request: %llu to request manager",
csl_packet->header.request_id);
if (rc) {
if (rc == -EBADR)
CAM_INFO(CAM_FLASH,
"Failed in adding request: %llu to request manager, it has been flushed",
csl_packet->header.request_id);
else
CAM_ERR(CAM_FLASH,
"Failed in adding request: %llu to request manager",
csl_packet->header.request_id);
return rc;
}
CAM_DBG(CAM_FLASH,

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include <linux/module.h>
@@ -191,7 +192,11 @@ static int32_t cam_flash_driver_cmd(struct cam_flash_ctrl *fctrl,
CAM_DBG(CAM_FLASH, "CAM_CONFIG_DEV");
rc = fctrl->func_tbl.parser(fctrl, arg);
if (rc) {
CAM_ERR(CAM_FLASH, "Failed Flash Config: rc=%d\n", rc);
if (rc == -EBADR)
CAM_INFO(CAM_FLASH,
"Failed Flash Config: rc=%d\n, it has been flushed", rc);
else
CAM_ERR(CAM_FLASH, "Failed Flash Config: rc=%d\n", rc);
goto release_mutex;
}
break;
@@ -287,9 +292,14 @@ static long cam_flash_subdev_ioctl(struct v4l2_subdev *sd,
case VIDIOC_CAM_CONTROL: {
rc = cam_flash_driver_cmd(fctrl, arg,
soc_private);
if (rc)
CAM_ERR(CAM_FLASH,
"Failed in driver cmd: %d", rc);
if (rc) {
if (rc == -EBADR)
CAM_INFO(CAM_FLASH,
"Failed in driver cmd: %d, it has been flushed", rc);
else
CAM_ERR(CAM_FLASH,
"Failed in driver cmd: %d", rc);
}
break;
}
case CAM_SD_SHUTDOWN:

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include <linux/module.h>
@@ -30,9 +31,14 @@ static int cam_sensor_update_req_mgr(
s_ctrl->bridge_intf.crm_cb->add_req) {
rc = s_ctrl->bridge_intf.crm_cb->add_req(&add_req);
if (rc) {
CAM_ERR(CAM_SENSOR,
"Adding request: %llu failed with request manager rc: %d",
csl_packet->header.request_id, rc);
if (rc == -EBADR)
CAM_INFO(CAM_SENSOR,
"Adding request: %llu failed with request manager rc: %d, it has been flushed",
csl_packet->header.request_id, rc);
else
CAM_ERR(CAM_SENSOR,
"Adding request: %llu failed with request manager rc: %d",
csl_packet->header.request_id, rc);
return rc;
}
}
@@ -1125,8 +1131,14 @@ int32_t cam_sensor_driver_cmd(struct cam_sensor_ctrl_t *s_ctrl,
case CAM_CONFIG_DEV: {
rc = cam_sensor_i2c_pkt_parse(s_ctrl, arg);
if (rc < 0) {
CAM_ERR(CAM_SENSOR, "%s:Failed i2c pkt parse. rc: %d",
s_ctrl->sensor_name, rc);
if (rc == -EBADR)
CAM_INFO(CAM_SENSOR,
"%s:Failed i2c pkt parse. rc: %d, it has been flushed",
s_ctrl->sensor_name, rc);
else
CAM_ERR(CAM_SENSOR,
"%s:Failed i2c pkt parse. rc: %d",
s_ctrl->sensor_name, rc);
goto release_mutex;
}
if (s_ctrl->i2c_data.init_settings.is_settings_valid &&

Просмотреть файл

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include "cam_sensor_dev.h"
@@ -50,9 +51,14 @@ static long cam_sensor_subdev_ioctl(struct v4l2_subdev *sd,
switch (cmd) {
case VIDIOC_CAM_CONTROL:
rc = cam_sensor_driver_cmd(s_ctrl, arg);
if (rc)
CAM_ERR(CAM_SENSOR,
"Failed in Driver cmd: %d", rc);
if (rc) {
if (rc == -EBADR)
CAM_INFO(CAM_SENSOR,
"Failed in Driver cmd: %d, it has been flushed", rc);
else
CAM_ERR(CAM_SENSOR,
"Failed in Driver cmd: %d", rc);
}
break;
case CAM_SD_SHUTDOWN:
if (!cam_req_mgr_is_shutdown()) {