Browse Source

qcacld-3.0: Replace typedef tSirEseBcnReportRsp

The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirEseBcnReportRsp typedef
does not meet any of those criteria, so replace it (and the "tp"
variant) with a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: Id687d039c51eaf293cdd39536cf200874bd8fbc9
CRs-Fixed: 2394253
Jeff Johnson 6 years ago
parent
commit
dda4075a5e
3 changed files with 6 additions and 6 deletions
  1. 2 2
      core/mac/inc/sir_api.h
  2. 1 1
      core/sme/inc/csr_api.h
  3. 3 3
      core/sme/src/rrm/sme_rrm.c

+ 2 - 2
core/mac/inc/sir_api.h

@@ -837,13 +837,13 @@ struct ese_bcn_report_bss_info {
 	uint8_t *pBuf;
 };
 
-typedef struct sSirEseBcnReportRsp {
+struct ese_bcn_report_rsp {
 	uint16_t measurementToken;
 	uint8_t flag;        /* Flag to report measurement done and more data */
 	uint8_t numBss;
 	struct ese_bcn_report_bss_info
 				bcnRepBssInfo[SIR_BCN_REPORT_MAX_BSS_DESC];
-} tSirEseBcnReportRsp, *tpSirEseBcnReportRsp;
+};
 
 #define TSRS_11AG_RATE_6MBPS   0xC
 #define TSRS_11B_RATE_5_5MBPS  0xB

+ 1 - 1
core/sme/inc/csr_api.h

@@ -1098,7 +1098,7 @@ struct csr_roam_info {
 	struct tsm_ie tsm_ie;
 	uint32_t timestamp[2];
 	uint16_t tsmRoamDelay;
-	tSirEseBcnReportRsp *pEseBcnReportRsp;
+	struct ese_bcn_report_rsp *pEseBcnReportRsp;
 #endif
 	void *pRemainCtx;
 	uint32_t roc_scan_id;

+ 3 - 3
core/sme/src/rrm/sme_rrm.c

@@ -277,8 +277,8 @@ static QDF_STATUS sme_ese_send_beacon_req_scan_results(
 	tCsrScanResultInfo *cur_result = NULL;
 	tpRrmSMEContext rrm_ctx = &mac_ctx->rrm.rrmSmeContext;
 	struct csr_roam_info roam_info;
-	tSirEseBcnReportRsp bcn_rpt_rsp;
-	tpSirEseBcnReportRsp bcn_report = &bcn_rpt_rsp;
+	struct ese_bcn_report_rsp bcn_rpt_rsp;
+	struct ese_bcn_report_rsp *bcn_report = &bcn_rpt_rsp;
 	tpCsrEseBeaconReqParams cur_meas_req = NULL;
 	uint8_t i = 0, j = 0;
 	tBcnReportFields *bcn_rpt_fields;
@@ -296,7 +296,7 @@ static QDF_STATUS sme_ese_send_beacon_req_scan_results(
 	if (result_arr)
 		cur_result = result_arr[bss_counter];
 
-	qdf_mem_zero(&bcn_rpt_rsp, sizeof(tSirEseBcnReportRsp));
+	qdf_mem_zero(&bcn_rpt_rsp, sizeof(bcn_rpt_rsp));
 	do {
 		cur_meas_req = NULL;
 		for (i = 0; i < rrm_ctx->eseBcnReqInfo.numBcnReqIe; i++) {