samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: cdp: Convergence of cdp_flowctl_ops

Browse Source 
Currently the cdp apis are given pdev/vdev/peer
handle as its arguments, which is directly
accessed in those APIs. This can cause a
race-condition in access of the respective
handles if it has been deleted in parallel.

Hence as a part of cdp convergence, pass only
the pdev/vdev id or peer mac address, which will be
used to get the respective handles, and hence
avoiding the unwanted access of the handles if
it has been deleted.

Converged flowctl_ops
- flow_pool_map_handler
- flow_pool_unmap_handler
- dump_flow_pool_info
- tx_desc_thresh_reached

CRs-Fixed: 2539812
Change-Id: I084d3878df84778622340e87bddf90acd3e669d6
This commit is contained in:
Rakesh Pillai
2019-06-28 19:11:23 +05:30
committed by nshrivas
parent c4ffad74c3
commit dce01374cd
6 changed files with 67 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dp/inc/cdp_txrx_flow_ctrl_v2.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016-2018 The Linux Foundation. All rights reserved.
* Copyright (c) 2016-2019 The Linux Foundation. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -92,8 +92,6 @@ cdp_set_desc_global_pool_size(ol_txrx_soc_handle soc,
static inline void
cdp_dump_flow_pool_info(struct cdp_soc_t *soc)
{
void *dp_soc = (void *)soc;
if (!soc || !soc->ops) {
QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_DEBUG,
"%s invalid instance", __func__);
@@ -105,18 +103,18 @@ cdp_dump_flow_pool_info(struct cdp_soc_t *soc)
!soc->ops->flowctl_ops->dump_flow_pool_info)
return;
soc->ops->flowctl_ops->dump_flow_pool_info(dp_soc);
soc->ops->flowctl_ops->dump_flow_pool_info(soc);
}
/**
* cdp_tx_desc_thresh_reached() - Check if avail tx desc meet threshold
* @soc - data path soc handle
* @vdev - dp vdev handle
* @soc: data path soc handle
* @vdev_id: vdev_id corresponding to vdev start
*
* Return: true if threshold is met, false if not
*/
static inline bool
cdp_tx_desc_thresh_reached(struct cdp_soc_t *soc, struct cdp_vdev *vdev)
cdp_tx_desc_thresh_reached(struct cdp_soc_t *soc, uint8_t vdev_id)
{
if (!soc || !soc->ops) {
QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_DEBUG,
@@ -129,6 +127,6 @@ cdp_tx_desc_thresh_reached(struct cdp_soc_t *soc, struct cdp_vdev *vdev)
!soc->ops->flowctl_ops->tx_desc_thresh_reached)
return false;
return soc->ops->flowctl_ops->tx_desc_thresh_reached(vdev);
return soc->ops->flowctl_ops->tx_desc_thresh_reached(soc, vdev_id);
}
#endif /* _CDP_TXRX_FC_V2_H_ */