Prechádzať zdrojové kódy

disp: msm: sde: add checks when retrieving blob feature data

Add checks when retrieving CP blob feature data to avoid
intermittent issue with pointer access.

Change-Id: I3a3bd870bb6a5d7bb8d13188af8cc4b9bd06acc5
Signed-off-by: Amine Najahi <[email protected]>
Amine Najahi 4 rokov pred
rodič
commit
dca59625e5
1 zmenil súbory, kde vykonal 7 pridanie a 1 odobranie
  1. 7 1
      msm/sde/sde_color_processing.c

+ 7 - 1
msm/sde/sde_color_processing.c

@@ -1004,6 +1004,12 @@ static struct drm_property_blob *_sde_cp_get_crtc_feature_data(u32 feature,
 	memset(hw_cfg, 0, sizeof(*hw_cfg));
 	*feature_enabled = false;
 
+	if (!property || !prop_node) {
+		DRM_ERROR("invalid feature:%d, property:%pK, prop_node:%pK\n",
+				feature, property, prop_node);
+		goto end;
+	}
+
 	if (property->flags & DRM_MODE_PROP_BLOB) {
 		blob = drm_property_lookup_blob(crtc->base.dev,
 				pstate->prop_val);
@@ -1036,7 +1042,7 @@ static struct drm_property_blob *_sde_cp_get_crtc_feature_data(u32 feature,
 	} else {
 		DRM_ERROR("property type is not supported\n");
 	}
-
+end:
 	return blob;
 }