samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Koodi Ongelmat Pull-pyynnöt Actions Paketit Projektit Julkaisut Wiki Toiminta

qcacmn: Handle invalid reo params gracefully

Selaa lähdekoodia 
Gracefully handle invalid reo parameters error.

CRs-Fixed: 3525856
Change-Id: I1bc18ed9224ea999bc792642dcb5081583cfa1f6
This commit is contained in:
Edayilliam Jayadev
2023-06-13 15:33:05 +05:30
committed by Gerrit - the friendly Code Review server
vanhempi 62d03ddb2c
commit dbcf99be3e
2 muutettua tiedostoa jossa 126 lisäystä ja 14 poistoa
Download Patch File Download Diff File Expand all files Collapse all files

127
umac/cmn_services/mgmt_txrx/core/src/wlan_mgmt_txrx_rx_reo.c
Näytä tiedosto

@@ -129,6 +129,98 @@ mgmt_rx_reo_compare_global_timestamps_gte(uint32_t ts1, uint32_t ts2)
return delta <= MGMT_RX_REO_GLOBAL_TS_HALF_RANGE;
}
#ifdef WLAN_MGMT_RX_REO_ERROR_HANDLING
/**
* check_and_handle_invalid_reo_params() - Check and handle invalid reo
* parameters error
* @desc: Pointer to frame descriptor
*
* API to check for invalid reo parameter error. Host won't be able to reorder
* this frame and hence drop this frame.
*
* Return: QDF_STATUS
*/
static QDF_STATUS
check_and_handle_invalid_reo_params(struct mgmt_rx_reo_frame_descriptor *desc)
{
struct mgmt_rx_reo_params *reo_params;
if (!desc) {
mgmt_rx_reo_err("Mgmt Rx REO frame descriptor is null");
return QDF_STATUS_E_NULL_VALUE;
}
if (!desc->rx_params) {
mgmt_rx_reo_err("Mgmt Rx params is null");
return QDF_STATUS_E_NULL_VALUE;
}
reo_params = desc->rx_params->reo_params;
if (!reo_params) {
mgmt_rx_reo_err("Mgmt Rx REO params is NULL");
return QDF_STATUS_E_NULL_VALUE;
}
if (!reo_params->valid) {
mgmt_rx_reo_debug_rl("Invalid param: link= %u, ctr= %u, ts= %u",
reo_params->link_id,
reo_params->mgmt_pkt_ctr,
reo_params->global_timestamp);
desc->drop = true;
desc->drop_reason = MGMT_RX_REO_INVALID_REO_PARAMS;
return QDF_STATUS_E_FAILURE;
}
return QDF_STATUS_SUCCESS;
}
#else
/**
* check_and_handle_invalid_reo_params() - Check and handle invalid reo
* parameters error
* @desc: Pointer to frame descriptor
*
* API to check for invalid reo parameter error. Host won't be able to reorder
* this frame and hence drop this frame.
*
* Return: QDF_STATUS
*/
static QDF_STATUS
check_and_handle_invalid_reo_params(struct mgmt_rx_reo_frame_descriptor *desc)
{
struct mgmt_rx_reo_params *reo_params;
if (!desc) {
mgmt_rx_reo_err("Mgmt Rx REO frame descriptor is null");
return QDF_STATUS_E_NULL_VALUE;
}
if (!desc->rx_params) {
mgmt_rx_reo_err("Mgmt Rx params is null");
return QDF_STATUS_E_NULL_VALUE;
}
reo_params = desc->rx_params->reo_params;
if (!reo_params) {
mgmt_rx_reo_err("Mgmt Rx REO params is NULL");
return QDF_STATUS_E_NULL_VALUE;
}
if (!reo_params->valid) {
mgmt_rx_reo_err_rl("Invalid params: link= %u, ctr= %u, ts= %u",
reo_params->link_id,
reo_params->mgmt_pkt_ctr,
reo_params->global_timestamp);
desc->drop = true;
desc->drop_reason = MGMT_RX_REO_INVALID_REO_PARAMS;
return QDF_STATUS_E_FAILURE;
}
return QDF_STATUS_SUCCESS;
}
#endif /* WLAN_MGMT_RX_REO_ERROR_HANDLING */
/**
* mgmt_rx_reo_is_stale_frame()- API to check whether the given management frame
* is stale
@@ -3878,6 +3970,36 @@ mgmt_rx_reo_egress_list_init(struct mgmt_rx_reo_egress_list *egress_list)
return QDF_STATUS_SUCCESS;
}
/**
* check_frame_sanity() - Check the sanity of a given management frame
* @desc: Pointer to frame descriptor
*
* API to check the sanity of a given management frame. This API checks for the
* following errors.
*
* 1. Invalid management rx reo parameters
*
* Return: QDF_STATUS
*/
static QDF_STATUS
check_frame_sanity(struct mgmt_rx_reo_frame_descriptor *desc)
{
QDF_STATUS status;
if (!desc) {
mgmt_rx_reo_err("Frame descriptor is null");
return QDF_STATUS_E_NULL_VALUE;
}
status = check_and_handle_invalid_reo_params(desc);
if (QDF_IS_STATUS_ERROR(status)) {
mgmt_rx_reo_warn_rl("Drop frame with invalid reo params");
return status;
}
return QDF_STATUS_SUCCESS;
}
/**
* wlan_mgmt_rx_reo_update_host_snapshot() - Update Host snapshot with the MGMT
* Rx REO parameters.
@@ -4877,7 +4999,6 @@ wlan_mgmt_rx_reo_algo_entry(struct wlan_objmgr_pdev *pdev,
qdf_spin_lock(&reo_ctx->reo_algo_entry_lock);
cur_link = mgmt_rx_reo_get_link_id(desc->rx_params);
qdf_assert_always(desc->rx_params->reo_params->valid);
qdf_assert_always(desc->frame_type == IEEE80211_FC0_TYPE_MGT);
if (desc->type == MGMT_RX_REO_FRAME_DESC_HOST_CONSUMED_FRAME)
@@ -4887,6 +5008,10 @@ wlan_mgmt_rx_reo_algo_entry(struct wlan_objmgr_pdev *pdev,
if (QDF_IS_STATUS_ERROR(ret))
goto failure;
ret = check_frame_sanity(desc);
if (QDF_IS_STATUS_ERROR(ret))
goto failure;
/* Update the Host snapshot */
ret = wlan_mgmt_rx_reo_update_host_snapshot(pdev, desc);
if (QDF_IS_STATUS_ERROR(ret))

13
umac/cmn_services/mgmt_txrx/dispatcher/src/wlan_mgmt_txrx_rx_reo_tgt_api.c
Näytä tiedosto

@@ -135,12 +135,6 @@ tgt_mgmt_rx_reo_enter_algo_without_buffer(
return QDF_STATUS_E_INVAL;
}
if (!reo_params->valid) {
mgmt_rx_reo_err_rl("Invalid MGMT rx REO param for link %u",
link_id);
return QDF_STATUS_E_INVAL;
}
ml_grp_id = wlan_get_mlo_grp_id_from_pdev(pdev);
if (ml_grp_id > WLAN_MAX_MLO_GROUPS) {
mgmt_rx_reo_err("Invalid MLO Group %d for the pdev",
@@ -345,13 +339,6 @@ QDF_STATUS tgt_mgmt_rx_reo_frame_handler(
goto cleanup;
}
if (!mgmt_rx_params->reo_params->valid) {
mgmt_rx_reo_err_rl("Invalid MGMT rx REO param for link %u",
link_id);
status = QDF_STATUS_E_INVAL;
goto cleanup;
}
ml_grp_id = wlan_get_mlo_grp_id_from_pdev(pdev);
if (ml_grp_id > WLAN_MAX_MLO_GROUPS) {
mgmt_rx_reo_err("Invalid MGMT rx reo Group id");