qcacld-3.0: Fix hdd/inc documentation

The kernel-doc script identified documentation issues in the hdd
layer, so fix the ones in the "inc" folder.

Change-Id: I0fda8ea1ce929ad5e0cc54f86a9de5a46b3f7d38
CRs-Fixed: 3346527

core/hdd/inc/wlan_hdd_assoc.h

@@ -68,6 +68,7 @@ enum peer_status {
  * @hs20_present: hs20 element present or not
  * @ht_op_present: ht operation present or not
  * @vht_op_present: vht operation present or not
+ * @reserved: reserved spare bits
  */
 struct hdd_conn_flag {
 	uint8_t ht_present:1;
@@ -117,7 +118,7 @@ struct hdd_conn_flag {
  * struct hdd_connection_info - structure to store connection information
  * @conn_state: connection state of the NIC
  * @bssid: BSSID
- * @SSID: SSID Info
+ * @ssid: SSID Info
  * @peer_macaddr:Peer Mac Address of the IBSS Stations
  * @auth_type: Auth Type
  * @uc_encrypt_type: Unicast Encryption Type
@@ -134,8 +135,12 @@ struct hdd_conn_flag {
  * @noise: holds noise information
  * @ht_caps: holds ht capabilities info
  * @vht_caps: holds vht capabilities info
- * @hs20vendor_ie: holds passpoint/hs20 info
  * @conn_flag: flag conn info params is present or not
+ * @hs20vendor_ie: holds passpoint/hs20 info
+ * @ht_operation: HT operation info
+ * @vht_operation: VHT operation info
+ * @he_operation: HE operation info
+ * @he_oper_len: length of @he_operation
  * @roam_count: roaming counter
  * @signal: holds rssi info
  * @assoc_status_code: holds assoc fail reason
@@ -373,7 +378,7 @@ QDF_STATUS hdd_roam_register_sta(struct hdd_adapter *adapter,
  *
  * This information is passed to iwconfig later. The peer that joined
  * last is passed as information to iwconfig.
-
+ *
  * Return: true if success, false otherwise
  */
 bool hdd_save_peer(struct hdd_station_ctx *sta_ctx,
@@ -453,7 +458,7 @@ bool hdd_any_valid_peer_present(struct hdd_adapter *adapter);
 QDF_STATUS hdd_cm_register_cb(void);
 
 /**
- * void hdd_cm_unregister_cb(void)() - Resets legacy callbacks to osif
+ * hdd_cm_unregister_cb - Resets legacy callbacks to osif
  *
  * API to reset legacy callbacks to osif
  * Context: Any context.

core/hdd/inc/wlan_hdd_debugfs_mibstat.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -33,6 +34,8 @@
 #if defined(WLAN_FEATURE_MIB_STATS) && defined(WLAN_DEBUGFS)
 /**
  * hdd_debugfs_process_mib_stats() - Process mib stats from fw
+ * @adapter: interface adapter pointer
+ * @stats: mib stats
  *
  * This function is used to store mib stats to global variable mib_stats.
  *

core/hdd/inc/wlan_hdd_debugfs_unit_test.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -28,7 +29,7 @@
 
 #if defined(WLAN_DEBUGFS) && defined(WLAN_UNIT_TEST)
 /**
- * hdd_debugfs_unit_test_host_create() - API to create unit_test_target
+ * wlan_hdd_debugfs_unit_test_host_create() - API to create unit_test_target
  * @hdd_ctx: hdd context
  *
  * this file is created per driver.

core/hdd/inc/wlan_hdd_eht.h

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_eht.h
+ * DOC: wlan_hdd_eht.h
  *
  * WLAN Host Device Driver file for 802.11be (Extremely High Throughput)
  * support.
@@ -36,7 +36,7 @@ struct sap_config;
 /**
  * hdd_update_tgt_eht_cap() - Update EHT related capabilities
  * @hdd_ctx: HDD context
- * @eht_cap: Target EHT capabilities
+ * @cfg: Target capabilities
  *
  * This function updates WNI CFG with Target capabilities received as part of
  * Default values present in WNI CFG are the values supported by FW/HW.

core/hdd/inc/wlan_hdd_he.h

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_he.h
+ * DOC: wlan_hdd_he.h
  *
  * WLAN Host Device Driver file for 802.11ax (High Efficiency) support.
  *
@@ -34,19 +34,18 @@ struct sap_config;
 
 #ifdef WLAN_FEATURE_11AX
 /**
- * enum qca_wlan_vendor_attr_get_he_capabilities - attributes for HE caps.
- *						  vendor command.
- * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_INVALID - invalid
- * @QCA_WLAN_VENDOR_ATTR_HE_SUPPORTED - to check if HE capabilities is supported
- * @QCA_WLAN_VENDOR_ATTR_PHY_CAPAB - to get HE PHY capabilities
- * @QCA_WLAN_VENDOR_ATTR_MAC_CAPAB - to get HE MAC capabilities
- * @QCA_WLAN_VENDOR_ATTR_HE_MCS - to get HE MCS
- * @QCA_WLAN_VENDOR_ATTR_NUM_SS - to get NUM SS
- * @QCA_WLAN_VENDOR_ATTR_RU_IDX_MASK - to get RU index mask
- * @QCA_WLAN_VENDOR_ATTR_RU_COUNT - to get RU count,
- * @QCA_WLAN_VENDOR_ATTR_PPE_THRESHOLD - to get PPE Threshold,
- * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_AFTER_LAST - next to last valid enum
- * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_MAX - max value supported
+ * enum qca_wlan_vendor_attr_get_he_capabilities - attributes for HE caps
+ *						   vendor command.
+ * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_INVALID: invalid
+ * @QCA_WLAN_VENDOR_ATTR_HE_SUPPORTED: to check if HE capabilities is supported
+ * @QCA_WLAN_VENDOR_ATTR_PHY_CAPAB: to get HE PHY capabilities
+ * @QCA_WLAN_VENDOR_ATTR_MAC_CAPAB: to get HE MAC capabilities
+ * @QCA_WLAN_VENDOR_ATTR_HE_MCS: to get HE MCS
+ * @QCA_WLAN_VENDOR_ATTR_NUM_SS: to get NUM SS
+ * @QCA_WLAN_VENDOR_ATTR_RU_IDX_MASK: to get RU index mask
+ * @QCA_WLAN_VENDOR_ATTR_PPE_THRESHOLD: to get PPE Threshold,
+ * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_AFTER_LAST: next to last valid enum
+ * @QCA_WLAN_VENDOR_ATTR_HE_CAPABILITIES_MAX: max value supported
  *
  * enum values are used for NL attributes for data used by
  * QCA_NL80211_VENDOR_SUBCMD_GET_HE_CAPABILITIES sub command.
@@ -74,7 +73,7 @@ wlan_hdd_sr_policy[QCA_WLAN_VENDOR_ATTR_SR_MAX + 1];
 /**
  * hdd_update_tgt_he_cap() - Update HE related capabilities
  * @hdd_ctx: HDD context
- * @he_cap: Target HE capabilities
+ * @cfg: Target capabilities
  *
  * This function updaates WNI CFG with Target capabilities received as part of
  * Default values present in WNI CFG are the values supported by FW/HW.

core/hdd/inc/wlan_hdd_mlo.h

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_mlo.h
+ * DOC: wlan_hdd_mlo.h
  *
  * WLAN Host Device Driver file for 802.11be (Extremely High Throughput)
  * support.
@@ -34,6 +34,7 @@
  * @is_ml_adapter: is a ml adapter with associated netdev
  * @is_add_virtual_iface: is netdev create request from add virtual interface
  * @is_single_link: Is the adapter single link ML
+ * @unused: Reserved spare bits
  */
 struct hdd_adapter_create_param {
 	uint32_t only_wdev_register:1,
@@ -71,6 +72,7 @@ struct hdd_adapter_create_param {
  * adapter
  * @num_of_vdev_links: Num of vdevs/links part of the association
  * @is_single_link_ml: Is the adapter a single link ML adapter
+ * @unused: Reserved spare bits
  * @ml_adapter: ML adapter backpointer
  * @link_adapter: backpointers to link adapters part of association
  */
@@ -138,7 +140,7 @@ void hdd_adapter_set_sl_ml_adapter(struct hdd_adapter *adapter);
 
 /**
  * hdd_get_ml_adapter() - get an ml adapter
- * @adapter: HDD adapter
+ * @hdd_ctx: HDD context
  *
  * This function returns ml adapter from adapter list
  * Return: adapter or NULL

core/hdd/inc/wlan_hdd_napi.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2015-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -69,7 +70,7 @@ static inline int hdd_napi_serialize(int is_on)
 
 #else /* ! defined(FEATURE_NAPI) */
 #include "hif_napi.h"
-/**
+/*
  * Stub API
  *
  */

core/hdd/inc/wlan_hdd_oemdata.h

@@ -164,7 +164,7 @@ enum oem_capability_mask {
 /**
  * struct oem_get_capability_rsp - capabilities set by userspace and target.
  * @target_cap: target capabilities
- * @client_capabilities: capabilities set by userspace via set request
+ * @cap: capabilities set by userspace via set request
  */
 struct oem_get_capability_rsp {
 	struct oem_data_cap target_cap;
@@ -217,10 +217,10 @@ int oem_deactivate_service(void);
 void hdd_send_oem_data_rsp_msg(struct oem_data_rsp *oem_rsp);
 
 /**
- * update_channel_bw_info() - set bandwidth info for the chan
+ * hdd_update_channel_bw_info() - set bandwidth info for the chan
  * @hdd_ctx: hdd context
  * @chan_freq: channel freq for which info are required
- * @chan_info: struct where the bandwidth info is filled
+ * @hdd_chan_info: struct where the bandwidth info is filled
  *
  * This function finds the maximum bandwidth allowed, secondary
  * channel offset and center freq for the channel as per regulatory

core/hdd/inc/wlan_hdd_packet_filter_rules.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -28,7 +29,7 @@
 
 #define MAX_NUM_PACKET_FILTERS 6
 
-/**
+/*
  * @filter_action: Filter action, set/clear the filter
  * Ex: filter_action = 1 set the filter
  *     filter_action = 2 clear the filter

core/hdd/inc/wlan_hdd_power.h

@@ -53,7 +53,7 @@
  * @HDD_FILTER_PROTO_TYPE_IPV4: IP V4 protocol
  * @HDD_FILTER_PROTO_TYPE_IPV6: IP V6 protocol
  * @HDD_FILTER_PROTO_TYPE_UDP: UDP protocol
- * @HDD_FILTER_PROTO_TYPE_INVALID: Max place holder value
+ * @HDD_FILTER_PROTO_TYPE_MAX: Max place holder value
  */
 enum pkt_filter_protocol_layer {
 	HDD_FILTER_PROTO_TYPE_INVALID = 0,
@@ -101,7 +101,7 @@ enum pkt_filter_compare_flag {
  * struct pkt_filter_param_cfg - packet filter parameter config
  * @protocol_layer: Protocol layer
  * @compare_flag: Compare flag
- * @data_fffset: Data offset
+ * @data_offset: Data offset
  * @data_length: Data length
  * @compare_data: Compare data
  * @data_mask: Data mask
@@ -133,7 +133,7 @@ struct pkt_filter_cfg {
 
 #ifdef FEATURE_ANI_LEVEL_REQUEST
 /**
- * ani_priv - structure to store the priv data for get ani request
+ * struct ani_priv - structure to store the priv data for get ani request
  * @num_freq: number of freq received from the FW
  * @ani: data received from the FW
  */
@@ -337,7 +337,8 @@ void hdd_ipv4_notifier_work_queue(struct work_struct *work);
 #ifdef WLAN_NS_OFFLOAD
 /**
  * hdd_enable_ns_offload() - enable NS offload
- * @adapter:   pointer to the adapter
+ * @adapter: pointer to the adapter
+ * @trigger: trigger reason to enable ns offload
  *
  * Return: nothing
  */
@@ -346,7 +347,8 @@ void hdd_enable_ns_offload(struct hdd_adapter *adapter,
 
 /**
  * hdd_disable_ns_offload() - disable NS offload
- * @adapter:   pointer to the adapter
+ * @adapter: pointer to the adapter
+ * @trigger: trigger reason to enable ns offload
  *
  * Return: nothing
  */

core/hdd/inc/wlan_hdd_pre_cac.h

@@ -53,7 +53,7 @@ void hdd_close_pre_cac_adapter(struct hdd_context *hdd_ctx);
 QDF_STATUS hdd_pre_cac_register_cb(void);
 
 /**
- * void hdd_pre_cac_unregister_cb(void)() - Resets legacy callbacks to osif
+ * hdd_pre_cac_unregister_cb() - Resets legacy callbacks to osif
  *
  * API to reset legacy callbacks to osif
  *

core/hdd/inc/wlan_hdd_regulatory.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -107,7 +108,7 @@ uint32_t hdd_reg_legacy_setband_to_reg_wifi_band_bitmap(uint8_t qca_setband);
 
 /**
  * hdd_reg_set_band() - helper function for setting the regulatory band
- * @hdd_ctx: the HDD context to set the band for
+ * @dev: the network device to set the band for
  * @band_bitmap: the band bitmap to configure
  *
  * Return: zero for success, non-zero error code for failure
@@ -127,6 +128,7 @@ void hdd_update_indoor_channel(struct  hdd_context *hdd_ctx,
 					bool disable);
 /**
  * hdd_modify_indoor_channel_state_flags() - modify wiphy flags and cds state
+ * @hdd_ctx: HDD context
  * @wiphy_chan: wiphy channel number
  * @cds_chan: cds channel structure
  * @chan_enum: channel enum maintain in reg db
@@ -146,8 +148,7 @@ void hdd_modify_indoor_channel_state_flags(
 /**
  * hdd_update_regdb_offload_config() - Update regdb offload disable ini
  * for regulatory component.
- *
- * @psoc: psoc ptr
+ * @hdd_ctx: HDD context
  *
  * Return: None
  */

core/hdd/inc/wlan_hdd_sysfs.h

@@ -25,12 +25,12 @@
 #define MAX_SYSFS_USER_COMMAND_SIZE_LENGTH (32)
 
 /**
- * hdd_sys_validate_and_copy_buf() - validate sysfs input buf and copy into
- *                                   destination buffer
- * @dest_buf - pointer to destination buffer where data should be copied
- * @dest_buf_size - size of destination buffer
- * @src_buf - pointer to constant sysfs source buffer
- * @src_buf_size - size of source buffer
+ * hdd_sysfs_validate_and_copy_buf() - validate sysfs input buf and copy into
+ *                                     destination buffer
+ * @dest_buf: pointer to destination buffer where data should be copied
+ * @dest_buf_size: size of destination buffer
+ * @src_buf: pointer to constant sysfs source buffer
+ * @src_buf_size: size of source buffer
  *
  * Return: 0 for success and error code for failure
  */

core/hdd/inc/wlan_hdd_sysfs_dump_in_progress.h

@@ -36,7 +36,7 @@ void hdd_sysfs_create_dump_in_progress_interface(struct kobject *wifi_kobject);
 /**
  * hdd_sysfs_destroy_dump_in_progress_interface() - API to destroy
  * dump_in_progress sysfs file
- * @driver_kobject: sysfs driver kobject
+ * @wifi_kobject: sysfs wifi kobject
  *
  * Return: None
  */

core/hdd/inc/wlan_hdd_sysfs_policy_mgr.h

@@ -53,8 +53,8 @@ void hdd_sysfs_pm_cinfo_destroy(struct kobject *driver_kobject);
 int hdd_sysfs_pm_pcl_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_pm_pcl_destroy() -
- *   API to destroy pm_pcl
+ * hdd_sysfs_pm_pcl_destroy() - API to destroy pm_pcl
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

core/hdd/inc/wlan_hdd_sysfs_range_ext.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(WLAN_SYSFS_RANGE_EXT)
 /**
- * wlan_hdd_sysfs_range_ext_create() - API to create range_ext
+ * hdd_sysfs_range_ext_create() - API to create range_ext
  * @adapter: hdd adapter
  *
  * this file is created per adapter.

core/hdd/inc/wlan_hdd_tdls.h

@@ -157,7 +157,7 @@ int hdd_set_tdls_offchannel(struct hdd_context *hdd_ctx,
 			    int offchannel);
 
 /**
- * hdd_check_and_set_tdls_conn_params() - Gets connected TDLS peer count.
+ * hdd_get_tdls_connected_peer_count() - Gets connected TDLS peer count.
  * @adapter: Pointer to adapter
  *
  * This function return number of connected peer.

core/hdd/inc/wlan_hdd_tsf.h

@@ -31,7 +31,7 @@
  * @TSF_CAPTURE_FAIL:             capture fail
  * @TSF_GET_FAIL:                 get fail
  * @TSF_RESET_GPIO_FAIL:          GPIO reset fail
- * @TSF_SAP_NOT_STARTED_NO_TSF    SAP not started
+ * @TSF_SAP_NOT_STARTED_NO_TSF:   SAP not started
  * @TSF_NOT_READY: TSF module is not initialized or init failed
  * @TSF_DISABLED_BY_TSFPLUS: cap_tsf/get_tsf are disabled due to TSF_PLUS
  */

core/hdd/inc/wlan_hdd_tx_rx.h

@@ -21,7 +21,6 @@
 #define WLAN_HDD_TX_RX_H
 
 /**
- *
  * DOC: wlan_hdd_tx_rx.h
  *
  * Linux HDD Tx/RX APIs
@@ -96,7 +95,7 @@ netdev_tx_t hdd_hard_start_xmit(struct sk_buff *skb, struct net_device *dev);
 
 /**
  * hdd_tx_timeout() - Wrapper function to protect __hdd_tx_timeout from SSR
- * @net_dev: pointer to net_device structure
+ * @dev: pointer to net_device structure
  * @txqueue: tx queue
  *
  * Function called by OS if there is any timeout during transmission.
@@ -115,7 +114,7 @@ void hdd_tx_timeout(struct net_device *dev);
 /**
  * hdd_tsf_timestamp_rx() - HDD function to set rx packet timestamp
  * @ctx: pointer to HDD context
- * @nbuf: pointer to skb
+ * @netbuf: pointer to skb
  *
  * Return: None
  */
@@ -143,7 +142,7 @@ void hdd_get_tsf_time_cb(uint8_t vdev_id, uint64_t input_time,
 /**
  * hdd_legacy_gro_get_napi() - HDD function to get napi in legacy gro case
  * @nbuf: n/w buffer pointer
- * @enabled_rxthread: Rx thread enabled/disabled
+ * @enable_rxthread: Rx thread enabled/disabled
  *
  * Return: qdf napi struct on success, NULL on failure
  */
@@ -151,9 +150,9 @@ qdf_napi_struct
 *hdd_legacy_gro_get_napi(qdf_nbuf_t nbuf, bool enable_rxthread);
 
 /**
- * hdd_rx_handle_concurrency() - Handle concurrency related operations
+ * hdd_disable_rx_ol_in_concurrency() - Disable RX Offload in concurrency
  *  for rx
- * @is_concurrency: true if there are concurrenct connections else false
+ * @disable: true if rx offload should be disabled in concurrency
  *
  * Return: none
  */
@@ -195,7 +194,7 @@ bool hdd_tx_flow_control_is_pause(void *adapter_context);
 void hdd_register_tx_flow_control(struct hdd_adapter *adapter,
 		qdf_mc_timer_callback_t timer_callback,
 		ol_txrx_tx_flow_control_fp flow_control_fp,
-		ol_txrx_tx_flow_control_is_pause_fp flow_control_is_pause);
+		ol_txrx_tx_flow_control_is_pause_fp flow_control_is_pause_fp);
 void hdd_deregister_tx_flow_control(struct hdd_adapter *adapter);
 
 /**
@@ -210,7 +209,7 @@ void hdd_get_tx_resource(uint8_t vdev_id,
 
 /**
  * hdd_get_tx_flow_low_watermark() - Get TX flow low watermark info
- * @hdd_cb_handle: HDD opaque ctx
+ * @cb_ctx: HDD opaque ctx
  * @intf_id: HDD adapter id
  *
  * Return: flow low watermark value

core/hdd/inc/wlan_hdd_wext.h

@@ -274,7 +274,7 @@ int hdd_set_11ax_rate(struct hdd_adapter *adapter, int value,
 int hdd_we_update_phymode(struct hdd_adapter *adapter, int new_phymode);
 
 /**
- * wlan_hdd_update_btcoex_mode() - set BTCoex Mode
+ * wlan_hdd_set_btcoex_mode() - set BTCoex Mode
  * @adapter: adapter being modified
  * @value: new BTCoex mode for the adapter
  *

core/hdd/inc/wlan_hdd_wmm.h

@@ -72,9 +72,9 @@
  * @HDD_WMM_USER_MODE_AUTO: STA can associate with any AP, & HDD looks at
  *	the SME notification after association to find out if associated
  *	with QAP and acts accordingly
- * @HDD_WMM_USER_MODE_QBSS_ONLY - SME will add the extra logic to make sure
+ * @HDD_WMM_USER_MODE_QBSS_ONLY: SME will add the extra logic to make sure
  *	STA associates with a QAP only
- * @HDD_WMM_USER_MODE_NO_QOS - Join any AP, but uapsd is disabled
+ * @HDD_WMM_USER_MODE_NO_QOS: Join any AP, but uapsd is disabled
  */
 enum hdd_wmm_user_mode {
 	HDD_WMM_USER_MODE_AUTO = 0,
@@ -92,6 +92,11 @@ enum hdd_wmm_user_mode {
 /**
  * enum hdd_wmm_linuxac: AC/Queue Index values for Linux Qdisc to
  * operate on different traffic.
+ * @HDD_LINUX_AC_VO: voice priority
+ * @HDD_LINUX_AC_VI: video priority
+ * @HDD_LINUX_AC_BE: best effort priority
+ * @HDD_LINUX_AC_BK: background priority
+ * @HDD_LINUX_AC_HI_PRIO: unclassified high priority
  */
 enum hdd_wmm_linuxac {
 	HDD_LINUX_AC_VO = 0,
@@ -119,6 +124,7 @@ enum hdd_wmm_linuxac {
  *	from softirq context to thread context
  * @magic: magic number used to verify that this is a valid context when
  *	referenced anonymously
+ * @is_inactivity_timer_running: true if inactivity timer is running
  */
 struct hdd_wmm_qos_context {
 	struct list_head node;
@@ -134,25 +140,25 @@ struct hdd_wmm_qos_context {
 
 /**
  * struct hdd_wmm_ac_status - WMM related per-AC state & status info
- * @is_access_required - does the AP require access to this AC?
- * @is_access_needed - does the worker thread need to acquire access to
+ * @is_access_required: does the AP require access to this AC?
+ * @is_access_needed: does the worker thread need to acquire access to
  *	this AC?
- * @is_access_pending - is implicit QoS negotiation currently taking place?
- * @has_access_failed - has implicit QoS negotiation already failed?
- * @was_access_granted - has implicit QoS negotiation already succeeded?
- * @is_access_allowed - is access to this AC allowed, either because we
+ * @is_access_pending: is implicit QoS negotiation currently taking place?
+ * @has_access_failed: has implicit QoS negotiation already failed?
+ * @was_access_granted: has implicit QoS negotiation already succeeded?
+ * @is_access_allowed: is access to this AC allowed, either because we
  *	are not doing WMM, we are not doing implicit QoS, implicit QoS has
  *	completed, or explicit QoS has completed?
- * @is_tspec_valid - is the tspec valid?
- * @is_uapsd_info_valid - are the UAPSD-related fields valid?
- * @tspec - current (possibly aggregate) Tspec for this AC
- * @is_uapsd_enabled - is UAPSD enabled on this AC?
- * @uapsd_service_interval - service interval for this AC
- * @uapsd_suspension_interval - suspension interval for this AC
- * @uapsd_direction - direction for this AC
- * @inactivity_time - inactivity time for this AC
- * @last_traffic_count - TX counter used for inactivity detection
- * @inactivity_timer - timer used for inactivity detection
+ * @is_tspec_valid: is the tspec valid?
+ * @is_uapsd_info_valid: are the UAPSD-related fields valid?
+ * @tspec: current (possibly aggregate) Tspec for this AC
+ * @is_uapsd_enabled: is UAPSD enabled on this AC?
+ * @uapsd_service_interval: service interval for this AC
+ * @uapsd_suspension_interval: suspension interval for this AC
+ * @uapsd_direction: direction for this AC
+ * @inactivity_time: inactivity time for this AC
+ * @last_traffic_count: TX counter used for inactivity detection
+ * @inactivity_timer: timer used for inactivity detection
  */
 struct hdd_wmm_ac_status {
 	bool is_access_required;
@@ -178,11 +184,11 @@ struct hdd_wmm_ac_status {
 
 /**
  * struct hdd_wmm_status - WMM status maintained per-adapter
- * @context_list - list of WMM contexts active on the adapter
- * @mutex - mutex used for exclusive access to this adapter's WMM status
- * @ac_status - per-AC WMM status
- * @qap - is this connected to a QoS-enabled AP?
- * @qos_connection - is this a QoS connection?
+ * @context_list: list of WMM contexts active on the adapter
+ * @mutex: mutex used for exclusive access to this adapter's WMM status
+ * @ac_status: per-AC WMM status
+ * @qap: is this connected to a QoS-enabled AP?
+ * @qos_connection: is this a QoS connection?
  */
 struct hdd_wmm_status {
 	struct list_head context_list;
@@ -242,7 +248,7 @@ QDF_STATUS hdd_wmm_dscp_initial_state(struct hdd_adapter *adapter);
 QDF_STATUS hdd_wmm_adapter_init(struct hdd_adapter *adapter);
 
 /**
- * hdd_wmm_close() - WMM close function
+ * hdd_wmm_adapter_close() - WMM close function
  * @adapter: [in]  pointer to adapter context
  *
  * Function which will perform any necessary work to to clean up the
@@ -256,6 +262,7 @@ QDF_STATUS hdd_wmm_adapter_close(struct hdd_adapter *adapter);
  * hdd_select_queue() - Return queue to be used.
  * @dev:	Pointer to the WLAN device.
  * @skb:	Pointer to OS packet (sk_buff).
+ * @sb_dev:     Pointer to subordinate device (unused)
  *
  * This function is registered with the Linux OS for network
  * core to decide which queue to use for the skb.
@@ -440,7 +447,7 @@ int wlan_hdd_cfg80211_config_tspec(struct wiphy *wiphy,
  * QDF_NBUF_CB_TX_EXTRA_IS_CRITICAL is marked 1 for such packets.
  * The function also populates sb->priority for these packets.
  * skb->priority is used as TID for these frames during TX.
-
+ *
  * Return: None
  */
 void hdd_wmm_classify_pkt_cb(void *adapter,