samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: driver: fix list usage without init

Browse Source 
If workqueue creation fails, driver is accessing buffer lists
in session close sequence, which is not yet inited and leading
to NULL ptr dereferrence issue, while traversing uninitialized
list. So added change to avoid accessing list without init
completion.

Change-Id: Icb3aa6b7edaf27e73873ec289d6a921a2613e77e
Signed-off-by: Govindaraj Rajagopal <grajagop@codeaurora.org>
This commit is contained in:
Govindaraj Rajagopal
2021-05-17 14:09:08 +05:30
parent 288887b59d
commit d9518d9182
6 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
driver/vidc/src/msm_vidc_driver.c
View File

@@ -40,6 +40,8 @@ extern struct msm_vidc_core *g_core;
#define SSR_ADDR_ID 0xFFFFFFFF00000000
#define SSR_ADDR_SHIFT 32
#define FPS_WINDOW 10
struct msm_vidc_cap_name {
enum msm_vidc_inst_capability_type cap;
char *name;
@@ -2017,6 +2019,7 @@ int msm_vidc_flush_ts(struct msm_vidc_inst *inst)
msm_vidc_put_ts(inst, ts);
}
inst->timestamps.count = 0;
inst->timestamps.rank = 0;
return 0;
}
@@ -2046,7 +2049,7 @@ int msm_vidc_update_timestamp(struct msm_vidc_inst *inst, u64 timestamp)
inst->timestamps.count++;
/* keep sliding window of 10 ts nodes */
if (inst->timestamps.count > 10) {
if (inst->timestamps.count > FPS_WINDOW) {
ts = msm_vidc_get_least_rank_ts(inst);
if (!ts) {
i_vpr_e(inst, "%s: least rank ts is NULL\n", __func__);
@@ -4547,7 +4550,7 @@ void msm_vidc_destroy_buffers(struct msm_vidc_inst *inst)
}
list_for_each_entry_safe(ts, dummy_ts, &inst->timestamps.list, sort.list) {
i_vpr_e(inst, "%s: removing ts: val %lld, rank %%lld\n",
i_vpr_e(inst, "%s: removing ts: val %lld, rank %lld\n",
__func__, ts->sort.val, ts->rank);
list_del(&ts->sort.list);
msm_vidc_put_ts(inst, ts);