Эх сурвалжийг харах

qcacld-3.0: Fix uninitialized pointer used issue

'sta_self_wmi_rsp' pointer might be used uninitialized
in wma_self_peer_remove func, To fix this issue,
initialize 'sta_self_wmi_rsp' to NULL

Change-Id: I8c6a0ebd8820ac0e1c303b9a932c7f8a8aadc1be
CRs-Fixed: 3687608
Prasanna JS 1 жил өмнө
parent
commit
d40cd31625

+ 3 - 2
core/wma/src/wma_dev_if.c

@@ -555,7 +555,7 @@ static QDF_STATUS wma_self_peer_remove(tp_wma_handle wma_handle,
 	QDF_STATUS qdf_status;
 	QDF_STATUS qdf_status;
 	uint8_t vdev_id = del_vdev_req->vdev_id;
 	uint8_t vdev_id = del_vdev_req->vdev_id;
 	struct wma_target_req *msg = NULL;
 	struct wma_target_req *msg = NULL;
-	struct del_sta_self_rsp_params *sta_self_wmi_rsp;
+	struct del_sta_self_rsp_params *sta_self_wmi_rsp = NULL;
 
 
 	wma_debug("P2P Device: removing self peer "QDF_MAC_ADDR_FMT,
 	wma_debug("P2P Device: removing self peer "QDF_MAC_ADDR_FMT,
 		  QDF_MAC_ADDR_REF(del_vdev_req->self_mac_addr));
 		  QDF_MAC_ADDR_REF(del_vdev_req->self_mac_addr));
@@ -592,7 +592,8 @@ static QDF_STATUS wma_self_peer_remove(tp_wma_handle wma_handle,
 		wma_err("wma_remove_peer is failed");
 		wma_err("wma_remove_peer is failed");
 		wma_remove_req(wma_handle, vdev_id,
 		wma_remove_req(wma_handle, vdev_id,
 			       WMA_DEL_P2P_SELF_STA_RSP_START);
 			       WMA_DEL_P2P_SELF_STA_RSP_START);
-		qdf_mem_free(sta_self_wmi_rsp);
+		if (sta_self_wmi_rsp)
+			qdf_mem_free(sta_self_wmi_rsp);
 
 
 		goto error;
 		goto error;
 	}
 	}