samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Atdalīts 0
Kods Problēmas Izmaiņu pieprasījumi Darbības Pakotnes Projekti Laidieni Vikivietne Aktivitāte

qcacld-3.0: components: Remove logs for qdf_mem_malloc() checks

Pārlūkot izejas kodu 
qdf_mem_malloc() function already takes care of logging the
caller function name and line number in case of any allocation error.
Hence there is no need to add the error log again.

Getting rid of these unnecessary logs reduces driver memory footprint.

Change-Id: If0b9425f82f9ed793c7639c0ed09eb1f868b6d5c
CRs-Fixed: 2781932
Šī revīzija ir iekļauta:
Srinivas Girigowda
2020-09-21 12:26:50 -07:00
revīziju iesūtīja snandini
vecāks ecee02da1d
revīzija d36054fbd2
45 mainīti faili ar 95 papildinājumiem un 282 dzēšanām
Lejupielādēt ielāpa failu Lejupielādēt izmaiņu failu Izvērst visus failus Savērst visus failus

18
components/p2p/core/src/wlan_p2p_main.c
Parādīt failu

@@ -117,10 +117,8 @@ static QDF_STATUS p2p_psoc_obj_create_notification(
}
p2p_soc_obj = qdf_mem_malloc(sizeof(*p2p_soc_obj));
if (!p2p_soc_obj) {
p2p_err("Failed to allocate p2p soc private object");
if (!p2p_soc_obj)
return QDF_STATUS_E_NOMEM;
}
p2p_soc_obj->soc = soc;
@@ -217,10 +215,8 @@ static QDF_STATUS p2p_vdev_obj_create_notification(
p2p_vdev_obj =
qdf_mem_malloc(sizeof(*p2p_vdev_obj));
if (!p2p_vdev_obj) {
p2p_err("Failed to allocate p2p vdev object");
if (!p2p_vdev_obj)
return QDF_STATUS_E_NOMEM;
}
p2p_vdev_obj->vdev = vdev;
p2p_vdev_obj->noa_status = true;
@@ -423,10 +419,8 @@ static QDF_STATUS p2p_send_noa_to_pe(struct p2p_noa_info *noa_info)
}
noa_attr = qdf_mem_malloc(sizeof(*noa_attr));
if (!noa_attr) {
p2p_err("Failed to allocate memory for tSirP2PNoaAttr");
if (!noa_attr)
return QDF_STATUS_E_NOMEM;
}
noa_attr->index = noa_info->index;
noa_attr->opps_ps = noa_info->opps_ps;
@@ -826,10 +820,9 @@ QDF_STATUS p2p_psoc_start(struct wlan_objmgr_psoc *soc,
}
start_param = qdf_mem_malloc(sizeof(*start_param));
if (!start_param) {
p2p_err("Failed to allocate start params");
if (!start_param)
return QDF_STATUS_E_NOMEM;
}
start_param->rx_cb = req->rx_cb;
start_param->rx_cb_data = req->rx_cb_data;
start_param->event_cb = req->event_cb;
@@ -1263,7 +1256,6 @@ QDF_STATUS p2p_process_noa(struct p2p_noa_event *noa_event)
p2p_vdev_obj->noa_info =
qdf_mem_malloc(sizeof(struct p2p_noa_info));
if (!(p2p_vdev_obj->noa_info)) {
p2p_err("Failed to allocate p2p noa info");
status = QDF_STATUS_E_NOMEM;
goto fail;
}

8
components/p2p/core/src/wlan_p2p_off_chan_tx.c
Parādīt failu

@@ -1083,10 +1083,8 @@ static QDF_STATUS p2p_roc_req_for_tx_action(
QDF_STATUS status;
roc_ctx = qdf_mem_malloc(sizeof(struct p2p_roc_context));
if (!roc_ctx) {
p2p_err("Failed to allocate p2p roc context");
if (!roc_ctx)
return QDF_STATUS_E_NOMEM;
}
p2p_soc_obj = tx_ctx->p2p_soc_obj;
roc_ctx->p2p_soc_obj = p2p_soc_obj;
@@ -1834,10 +1832,8 @@ QDF_STATUS p2p_cleanup_tx_sync(
p2p_debug("p2p_soc_obj:%pK, vdev:%pK", p2p_soc_obj, vdev);
param = qdf_mem_malloc(sizeof(*param));
if (!param) {
p2p_err("failed to allocate cleanup param");
if (!param)
return QDF_STATUS_E_NOMEM;
}
param->p2p_soc_obj = p2p_soc_obj;
if (vdev)

6
components/p2p/core/src/wlan_p2p_roc.c
Parādīt failu

@@ -93,7 +93,6 @@ static QDF_STATUS p2p_scan_start(struct p2p_roc_context *roc_ctx)
req = qdf_mem_malloc(sizeof(*req));
if (!req) {
p2p_err("failed to alloc scan start request");
status = QDF_STATUS_E_NOMEM;
goto fail;
}
@@ -176,7 +175,6 @@ static QDF_STATUS p2p_scan_abort(struct p2p_roc_context *roc_ctx)
req = qdf_mem_malloc(sizeof(*req));
if (!req) {
p2p_err("failed to alloc scan cancel request");
status = QDF_STATUS_E_NOMEM;
goto fail;
}
@@ -704,10 +702,8 @@ QDF_STATUS p2p_cleanup_roc_sync(
p2p_debug("p2p_soc_obj:%pK, vdev:%pK", p2p_soc_obj, vdev);
param = qdf_mem_malloc(sizeof(*param));
if (!param) {
p2p_err("failed to allocate cleanup param");
if (!param)
return QDF_STATUS_E_NOMEM;
}
param->p2p_soc_obj = p2p_soc_obj;
if (vdev)

7
components/p2p/dispatcher/src/wlan_p2p_tgt_api.c
Parādīt failu

@@ -107,7 +107,6 @@ QDF_STATUS tgt_p2p_lo_event_cb(struct wlan_objmgr_psoc *psoc,
lo_stop_event = qdf_mem_malloc(sizeof(*lo_stop_event));
if (!lo_stop_event) {
p2p_err("Failed to allocate p2p lo stop event");
qdf_mem_free(event_info);
return QDF_STATUS_E_NOMEM;
}
@@ -158,10 +157,8 @@ tgt_p2p_add_mac_addr_status_event_cb(struct wlan_objmgr_psoc *psoc,
}
mac_filter_rsp = qdf_mem_malloc(sizeof(*mac_filter_rsp));
if (!mac_filter_rsp) {
p2p_err("random_mac:Failed to allocate mac_filter_rsp");
if (!mac_filter_rsp)
return QDF_STATUS_E_NOMEM;
}
mac_filter_rsp->p2p_soc_obj = p2p_soc_obj;
mac_filter_rsp->vdev_id = event_info->vdev_id;
@@ -259,7 +256,6 @@ QDF_STATUS tgt_p2p_mgmt_ota_comp_cb(void *context, qdf_nbuf_t buf,
tx_conf_event = qdf_mem_malloc(sizeof(*tx_conf_event));
if (!tx_conf_event) {
p2p_err("Failed to allocate tx cnf event");
qdf_nbuf_free(buf);
return QDF_STATUS_E_NOMEM;
}
@@ -408,7 +404,6 @@ QDF_STATUS tgt_p2p_noa_event_cb(struct wlan_objmgr_psoc *psoc,
noa_event = qdf_mem_malloc(sizeof(*noa_event));
if (!noa_event) {
p2p_err("Failed to allocate p2p noa event");
qdf_mem_free(event_info);
return QDF_STATUS_E_NOMEM;
}

13
components/p2p/dispatcher/src/wlan_p2p_ucfg_api.c
Parādīt failu

@@ -135,10 +135,8 @@ QDF_STATUS ucfg_p2p_roc_req(struct wlan_objmgr_psoc *soc,
}
roc_ctx = qdf_mem_malloc(sizeof(*roc_ctx));
if (!roc_ctx) {
p2p_err("failed to allocate p2p roc context");
if (!roc_ctx)
return QDF_STATUS_E_NOMEM;
}
status = qdf_idr_alloc(&p2p_soc_obj->p2p_idr, roc_ctx, &id);
if (QDF_IS_STATUS_ERROR(status)) {
@@ -344,10 +342,8 @@ QDF_STATUS ucfg_p2p_mgmt_tx(struct wlan_objmgr_psoc *soc,
}
tx_action = qdf_mem_malloc(sizeof(*tx_action));
if (!tx_action) {
p2p_err("Failed to allocate tx action context");
if (!tx_action)
return QDF_STATUS_E_NOMEM;
}
/* return cookie just for ota ack frames */
if (mgmt_frm->dont_wait_for_ack)
@@ -373,7 +369,6 @@ QDF_STATUS ucfg_p2p_mgmt_tx(struct wlan_objmgr_psoc *soc,
tx_action->off_chan = mgmt_frm->off_chan;
tx_action->buf = qdf_mem_malloc(tx_action->buf_len);
if (!(tx_action->buf)) {
p2p_err("Failed to allocate buffer for action frame");
qdf_mem_free(tx_action);
return QDF_STATUS_E_NOMEM;
}
@@ -436,10 +431,8 @@ QDF_STATUS ucfg_p2p_mgmt_tx_cancel(struct wlan_objmgr_psoc *soc,
p2p_del_random_mac(soc, wlan_vdev_get_id(vdev), cookie, 20);
cancel_tx = qdf_mem_malloc(sizeof(*cancel_tx));
if (!cancel_tx) {
p2p_err("Failed to allocate cancel p2p roc");
if (!cancel_tx)
return QDF_STATUS_E_NOMEM;
}
cancel_tx->p2p_soc_obj = p2p_soc_obj;
cancel_tx->cookie = (uintptr_t)tx_ctx;