samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: fix null pointer 'err' reference issue

Browse Source 
When 'err' is null pointer, QDF_ASSERT(0) will not return
directly, then null pointer reference will occur. To fix this
issue, return failure when 'err' is null pointer.

Change-Id: I5912571795ae55c6729ae06d5e06496598c21fbb
CRs-Fixed: 2642581
This commit is contained in:
Rongjing Liao
2020-03-16 21:47:43 +08:00
committed by nshrivas
parent 7ccc84acb3
commit cff463564e
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
target_if/spectral/target_if_spectral.c
View File

@@ -2893,6 +2893,7 @@ _target_if_set_spectral_config(struct target_if_spectral *spectral,
if (!err) {
spectral_err("Error code argument is null");
QDF_ASSERT(0);
return QDF_STATUS_E_FAILURE;
}
*err = SPECTRAL_SCAN_ERR_INVALID;
@@ -3059,6 +3060,7 @@ target_if_set_spectral_config(struct wlan_objmgr_pdev *pdev,
if (!err) {
spectral_err("Error code argument is null");
QDF_ASSERT(0);
return QDF_STATUS_E_FAILURE;
}
*err = SPECTRAL_SCAN_ERR_INVALID;
@@ -3782,6 +3784,7 @@ target_if_start_spectral_scan(struct wlan_objmgr_pdev *pdev,
if (!err) {
spectral_err("Error code argument is null");
QDF_ASSERT(0);
return QDF_STATUS_E_FAILURE;
}
*err = SPECTRAL_SCAN_ERR_INVALID;
@@ -3951,6 +3954,7 @@ target_if_stop_spectral_scan(struct wlan_objmgr_pdev *pdev,
if (!err) {
spectral_err("Error code argument is null");
QDF_ASSERT(0);
return QDF_STATUS_E_FAILURE;
}
*err = SPECTRAL_SCAN_ERR_INVALID;