Эх сурвалжийг харах

qcacld-3.0: Fix null pointer dereference in wma_roam_scan_offload_mode

In wma_roam_scan_offload_mode function validate mem_alloc return pointer
to avoid NULL pointer dereference.

Change-Id: Ib2733346614ddb99ac329aa929a774db2c4325d6
CRs-Fixed: 1082162
(cherry picked from commit 97961da746e461c6f4f8ab3d77b269db77e5d2fa)
Arif Hussain 8 жил өмнө
parent
commit
cf6b960cb0

+ 7 - 4
core/wma/src/wma_scan_roam.c

@@ -755,14 +755,17 @@ QDF_STATUS wma_roam_scan_offload_mode(tp_wma_handle wma_handle,
 	struct roam_offload_scan_params *params =
 				qdf_mem_malloc(sizeof(*params));
 
+	if (!params) {
+		WMA_LOGE("%s: Failed to allocate scan params", __func__);
+		return QDF_STATUS_E_NOMEM;
+	}
 #ifdef WLAN_FEATURE_ROAM_OFFLOAD
-	int auth_mode = WMI_AUTH_NONE;
+	params->auth_mode = WMI_AUTH_NONE;
 	if (roam_req)
-		auth_mode = e_csr_auth_type_to_rsn_authmode
+		params->auth_mode = e_csr_auth_type_to_rsn_authmode
 				    (roam_req->ConnectedNetwork.authentication,
 				    roam_req->ConnectedNetwork.encryption);
-	WMA_LOGD("%s : auth mode = %d", __func__, auth_mode);
-	params->auth_mode = auth_mode;
+	WMA_LOGD("%s : auth mode = %d", __func__, params->auth_mode);
 #endif /* WLAN_FEATURE_ROAM_OFFLOAD */
 
 	params->is_roam_req_valid = 0;