samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Add NULL check for return value

Browse Source 
Currently at multiple places there is no
NULL check for return value which might
result in NULL pointer dereference.
Add NULL check for return value to avoid any
NULL pointer dereference.

Change-Id: I986a48d9649b67cb5a078ec38eea64da4ef9244e
CRs-Fixed: 3273489
This commit is contained in:
Amit Mehta
2022-08-22 23:08:49 -07:00
committed by Madan Koyyalamudi
parent c14d6ed422
commit cf37b0c153
4 changed files with 63 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
components/dp/core/inc/wlan_dp_main.h
View File

@@ -317,6 +317,11 @@ dp_add_latency_critical_client(struct wlan_objmgr_vdev *vdev,
{
struct wlan_dp_intf *dp_intf = dp_get_vdev_priv_obj(vdev);
if (!dp_intf) {
dp_err("Unable to get DP interface");
return;
}
switch (phymode) {
case QCA_WLAN_802_11_MODE_11A:
case QCA_WLAN_802_11_MODE_11G:
@@ -350,6 +355,11 @@ dp_del_latency_critical_client(struct wlan_objmgr_vdev *vdev,
{
struct wlan_dp_intf *dp_intf = dp_get_vdev_priv_obj(vdev);
if (!dp_intf) {
dp_err("Unable to get DP interface");
return;
}
switch (phymode) {
case QCA_WLAN_802_11_MODE_11A:
case QCA_WLAN_802_11_MODE_11G:

9
components/dp/core/src/wlan_dp_bus_bandwidth.c
View File

@@ -2150,6 +2150,11 @@ void dp_bus_bw_compute_prev_txrx_stats(struct wlan_objmgr_vdev *vdev)
struct wlan_dp_intf *dp_intf = dp_get_vdev_priv_obj(vdev);
struct wlan_dp_psoc_context *dp_ctx = dp_psoc_get_priv(psoc);
if (!dp_intf) {
dp_err("Unable to get DP interface");
return;
}
if (QDF_GLOBAL_FTM_MODE == cds_get_conparam())
return;
@@ -2171,6 +2176,10 @@ void dp_bus_bw_compute_reset_prev_txrx_stats(struct wlan_objmgr_vdev *vdev)
struct wlan_dp_intf *dp_intf = dp_get_vdev_priv_obj(vdev);
struct wlan_dp_psoc_context *dp_ctx = dp_psoc_get_priv(psoc);
if (!dp_intf) {
dp_err("Unable to get DP interface");
return;
}
if (QDF_GLOBAL_FTM_MODE == cds_get_conparam())
return;

20
components/dp/dispatcher/src/wlan_dp_ucfg_api.c
View File

@@ -1791,6 +1791,11 @@ void ucfg_dp_set_nud_stats_cb(struct wlan_objmgr_psoc *psoc, void *cookie)
{
struct wlan_dp_psoc_sb_ops *sb_ops = dp_intf_get_tx_ops(psoc);
if (!sb_ops) {
dp_err("Unable to get ops");
return;
}
sb_ops->dp_arp_stats_register_event_handler(psoc);
sb_ops->arp_request_ctx = cookie;
}
@@ -1799,6 +1804,11 @@ void ucfg_dp_clear_nud_stats_cb(struct wlan_objmgr_psoc *psoc)
{
struct wlan_dp_psoc_sb_ops *sb_ops = dp_intf_get_tx_ops(psoc);
if (!sb_ops) {
dp_err("Unable to get ops");
return;
}
sb_ops->dp_arp_stats_unregister_event_handler(psoc);
}
@@ -1833,6 +1843,11 @@ ucfg_dp_req_get_arp_stats(struct wlan_objmgr_psoc *psoc,
{
struct wlan_dp_psoc_sb_ops *sb_ops = dp_intf_get_tx_ops(psoc);
if (!sb_ops) {
dp_err("Unable to get ops");
return QDF_STATUS_E_INVAL;
}
return sb_ops->dp_get_arp_req_stats(psoc, params);
}
@@ -1842,6 +1857,11 @@ ucfg_dp_req_set_arp_stats(struct wlan_objmgr_psoc *psoc,
{
struct wlan_dp_psoc_sb_ops *sb_ops = dp_intf_get_tx_ops(psoc);
if (!sb_ops) {
dp_err("Unable to get ops");
return QDF_STATUS_E_INVAL;
}
return sb_ops->dp_set_arp_req_stats(psoc, params);
}