samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Initialize ret in send_pdev_utf_cmd_tlv

Browse Source 
If param->len was 0, ret would be returned without being initialized.
param->len of 0 is unexpected, so return an error.

Change-Id: Ib9b0a60976dedcf8fcd4184083a9948892791621
CRs-Fixed: 1072077
This commit is contained in:
Houston Hoffman
2016-09-27 23:29:49 -07:00
committed by qcabuildsw
parent 01b7ac01b1
commit cdd5eda297
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wmi_unified.c
View File

@@ -1719,8 +1719,8 @@ static bool wmi_is_pm_resume_cmd(uint32_t cmd_id)
* *
* Return: 0 on success * Return: 0 on success
*/ */
int wmi_unified_cmd_send(wmi_unified_t wmi_handle, wmi_buf_t buf, uint32_t len, QDF_STATUS wmi_unified_cmd_send(wmi_unified_t wmi_handle, wmi_buf_t buf,
uint32_t cmd_id) uint32_t len, uint32_t cmd_id)
{ {
HTC_PACKET *pkt; HTC_PACKET *pkt;
A_STATUS status; A_STATUS status;
@@ -1739,7 +1739,7 @@ int wmi_unified_cmd_send(wmi_unified_t wmi_handle, wmi_buf_t buf, uint32_t len,
if (wmi_handle->wmi_stopinprogress) { if (wmi_handle->wmi_stopinprogress) {
QDF_TRACE(QDF_MODULE_ID_WMI, QDF_TRACE_LEVEL_ERROR, QDF_TRACE(QDF_MODULE_ID_WMI, QDF_TRACE_LEVEL_ERROR,
"WMI stop in progress\n"); "WMI stop in progress\n");
return -EINVAL; return QDF_STATUS_E_INVAL;
} }
#ifndef WMI_NON_TLV_SUPPORT #ifndef WMI_NON_TLV_SUPPORT

3
wmi_unified_tlv.c
View File

@@ -777,7 +777,8 @@ send_pdev_utf_cmd_tlv(wmi_unified_t wmi_handle,
{ {
wmi_buf_t buf; wmi_buf_t buf;
uint8_t *cmd; uint8_t *cmd;
QDF_STATUS ret; /* if param->len is 0 no data is sent, return error */
QDF_STATUS ret = QDF_STATUS_E_INVAL;
static uint8_t msgref = 1; static uint8_t msgref = 1;
uint8_t segNumber = 0, segInfo, numSegments; uint8_t segNumber = 0, segInfo, numSegments;
uint16_t chunk_len, total_bytes; uint16_t chunk_len, total_bytes;