浏览代码

qcacmn: Crash if the tag length and filled data are not matching

Whenever a wmi even it received the tlv received from the firmware
will be sanitized, if there is any error the event would be dropped.
This dropping of the event can give side effects in the host/firmware
after some time and making it difficult to find the actual reason of
why the tlv is not received properly.

Crash the system if the tlv is not parsed correctly to debug the issues.

Change-Id: Ic56e3f96252ac74917caeebc8296c2b50ae4f3cd
CRs-Fixed: 2695053
Arun Kumar Khandavalli 5 年之前
父节点
当前提交
ca24670e56
共有 1 个文件被更改,包括 2 次插入3 次删除
  1. 2 3
      wmi/src/wmi_unified.c

+ 2 - 3
wmi/src/wmi_unified.c

@@ -2415,9 +2415,8 @@ void __wmi_control_rx(struct wmi_unified *wmi_handle, wmi_buf_t evt_buf)
 							data, len, id,
 							&wmi_cmd_struct_ptr);
 		if (tlv_ok_status != 0) {
-			QDF_TRACE(QDF_MODULE_ID_WMI, QDF_TRACE_LEVEL_ERROR,
-				  "%s: Error: id=0x%x, wmitlv check status=%d",
-				  __func__, id, tlv_ok_status);
+			QDF_DEBUG_PANIC("%s: Error: id=0x%x, wmitlv check status=%d",
+					__func__, id, tlv_ok_status);
 			goto end;
 		}
 	}