samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Crash if the tag length and filled data are not matching

Browse Source 
Whenever a wmi even it received the tlv received from the firmware
will be sanitized, if there is any error the event would be dropped.
This dropping of the event can give side effects in the host/firmware
after some time and making it difficult to find the actual reason of
why the tlv is not received properly.

Crash the system if the tlv is not parsed correctly to debug the issues.

Change-Id: Ic56e3f96252ac74917caeebc8296c2b50ae4f3cd
CRs-Fixed: 2695053
This commit is contained in:
Arun Kumar Khandavalli
2020-05-27 15:10:04 +05:30
committed by nshrivas
parent eed5d30c55
commit ca24670e56
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
wmi/src/wmi_unified.c
View File

@@ -2415,9 +2415,8 @@ void __wmi_control_rx(struct wmi_unified *wmi_handle, wmi_buf_t evt_buf)
data, len, id,
&wmi_cmd_struct_ptr);
if (tlv_ok_status != 0) {
QDF_TRACE(QDF_MODULE_ID_WMI, QDF_TRACE_LEVEL_ERROR,
"%s: Error: id=0x%x, wmitlv check status=%d",
__func__, id, tlv_ok_status);
QDF_DEBUG_PANIC("%s: Error: id=0x%x, wmitlv check status=%d",
__func__, id, tlv_ok_status);
goto end;
}
}