qcacmn: Remove redundant check in wlan_scan_start

In api wlan_scan_start(), redundant check for
scan_start_req is observed in some static analysis
tool.

Remove the redundant check in the ap
wlan_scan_start() as the check is present in the
api scm_scan_free_scan_request_mem

Change-Id: Ic320bb95253668310c5d738216daba62ba2f4b3f
CRs-Fixed: 3528505

umac/cmn_services/mgmt_txrx/dispatcher/inc/wlan_mgmt_txrx_rx_reo_utils_api.h

@@ -599,6 +599,8 @@ wlan_mgmt_rx_reo_psoc_obj_create_notification(struct wlan_objmgr_psoc *psoc)
 static inline QDF_STATUS
 wlan_mgmt_rx_reo_psoc_obj_destroy_notification(struct wlan_objmgr_psoc *psoc)
 {
+	if (!psoc)
+		return QDF_STATUS_E_FAILURE;
 	return QDF_STATUS_SUCCESS;
 }
 

umac/scan/dispatcher/src/wlan_scan_api.c

@@ -408,8 +408,7 @@ QDF_STATUS wlan_scan_start(struct scan_start_request *req)
 
 	if (!req || !req->vdev) {
 		scm_err("req or vdev within req is NULL");
-		if (req)
-			scm_scan_free_scan_request_mem(req);
+		scm_scan_free_scan_request_mem(req);
 		return QDF_STATUS_E_NULL_VALUE;
 	}