Jelajahi Sumber

qcacld-3.0: TWT Logging Debug Enhancement

Peer MAC address is not specified when get_peer_by_mac fails.
We should print the peer MAC address with  debug message.

Change-Id: I9d75098784879ddecd447f8dbbcd61e6cdc1bf76
CRs-Fixed: 3153776
David Oladunjoye 3 tahun lalu
induk
melakukan
c9287e836d

+ 26 - 13
components/mlme/core/src/wlan_mlme_twt_api.c

@@ -39,7 +39,8 @@ bool mlme_is_max_twt_sessions_reached(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return true;
 	}
 
@@ -79,7 +80,8 @@ bool mlme_is_twt_setup_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -118,7 +120,8 @@ void mlme_add_twt_session(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -153,7 +156,8 @@ void mlme_set_twt_setup_done(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -188,7 +192,8 @@ QDF_STATUS mlme_init_twt_context(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_debug("Peer object not found");
+		mlme_legacy_debug("Peer object not found "QDF_MAC_ADDR_FMT,
+				  QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -303,7 +308,8 @@ bool mlme_is_twt_setup_done(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -368,7 +374,8 @@ void mlme_set_twt_session_state(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -403,7 +410,8 @@ mlme_get_twt_session_state(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return WLAN_TWT_SETUP_STATE_NOT_ESTABLISHED;
 	}
 
@@ -437,7 +445,8 @@ uint8_t mlme_get_twt_peer_capabilities(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -464,7 +473,8 @@ void mlme_set_twt_peer_capabilities(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -687,7 +697,8 @@ bool mlme_sap_twt_peer_is_cmd_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -736,7 +747,8 @@ QDF_STATUS mlme_set_twt_command_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -805,7 +817,8 @@ bool mlme_twt_is_command_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_MLME_NB_ID);
 	if (!peer) {
-		mlme_legacy_err("Peer object not found");
+		mlme_legacy_err("Peer object not found "QDF_MAC_ADDR_FMT,
+				QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 

+ 26 - 13
components/umac/twt/core/src/wlan_twt_main.c

@@ -50,7 +50,8 @@ wlan_twt_add_session(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -91,7 +92,8 @@ wlan_twt_set_command_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -131,7 +133,8 @@ wlan_twt_init_context(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -378,7 +381,8 @@ wlan_twt_sap_peer_is_cmd_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -815,7 +819,8 @@ bool wlan_twt_is_setup_done(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -856,7 +861,8 @@ bool wlan_twt_is_max_sessions_reached(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return true;
 	}
 
@@ -899,7 +905,8 @@ bool wlan_twt_is_setup_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -956,7 +963,8 @@ wlan_twt_set_ack_context(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return QDF_STATUS_E_FAILURE;
 	}
 
@@ -1011,7 +1019,8 @@ wlan_twt_get_ack_context(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		goto err;
 	}
 
@@ -1061,7 +1070,8 @@ bool wlan_twt_is_command_in_progress(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return false;
 	}
 
@@ -1515,7 +1525,8 @@ wlan_twt_set_setup_done(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -1564,7 +1575,8 @@ wlan_twt_set_session_state(struct wlan_objmgr_psoc *psoc,
 	peer = wlan_objmgr_get_peer_by_mac(psoc, peer_mac->bytes,
 					   WLAN_TWT_ID);
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return;
 	}
 
@@ -1602,7 +1614,8 @@ wlan_twt_get_session_state(struct wlan_objmgr_psoc *psoc,
 					   WLAN_TWT_ID);
 
 	if (!peer) {
-		twt_err("Peer object not found");
+		twt_err("Peer object not found "QDF_MAC_ADDR_FMT,
+			QDF_MAC_ADDR_REF(peer_mac));
 		return WLAN_TWT_SETUP_STATE_NOT_ESTABLISHED;
 	}