Explorar o código

qcacld-3.0: Fix hdd/src documentation

The kernel-doc script identified documentation issues in the hdd
layer, so fix the ones in the "src" folder.

Change-Id: I20307c4c7e02163a13a79dfd4fcf8fc734a4b230
CRs-Fixed: 3343791
Jeff Johnson %!s(int64=2) %!d(string=hai) anos
pai
achega
c91958c650
Modificáronse 80 ficheiros con 631 adicións e 480 borrados
  1. 3 3
      core/hdd/src/wlan_hdd_apf.c
  2. 1 3
      core/hdd/src/wlan_hdd_assoc.c
  3. 10 8
      core/hdd/src/wlan_hdd_cfg.c
  4. 60 104
      core/hdd/src/wlan_hdd_cfg80211.c
  5. 5 5
      core/hdd/src/wlan_hdd_cfg80211.h
  6. 3 3
      core/hdd/src/wlan_hdd_cm_api.h
  7. 1 0
      core/hdd/src/wlan_hdd_connectivity_logging.c
  8. 3 2
      core/hdd/src/wlan_hdd_data_stall_detection.c
  9. 2 1
      core/hdd/src/wlan_hdd_debugfs.c
  10. 3 3
      core/hdd/src/wlan_hdd_debugfs_roam.c
  11. 2 1
      core/hdd/src/wlan_hdd_debugfs_unit_test.c
  12. 6 5
      core/hdd/src/wlan_hdd_disa.c
  13. 1 1
      core/hdd/src/wlan_hdd_eht.c
  14. 2 2
      core/hdd/src/wlan_hdd_ext_scan.c
  15. 2 1
      core/hdd/src/wlan_hdd_fips.c
  16. 2 1
      core/hdd/src/wlan_hdd_fw_state.c
  17. 3 2
      core/hdd/src/wlan_hdd_gpio.c
  18. 1 1
      core/hdd/src/wlan_hdd_he.c
  19. 7 6
      core/hdd/src/wlan_hdd_hostapd.h
  20. 23 5
      core/hdd/src/wlan_hdd_hostapd_wext.c
  21. 10 9
      core/hdd/src/wlan_hdd_ioctl.c
  22. 2 2
      core/hdd/src/wlan_hdd_ioctl.h
  23. 1 0
      core/hdd/src/wlan_hdd_ipa.c
  24. 30 27
      core/hdd/src/wlan_hdd_main.c
  25. 3 2
      core/hdd/src/wlan_hdd_main_module.c
  26. 2 2
      core/hdd/src/wlan_hdd_mcc_quota.h
  27. 2 2
      core/hdd/src/wlan_hdd_medium_assess.c
  28. 3 2
      core/hdd/src/wlan_hdd_medium_assess.h
  29. 10 17
      core/hdd/src/wlan_hdd_memdump.c
  30. 1 1
      core/hdd/src/wlan_hdd_mlo.c
  31. 2 2
      core/hdd/src/wlan_hdd_nan_datapath.c
  32. 11 11
      core/hdd/src/wlan_hdd_nan_datapath.h
  33. 3 1
      core/hdd/src/wlan_hdd_napi.c
  34. 2 0
      core/hdd/src/wlan_hdd_object_manager.h
  35. 7 4
      core/hdd/src/wlan_hdd_ocb.c
  36. 37 7
      core/hdd/src/wlan_hdd_ocb.h
  37. 26 43
      core/hdd/src/wlan_hdd_p2p.c
  38. 2 1
      core/hdd/src/wlan_hdd_p2p_listen_offload.h
  39. 11 11
      core/hdd/src/wlan_hdd_power.c
  40. 2 2
      core/hdd/src/wlan_hdd_pre_cac.c
  41. 10 3
      core/hdd/src/wlan_hdd_regulatory.c
  42. 4 4
      core/hdd/src/wlan_hdd_sar_limits.c
  43. 3 2
      core/hdd/src/wlan_hdd_sar_limits.h
  44. 8 11
      core/hdd/src/wlan_hdd_scan.c
  45. 2 1
      core/hdd/src/wlan_hdd_scan.h
  46. 2 1
      core/hdd/src/wlan_hdd_softap_tx_rx.c
  47. 4 4
      core/hdd/src/wlan_hdd_son.c
  48. 1 1
      core/hdd/src/wlan_hdd_son.h
  49. 19 11
      core/hdd/src/wlan_hdd_sta_info.h
  50. 16 11
      core/hdd/src/wlan_hdd_station_info.c
  51. 21 17
      core/hdd/src/wlan_hdd_stats.c
  52. 5 6
      core/hdd/src/wlan_hdd_stats.h
  53. 2 2
      core/hdd/src/wlan_hdd_sysfs_add_timestamp.h
  54. 2 1
      core/hdd/src/wlan_hdd_sysfs_dl_modes.h
  55. 5 4
      core/hdd/src/wlan_hdd_sysfs_dp_aggregation.h
  56. 3 2
      core/hdd/src/wlan_hdd_sysfs_dp_trace.h
  57. 1 1
      core/hdd/src/wlan_hdd_sysfs_eht_rate.c
  58. 3 2
      core/hdd/src/wlan_hdd_sysfs_fw_mode_config.h
  59. 1 0
      core/hdd/src/wlan_hdd_sysfs_get_freq_for_pwr.h
  60. 3 3
      core/hdd/src/wlan_hdd_sysfs_gtx_bw_mask.h
  61. 3 2
      core/hdd/src/wlan_hdd_sysfs_mem_stats.h
  62. 2 1
      core/hdd/src/wlan_hdd_sysfs_motion_detection.h
  63. 2 1
      core/hdd/src/wlan_hdd_sysfs_radar.h
  64. 3 2
      core/hdd/src/wlan_hdd_sysfs_scan_config.h
  65. 2 0
      core/hdd/src/wlan_hdd_sysfs_scan_disable.h
  66. 3 2
      core/hdd/src/wlan_hdd_sysfs_thermal_cfg.h
  67. 2 1
      core/hdd/src/wlan_hdd_sysfs_txrx_fw_st_rst.h
  68. 2 1
      core/hdd/src/wlan_hdd_sysfs_txrx_fw_stats.h
  69. 3 3
      core/hdd/src/wlan_hdd_sysfs_txrx_stats.h
  70. 2 0
      core/hdd/src/wlan_hdd_sysfs_wlan_dbg.h
  71. 3 2
      core/hdd/src/wlan_hdd_sysfs_wow_ito.h
  72. 3 15
      core/hdd/src/wlan_hdd_tdls.c
  73. 14 13
      core/hdd/src/wlan_hdd_thermal.h
  74. 8 11
      core/hdd/src/wlan_hdd_tsf.c
  75. 10 9
      core/hdd/src/wlan_hdd_twt.c
  76. 4 2
      core/hdd/src/wlan_hdd_tx_rx.c
  77. 1 1
      core/hdd/src/wlan_hdd_wds.h
  78. 137 15
      core/hdd/src/wlan_hdd_wext.c
  79. 3 7
      core/hdd/src/wlan_hdd_wmm.c
  80. 2 2
      core/hdd/src/wlan_hdd_wowl.c

+ 3 - 3
core/hdd/src/wlan_hdd_apf.c

@@ -105,7 +105,7 @@ void hdd_get_apf_capabilities_cb(void *context,
 
 /**
  * hdd_post_get_apf_capabilities_rsp() - Callback function to APF Offload
- * @hdd_context: hdd_context
+ * @hdd_ctx: hdd_context
  * @apf_get_offload: struct for get offload
  *
  * Return: 0 on success, error number otherwise.
@@ -412,7 +412,7 @@ hdd_apf_write_memory(struct hdd_adapter *adapter, struct nlattr **tb)
 /**
  * hdd_apf_read_memory_callback - HDD Callback for the APF read memory
  *	operation
- * @context: Hdd context
+ * @hdd_context: Hdd context
  * @evt: APF read memory event response parameters
  *
  * Return: 0 on success, errno on failure
@@ -589,7 +589,7 @@ fail:
 }
 
 /**
- * wlan_hdd_cfg80211_apf_offload() - Set/Reset to APF Offload
+ * __wlan_hdd_cfg80211_apf_offload() - Set/Reset to APF Offload
  * @wiphy:    wiphy structure pointer
  * @wdev:     Wireless device structure pointer
  * @data:     Pointer to the data received

+ 1 - 3
core/hdd/src/wlan_hdd_assoc.c

@@ -407,6 +407,7 @@ enum band_info hdd_conn_get_connected_band(struct hdd_adapter *adapter)
 
 /**
  * hdd_conn_get_connected_cipher_algo() - get current connection cipher type
+ * @adapter: pointer to the hdd adapter
  * @sta_ctx: pointer to global HDD Station context
  * @pConnectedCipherAlgo: pointer to connected cipher algo
  *
@@ -1568,9 +1569,6 @@ bool hdd_any_valid_peer_present(struct hdd_adapter *adapter)
  * hdd_roam_mic_error_indication_handler() - MIC error indication handler
  * @adapter: pointer to adapter
  * @roam_info: pointer to roam info
- * @roam_id: roam id
- * @roam_status: roam status
- * @roam_result: roam result
  *
  * This function indicates the Mic failure to the supplicant
  *

+ 10 - 8
core/hdd/src/wlan_hdd_cfg.c

@@ -385,7 +385,7 @@ static void hdd_disable_runtime_pm(struct hdd_config *cfg_ini)
 
 /**
  * hdd_restore_runtime_pm() - Restore runtime_pm configuration.
- * @cfg_ini: Handle to struct hdd_config
+ * @hdd_ctx: HDD context
  *
  * Return: None
  */
@@ -419,7 +419,7 @@ static void hdd_disable_auto_shutdown(struct hdd_config *cfg_ini)
 
 /**
  * hdd_restore_auto_shutdown() - Restore auto_shutdown configuration.
- * @cfg_ini: Handle to struct hdd_config
+ * @hdd_ctx: HDD context
  *
  * Return: None
  */
@@ -603,9 +603,9 @@ static void hdd_set_oem_6g_supported(struct hdd_context *hdd_ctx)
 }
 
 /**
- * hdd_convert_string_to_u8_array() - used to convert string into u8 array
+ * hdd_convert_string_to_array() - used to convert string into u8 array
  * @str: String to be converted
- * @hex_array: Array where converted value is stored
+ * @array: Array where converted value is stored
  * @len: Length of the populated array
  * @array_max_len: Maximum length of the array
  * @to_hex: true, if conversion required for hex string
@@ -1059,6 +1059,7 @@ void hdd_cfg_print_global_config(struct hdd_context *hdd_ctx)
 /**
  * hdd_get_pmkid_modes() - returns PMKID mode bits
  * @hdd_ctx: the pointer to hdd context
+ * @pmkid_modes: struct to update with current PMKID modes
  *
  * Return: value of pmkid_modes
  */
@@ -1560,15 +1561,16 @@ static QDF_STATUS hdd_get_sap_rx_nss(struct hdd_adapter *adapter,
 }
 
 /**
- * hdd_get_sta_tx_nss() - get the sta tx nss
+ * hdd_get_sta_rx_nss() - get the sta rx nss
  * @hdd_ctx: Pointer to hdd context
  * @adapter: Pointer to adapter
  * @vdev: Pointer to vdev
- * @tx_nss: pointer to tx_nss
+ * @rx_nss: pointer to rx_nss
  *
- * get the STA tx nss
+ * get the STA rx nss
  *
- * Return: None
+ * Return: QDF_STATUS_SUCCESS if the RX NSS is returned, otherwise a suitable
+ *         QDF_STATUS_E_* error code
  */
 static QDF_STATUS hdd_get_sta_rx_nss(struct hdd_adapter *adapter,
 				     struct hdd_context *hdd_ctx,

+ 60 - 104
core/hdd/src/wlan_hdd_cfg80211.c

@@ -209,7 +209,7 @@
 #define WLAN_WAIT_WLM_LATENCY_LEVEL 1000
 
 /**
- * rtt_is_initiator - Macro to check if the bitmap has any RTT roles set
+ * rtt_is_enabled - Macro to check if the bitmap has any RTT roles set
  * @bitmap: The bitmap to be checked
  */
 #define rtt_is_enabled(bitmap) \
@@ -1292,6 +1292,7 @@ hdd_convert_hang_reason(enum qdf_hang_reason reason)
  * @hdd_ctx: Pointer to hdd context
  * @reason: cds recovery reason
  * @data: Hang Data
+ * @data_len: length of @data
  *
  * Return: 0 on success or failure reason
  */
@@ -2436,7 +2437,7 @@ hdd_update_reg_chan_info(struct hdd_adapter *adapter,
  * hdd_cfg80211_update_channel_info() - add channel info attributes
  * @hdd_ctx: pointer to hdd context
  * @skb: pointer to sk buff
- * @hdd_ctx: pointer to hdd station context
+ * @sap_config: pointer to SAP configuration
  * @idx: attribute index
  *
  * Return: Success(0) or reason code for failure
@@ -2533,7 +2534,7 @@ fail:
  * hdd_cfg80211_update_pcl() - add pcl info attributes
  * @hdd_ctx: pointer to hdd context
  * @skb: pointer to sk buff
- * @hdd_ctx: pointer to hdd station context
+ * @ch_list_count: number of channels to add
  * @idx: attribute index
  * @vendor_pcl_list: PCL list
  * @vendor_weight_list: PCL weights
@@ -2597,7 +2598,7 @@ static void hdd_get_scan_band(struct hdd_context *hdd_ctx,
 
 /**
  * wlan_hdd_sap_get_valid_channellist() - Get SAPs valid channel list
- * @ap_adapter: adapter
+ * @adapter: adapter
  * @channel_count: valid channel count
  * @freq_list: valid channel frequency (MHz) list
  * @band: frequency band
@@ -4049,8 +4050,6 @@ static uint16_t wlan_hdd_acs_get_puncture_bitmap(struct sap_acs_cfg *acs_cfg)
 /**
  * wlan_hdd_cfg80211_acs_ch_select_evt: Callback function for ACS evt
  * @adapter: Pointer to SAP adapter struct
- * @pri_channel: SAP ACS procedure selected Primary channel
- * @sec_channel: SAP ACS procedure selected secondary channel
  *
  * This is a callback function on ACS procedure is completed.
  * This function send the ACS selected channel information to hostapd
@@ -4496,6 +4495,8 @@ wlan_hdd_cfg80211_set_scanning_mac_oui(struct wiphy *wiphy,
 	return errno;
 }
 
+#define NUM_BITS_IN_BYTE       8
+
 /**
  * wlan_hdd_cfg80211_set_feature() - Set the bitmask for supported features
  * @feature_flags: pointer to the byte array of features.
@@ -4505,7 +4506,6 @@ wlan_hdd_cfg80211_set_scanning_mac_oui(struct wiphy *wiphy,
  *
  * This is called to turn ON or SET the feature flag for the requested feature.
  **/
-#define NUM_BITS_IN_BYTE       8
 static void wlan_hdd_cfg80211_set_feature(uint8_t *feature_flags,
 					  uint8_t feature)
 {
@@ -4535,6 +4535,9 @@ static inline void wlan_hdd_set_ndi_feature(uint8_t *feature_flags)
 }
 #endif
 
+#define MAX_CONCURRENT_CHAN_ON_24G    2
+#define MAX_CONCURRENT_CHAN_ON_5G     2
+
 /**
  * __wlan_hdd_cfg80211_get_features() - Get the Driver Supported features
  * @wiphy: pointer to wireless wiphy structure.
@@ -4547,8 +4550,6 @@ static inline void wlan_hdd_set_ndi_feature(uint8_t *feature_flags)
  *
  * Return: Return the Success or Failure code.
  **/
-#define MAX_CONCURRENT_CHAN_ON_24G    2
-#define MAX_CONCURRENT_CHAN_ON_5G     2
 static int
 __wlan_hdd_cfg80211_get_features(struct wiphy *wiphy,
 				 struct wireless_dev *wdev,
@@ -5253,7 +5254,7 @@ hdd_send_roam_full_scan_period_to_sme(struct hdd_context *hdd_ctx,
 }
 
 /**
- * wlan_hdd_convert_control_roam_trigger_reason_bitmap  - Convert the
+ * wlan_hdd_convert_control_roam_trigger_bitmap  - Convert the
  * vendor specific reason code to internal reason code.
  * @trigger_reason_bitmap: Vendor specific roam trigger bitmap
  *
@@ -5595,7 +5596,8 @@ defined(FEATURE_RX_LINKSPEED_ROAM_TRIGGER)
 /**
  * hdd_set_roam_rx_linkspeed_threshold() - Set rx link speed threshold
  * @psoc: Pointer to psoc
- * @vdev_id: vdev id
+ * @vdev: vdev
+ * @linkspeed_threshold: threshold value to set
  *
  * Return: none
  */
@@ -6164,7 +6166,7 @@ out:
 
 /**
  * hdd_send_roam_control_config() - Send the roam config as vendor cmd reply
- * @mac_handle: Opaque handle to the MAC context
+ * @hdd_ctx: HDD context
  * @vdev_id: vdev id
  * @tb: List of attributes
  *
@@ -6254,10 +6256,11 @@ static int hdd_get_roam_control_config(struct hdd_context *hdd_ctx,
 
 /**
  * hdd_set_ext_roam_params() - parse ext roam params
- * @hdd_ctx:        HDD context
- * @tb:            list of attributes
- * @vdev_id:       vdev id
- * @rso_config:    roam params
+ * @hdd_ctx: HDD context
+ * @data: ext roam params attribute payload
+ * @data_len: length of @data
+ * @vdev_id: vdev id
+ * @rso_config: roam params
  *
  * Return: 0 on success; error number on failure
  */
@@ -6526,9 +6529,10 @@ const struct nla_policy wlan_hdd_set_ratemask_param_policy[
 
 /**
  * hdd_set_ratemask_params() - parse ratemask params
- * @hdd_ctx:        HDD context
- * @tb:            list of attributes
- * @vdev_id:       vdev id
+ * @hdd_ctx: HDD context
+ * @data: ratemask attribute payload
+ * @data_len: length of @data
+ * @vdev: vdev to modify
  *
  * Return: 0 on success; error number on failure
  */
@@ -10258,7 +10262,7 @@ hdd_convert_dbam_comp_status(enum coex_dbam_comp_status dbam_resp)
 /**
  * hdd_dbam_config_resp_cb() - DBAM config response callback
  * @context: request manager context
- * @fw_resp: pointer to dbam config fw response
+ * @resp: pointer to dbam config fw response
  *
  * Return: 0 on success, negative errno on failure
  */
@@ -11022,6 +11026,7 @@ typedef int (*config_getter_fn)(struct hdd_adapter *adapter,
 /**
  * struct config_getters
  * @id: vendor attribute which this entry handles
+ * @max_attr_len: Maximum length of the attribute
  * @cb: callback function to invoke to process the attribute when present
  */
 struct config_getters {
@@ -14968,7 +14973,7 @@ err:
 }
 
 /**
- * wlan_hdd_cfg80211_radio_combination_matrix() - get radio matrix info
+ * wlan_hdd_cfg80211_get_radio_combination_matrix() - get radio matrix info
  * @wiphy:   pointer to wireless wiphy structure.
  * @wdev:    pointer to wireless_dev structure.
  * @data:    Pointer to the data to be passed via vendor interface
@@ -15066,6 +15071,7 @@ static int __wlan_hdd_cfg80211_setband(struct wiphy *wiphy,
  *wlan_hdd_validate_acs_channel() - validate channel frequency provided by ACS
  * @adapter: hdd adapter
  * @chan_freq: channel frequency in MHz
+ * @chan_bw: channel bandiodth in MHz
  *
  * return: QDF status based on success or failure
  */
@@ -15218,7 +15224,7 @@ static int hdd_update_acs_channel(struct hdd_adapter *adapter, uint8_t reason,
 	return qdf_status_to_os_return(status);
 }
 
-/**
+/*
  * Define short name for vendor channel set config
  */
 #define SET_CHAN_REASON QCA_WLAN_VENDOR_ATTR_EXTERNAL_ACS_CHANNEL_REASON
@@ -15479,7 +15485,7 @@ hdd_extract_external_acs_channels(struct hdd_context *hdd_ctx,
 /**
  * hdd_parse_vendor_acs_chan_config() - API to parse vendor acs channel config
  * @hdd_ctx: pointer to hdd context
- * @channel_list: pointer to hdd_vendor_chan_info
+ * @chan_list_ptr: pointer to hdd_vendor_chan_info
  * @reason: channel change reason
  * @channel_cnt: channel count
  * @data: data
@@ -15531,7 +15537,7 @@ hdd_parse_vendor_acs_chan_config(struct hdd_context *hdd_ctx,
 	return ret;
 }
 
-/**
+/*
  * Undef short names for vendor set channel configuration
  */
 #undef SET_CHAN_REASON
@@ -16775,8 +16781,9 @@ hdd_get_usable_channel_len(uint32_t count)
 
 /**
  * hdd_send_usable_channel() - Send usable channels as vendor cmd reply
- * @mac_handle: Opaque handle to the MAC context
- * @vdev_id: vdev id
+ * @hdd_ctx: Pointer to hdd context
+ * @res_msg: pointer to usable channel information
+ * @count: number of channels
  * @tb: List of attributes
  *
  * Parse the attributes list tb and  get the data corresponding to the
@@ -17726,7 +17733,7 @@ static uint32_t get_radar_history_evt_len(uint32_t count)
 }
 
 /**
- * __wlan_hdd_cfg80211_radar_history () - Get radar history
+ * __wlan_hdd_cfg80211_get_radar_history () - Get radar history
  * @wiphy: Pointer to wireless phy
  * @wdev: Pointer to wireless device
  * @data: Pointer to data
@@ -19047,10 +19054,10 @@ void wlan_hdd_cfg80211_deinit(struct wiphy *wiphy)
 }
 
 /**
- * wlan_hdd_update_band_cap() - update capabilities for supported bands
+ * wlan_hdd_update_ht_cap() - update HT capabilities for supported bands
  * @hdd_ctx: HDD context
  *
- * this function will update capabilities for supported bands
+ * this function will update HT capabilities for supported bands
  *
  * Return: void
  */
@@ -19371,10 +19378,10 @@ void wlan_hdd_update_wiphy(struct hdd_context *hdd_ctx)
 }
 
 /**
- * wlan_hdd_update_11n_mode - update 11n mode in hdd cfg
- * @cfg: hdd cfg
+ * wlan_hdd_update_11n_mode - update 11n mode
+ * @hdd_ctx: hdd ccontext
  *
- * this function update 11n mode in hdd cfg
+ * this function updated 11n mode in hdd cfg and UMAC
  *
  * Return: void
  */
@@ -19867,7 +19874,7 @@ static bool hdd_is_ap_mode(enum QDF_OPMODE mode)
 /**
  * hdd_adapter_update_mac_on_mode_change() - Update mac address on mode change
  * @adapter: HDD adapter
- * get_new_addr: Get new address or release existing address
+ * @get_new_addr: Get new address or release existing address
  *
  * If @get_new_addr is false, the function will release the MAC address
  * in the adapter's mac_addr member and copy the MLD address into it.
@@ -21273,8 +21280,8 @@ static int wlan_hdd_cfg80211_get_key(struct wiphy *wiphy,
  * @wiphy: wiphy interface context
  * @ndev: pointer to net device
  * @key_index: Key index used in 802.11 frames
- * @unicast: true if it is unicast key
- * @multicast: true if it is multicast key
+ * @pairwise: true if it is pairwise key
+ * @mac_addr: Peer address
  *
  * This function is required for cfg80211_ops API.
  * It is used to delete the key information
@@ -21769,7 +21776,7 @@ void hdd_select_cbmode(struct hdd_adapter *adapter, qdf_freq_t oper_freq,
 /**
  * wlan_hdd_cfg80211_connect() - cfg80211 connect api
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to network device
+ * @ndev: Pointer to network device
  * @req: Pointer to cfg80211 connect request
  *
  * Return: 0 for success, non-zero for failure
@@ -21924,7 +21931,7 @@ static int wlan_hdd_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
  * __wlan_hdd_set_default_mgmt_key() - dummy implementation of set default mgmt
  *				     key
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to network device
+ * @netdev: Pointer to network device
  * @key_index: Key index
  *
  * Return: 0
@@ -22008,13 +22015,13 @@ static int wlan_hdd_set_default_mgmt_key(struct wiphy *wiphy,
 }
 #endif
 
-/**
+/*
  * Default val of cwmin, this value is used to override the
  * incorrect user set value
  */
 #define DEFAULT_CWMIN 15
 
-/**
+/*
  * Default val of cwmax, this value is used to override the
  * incorrect user set value
  */
@@ -22076,7 +22083,7 @@ static int __wlan_hdd_set_txq_params(struct wiphy *wiphy,
 /**
  * wlan_hdd_set_txq_params() - SSR wrapper for wlan_hdd_set_txq_params
  * @wiphy: pointer to wiphy
- * @netdev: pointer to net_device structure
+ * @dev: pointer to net_device structure
  * @params: pointer to ieee80211_txq_params
  *
  * Return: 0 on success, error number on failure
@@ -22101,9 +22108,8 @@ static int wlan_hdd_set_txq_params(struct wiphy *wiphy,
 
 /**
  * hdd_softap_deauth_current_sta() - Deauth current sta
- * @sta_info: pointer to the current station info structure
  * @adapter: pointer to adapter structure
- * @hdd_ctx: pointer to hdd context
+ * @sta_info: pointer to the current station info structure
  * @hapd_state: pointer to hostapd state structure
  * @param: pointer to del sta params
  *
@@ -22356,7 +22362,7 @@ int wlan_hdd_del_station(struct hdd_adapter *adapter, const uint8_t *mac)
 #endif
 
 /**
- * wlan_hdd_cfg80211_del_station() - delete station entry handler
+ * _wlan_hdd_cfg80211_del_station() - delete station entry handler
  * @wiphy: Pointer to wiphy
  * @dev: net_device to operate against
  * @mac: binary mac address
@@ -22423,8 +22429,9 @@ int wlan_hdd_cfg80211_del_station(struct wiphy *wiphy, struct net_device *dev,
 /**
  * __wlan_hdd_cfg80211_add_station() - add station
  * @wiphy: Pointer to wiphy
+ * @dev: Pointer to network device
  * @mac: Pointer to station mac address
- * @pmksa: Pointer to add station parameter
+ * @params: Pointer to add station parameter
  *
  * Return: 0 for success, non-zero for failure
  */
@@ -22485,8 +22492,9 @@ static int __wlan_hdd_cfg80211_add_station(struct wiphy *wiphy,
 /**
  * wlan_hdd_cfg80211_add_station() - add station
  * @wiphy: Pointer to wiphy
+ * @dev: Pointer to network device
  * @mac: Pointer to station mac address
- * @pmksa: Pointer to add station parameter
+ * @params: Pointer to add station parameter
  *
  * Return: 0 for success, non-zero for failure
  */
@@ -23154,7 +23162,7 @@ __wlan_hdd_cfg80211_update_owe_info(struct wiphy *wiphy,
 /**
  * wlan_hdd_cfg80211_update_owe_info() - update OWE info
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to network device
+ * @net_dev: Pointer to network device
  * @owe_info: Pointer to OWE info
  *
  * Return: 0 for success, non-zero for failure
@@ -23366,7 +23374,7 @@ int wlan_hdd_cfg80211_set_rekey_data(struct wiphy *wiphy,
  * __wlan_hdd_cfg80211_set_mac_acl() - set access control policy
  * @wiphy: Pointer to wiphy
  * @dev: Pointer to network device
- * @param: Pointer to access control parameter
+ * @params: Pointer to access control parameter
  *
  * Return: 0 for success, non-zero for failure
  */
@@ -23513,7 +23521,7 @@ wlan_hdd_cfg80211_set_mac_acl(struct wiphy *wiphy,
 /**
  * wlan_hdd_cfg80211_lphb_ind_handler() - handle low power heart beat indication
  * @hdd_ctx: Pointer to hdd context
- * @lphbInd: Pointer to low power heart beat indication parameter
+ * @lphb_ind: Pointer to low power heart beat indication parameter
  *
  * Return: none
  */
@@ -23684,7 +23692,7 @@ static int __wlan_hdd_cfg80211_testmode(struct wiphy *wiphy,
 /**
  * wlan_hdd_cfg80211_testmode() - test mode
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to network device
+ * @wdev: Pointer to wireless device
  * @data: Data pointer
  * @len: Data length
  *
@@ -23944,7 +23952,7 @@ int wlan_hdd_change_hw_mode_for_given_chnl(struct hdd_adapter *adapter,
 
 #ifdef FEATURE_MONITOR_MODE_SUPPORT
 /**
- * wlan_hdd_cfg80211_set_mon_ch() - Set monitor mode capture channel
+ * __wlan_hdd_cfg80211_set_mon_ch() - Set monitor mode capture channel
  * @wiphy: Handle to struct wiphy to get handle to module context.
  * @chandef: Contains information about the capture channel to be set.
  *
@@ -24598,7 +24606,7 @@ static int wlan_hdd_cfg80211_nan_change_conf(struct wiphy *wiphy,
 
 /**
  * wlan_hdd_chan_info_cb() - channel info callback
- * @chan_info: struct scan_chan_info
+ * @info: struct scan_chan_info
  *
  * Store channel info into HDD context
  *
@@ -25112,6 +25120,7 @@ static int __wlan_hdd_cfg80211_get_channel(struct wiphy *wiphy,
  * wlan_hdd_cfg80211_get_channel() - API to process cfg80211 get_channel request
  * @wiphy: Pointer to wiphy
  * @wdev: Pointer to wireless device
+ * @link_id: Channel link ID
  * @chandef: Pointer to channel definition
  *
  * Return: 0 for success, non zero for failure
@@ -25505,59 +25514,6 @@ wlan_hdd_cfg80211_del_intf_link(struct wiphy *wiphy, struct wireless_dev *wdev,
 }
 #endif
 
-/**
- * struct cfg80211_ops - cfg80211_ops
- *
- * @add_virtual_intf: Add virtual interface
- * @del_virtual_intf: Delete virtual interface
- * @change_virtual_intf: Change virtual interface
- * @change_station: Change station
- * @add_beacon: Add beacon in sap mode
- * @del_beacon: Delete beacon in sap mode
- * @set_beacon: Set beacon in sap mode
- * @start_ap: Start ap
- * @change_beacon: Change beacon
- * @stop_ap: Stop ap
- * @change_bss: Change bss
- * @add_key: Add key
- * @get_key: Get key
- * @del_key: Delete key
- * @set_default_key: Set default key
- * @set_channel: Set channel
- * @scan: Scan
- * @connect: Connect
- * @disconnect: Disconnect
- * @set_wiphy_params = Set wiphy params
- * @set_tx_power = Set tx power
- * @get_tx_power = get tx power
- * @remain_on_channel = Remain on channel
- * @cancel_remain_on_channel = Cancel remain on channel
- * @mgmt_tx = Tx management frame
- * @mgmt_tx_cancel_wait = Cancel management tx wait
- * @set_default_mgmt_key = Set default management key
- * @set_txq_params = Set tx queue parameters
- * @get_station = Get station
- * @set_power_mgmt = Set power management
- * @del_station = Delete station
- * @add_station = Add station
- * @set_pmksa = Set pmksa
- * @del_pmksa = Delete pmksa
- * @flush_pmksa = Flush pmksa
- * @update_ft_ies = Update FT IEs
- * @tdls_mgmt = Tdls management
- * @tdls_oper = Tdls operation
- * @set_rekey_data = Set rekey data
- * @sched_scan_start = Scheduled scan start
- * @sched_scan_stop = Scheduled scan stop
- * @resume = Resume wlan
- * @suspend = Suspend wlan
- * @set_mac_acl = Set mac acl
- * @testmode_cmd = Test mode command
- * @set_ap_chanwidth = Set AP channel bandwidth
- * @dump_survey = Dump survey
- * @key_mgmt_set_pmk = Set pmk key management
- * @update_connect_params = Update connect params
- */
 static struct cfg80211_ops wlan_hdd_cfg80211_ops = {
 	.add_virtual_intf = wlan_hdd_add_virtual_intf,
 	.del_virtual_intf = wlan_hdd_del_virtual_intf,

+ 5 - 5
core/hdd/src/wlan_hdd_cfg80211.h

@@ -209,11 +209,11 @@ extern const struct nla_policy wlan_hdd_wisa_cmd_policy[
 #endif
 
 /**
- * enum eDFS_CAC_STATUS: CAC status
+ * typedef eDFS_CAC_STATUS - CAC status
  *
  * @DFS_CAC_NEVER_DONE: CAC never done
  * @DFS_CAC_IN_PROGRESS: CAC is in progress
- * @DFS_CAC_IN_PROGRESS: CAC already done
+ * @DFS_CAC_ALREADY_DONE: CAC already done
  */
 typedef enum {
 	DFS_CAC_NEVER_DONE,
@@ -590,7 +590,7 @@ int wlan_hdd_change_hw_mode_for_given_chnl(struct hdd_adapter *adapter,
 					   enum policy_mgr_conn_update_reason reason);
 
 /**
- * hdd_rate_info_bw: an HDD internal rate bandwidth representation
+ * enum hdd_rate_info_bw: an HDD internal rate bandwidth representation
  * @HDD_RATE_BW_5: 5MHz
  * @HDD_RATE_BW_10: 10MHz
  * @HDD_RATE_BW_20: 20MHz
@@ -610,7 +610,7 @@ enum hdd_rate_info_bw {
 };
 
 /**
- * hdd_chain_mode : Representation of Number of chains available.
+ * enum hdd_chain_mode : Representation of Number of chains available.
  * @HDD_CHAIN_MODE_1X1: Chain mask Not Configurable as only one chain available
  * @HDD_CHAIN_MODE_2X2: Chain mask configurable as both chains available
  */
@@ -620,7 +620,7 @@ enum hdd_chain_mode {
 };
 
 /**
- * hdd_ba_mode: Representation of Number to configure BA mode
+ * enum hdd_ba_mode: Representation of Number to configure BA mode
  * @HDD_BA_MODE_AUTO: Auto mode
  * @HDD_BA_MODE_MANUAL: Manual mode
  * @HDD_BA_MODE_64: For buffer size 64

+ 3 - 3
core/hdd/src/wlan_hdd_cm_api.h

@@ -32,7 +32,7 @@
 /**
  * wlan_hdd_cm_connect() - cfg80211 connect api
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to network device
+ * @ndev: Pointer to network device
  * @req: Pointer to cfg80211 connect request
  *
  * This function is used to issue connect request to connection manager
@@ -105,7 +105,7 @@ QDF_STATUS hdd_cm_send_vdev_keys(struct wlan_objmgr_vdev *vdev,
 /**
  * hdd_cm_get_vendor_handoff_params() - to get vendor handoff params from fw
  * @psoc: Pointer to psoc object
- * @event_data: Pointer to vendor handoff event rsp
+ * @vendor_handoff_context: Pointer to vendor handoff event rsp
  *
  * Return: QDF_STATUS
  */
@@ -115,7 +115,7 @@ hdd_cm_get_vendor_handoff_params(struct wlan_objmgr_psoc *psoc,
 
 /**
  * hdd_cm_get_handoff_param() - send get vendor handoff param request to fw
- * @pdev: pdev common object
+ * @psoc: psoc common object
  * @hdd_adapter: adapter context
  * @vdev_id: vdev id
  * @param_id: Param ID from enum WMI_ROAM_GET_VENDOR_CONTROL_PARAM_ID

+ 1 - 0
core/hdd/src/wlan_hdd_connectivity_logging.c

@@ -1221,6 +1221,7 @@ wlan_hdd_fill_connectivity_logging_data(struct sk_buff *skb,
  * wlan_hdd_send_connectivity_log_to_user  - Send the connectivity log buffer
  * to userspace
  * @rec: Pointer to the log record
+ * @hdd_context: HDD global context
  * @num_records: Number of records
  *
  * Return: QDF_STATUS

+ 3 - 2
core/hdd/src/wlan_hdd_data_stall_detection.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -61,7 +62,7 @@ static inline void hdd_data_stall_send_event(uint32_t reason)
 
 /**
  * hdd_data_stall_process_event() - Process data stall event
- * @message: data stall message
+ * @msg: data stall message
  *
  * Process data stall message
  *
@@ -83,7 +84,7 @@ static QDF_STATUS hdd_data_stall_process_event(struct scheduler_msg *msg)
 
 /**
  * hdd_data_stall_process_cb() - Process data stall message
- * @message: data stall message
+ * @info: data stall message
  *
  * Process data stall message
  *

+ 2 - 1
core/hdd/src/wlan_hdd_debugfs.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -214,7 +215,7 @@ static ssize_t wcnss_wowpattern_write(struct file *file,
 }
 
 /**
- * wcnss_patterngen_write() - pattern_gen debugfs handler
+ * __wcnss_patterngen_write() - pattern_gen debugfs handler
  * @net_dev: net_device context used to register the debugfs file
  * @buf: text being written to the debugfs
  * @count: size of @buf

+ 3 - 3
core/hdd/src/wlan_hdd_debugfs_roam.c

@@ -214,10 +214,10 @@ static char *hdd_roam_scan_trigger_to_str(uint32_t roam_scan_trigger)
 }
 
 /**
- * hdd_roam_scan_trigger_value_to_str() - Get trigger value string for
+ * hdd_roam_scan_trigger_value() - Get trigger value string for
  * enum WMI_ROAM_TRIGGER_REASON_ID
  * @roam_scan_trigger: roam scan trigger ID
- * @bool: output pointer to hold whether to print trigger value
+ * @print: output pointer to hold whether to print trigger value
  *
  * Return: Meaningful string from trigger value
  */
@@ -372,7 +372,7 @@ hdd_roam_scan_chan(struct wmi_roam_scan_stats_params *scan,
  * @hdd_ctx: hdd context
  * @adapter: pointer to adapter
  * @buf: buffer to hold the stats
- * @len: maximum available length in response buffer
+ * @buf_avail_len: maximum available length in response buffer
  *
  * Return: Size of formatted roam scan response stats
  */

+ 2 - 1
core/hdd/src/wlan_hdd_debugfs_unit_test.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -39,7 +40,7 @@
  * __wlan_hdd_write_unit_test_host_debugfs()
  *    - host unit test debugfs handler
  *
- * @net_dev: net_device context used to register the debugfs file
+ * @hdd_ctx: HDD context used to register the debugfs file
  * @buf: text being written to the debugfs
  * @count: size of @buf
  * @ppos: (unused) offset into the virtual file system

+ 6 - 5
core/hdd/src/wlan_hdd_disa.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_disa.c
+ * DOC: wlan_hdd_disa.c
  *
  * WLAN Host Device Driver file for DISA certification
  *
@@ -35,7 +35,7 @@
 
 
 /**
- * hdd_encrypt_decrypt_msg_context - hdd encrypt/decrypt message context
+ * struct hdd_encrypt_decrypt_msg_context - hdd encrypt/decrypt message context
  * @status: status of response. 0: no error, -ENOMEM: unable to allocate
  *   memory for the response payload
  * @request: encrypt/decrypt request
@@ -109,7 +109,8 @@ static void hdd_encrypt_decrypt_msg_cb(void *cookie,
 
 /**
  * hdd_post_encrypt_decrypt_msg_rsp () - send encrypt/decrypt data to user space
- * @encrypt_decrypt_rsp_params: encrypt/decrypt response parameters
+ * @hdd_ctx: HDD context
+ * @resp: encrypt/decrypt response parameters
  *
  * Return: none
  */
@@ -164,7 +165,7 @@ encrypt_decrypt_policy[QCA_WLAN_VENDOR_ATTR_ENCRYPTION_TEST_MAX + 1] = {
  * @data: Pointer to data
  * @data_len: Data length
  *
- Return: 0 on success, negative errno on failure
+ * Return: 0 on success, negative errno on failure
  */
 static int
 hdd_fill_encrypt_decrypt_params(struct disa_encrypt_decrypt_req_params
@@ -350,7 +351,7 @@ static void hdd_encrypt_decrypt_context_dealloc(void *priv)
  * @data: Pointer to data
  * @data_len: Data length
  *
- Return: 0 on success, negative errno on failure
+ * Return: 0 on success, negative errno on failure
  */
 static int hdd_encrypt_decrypt_msg(struct hdd_adapter *adapter,
 				   struct hdd_context *hdd_ctx,

+ 1 - 1
core/hdd/src/wlan_hdd_eht.c

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_eht.c
+ * DOC: wlan_hdd_eht.c
  *
  * WLAN Host Device Driver file for 802.11be (Extremely High Throughput)
  * support.

+ 2 - 2
core/hdd/src/wlan_hdd_ext_scan.c

@@ -1135,7 +1135,7 @@ fail:
 
 /**
  * wlan_hdd_cfg80211_passpoint_match_found() - passpoint match found
- * @hddctx: HDD context
+ * @ctx: HDD context
  * @data: matched network data
  *
  * This function reads the match network %data and fill in the skb with
@@ -1255,7 +1255,7 @@ fail:
 /**
  * wlan_hdd_cfg80211_extscan_generic_rsp() -
  *	Handle a generic ExtScan Response message
- * @ctx: HDD context registered with SME
+ * @hdd_ctx: HDD context registered with SME
  * @response: The ExtScan response from firmware
  *
  * This function will handle a generic ExtScan response message from

+ 2 - 1
core/hdd/src/wlan_hdd_fips.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -32,7 +33,7 @@
 #define WLAN_WAIT_TIME_FIPS 5000
 
 /**
- * hdd_fips_context - hdd fips context
+ * struct hdd_fips_context - hdd fips context
  * @status: status of response. 0: no error, -ENOMEM: unable to allocate
  *   memory for the response payload
  * @request: fips request

+ 2 - 1
core/hdd/src/wlan_hdd_fw_state.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -182,7 +183,7 @@ static int __wlan_hdd_cfg80211_get_fw_state(struct wiphy *wiphy,
 }
 
 /**
- * wlan_hdd_cfg80211_get_fw_status() - get fw state
+ * wlan_hdd_cfg80211_get_fw_state() - get fw state
  * @wiphy: wiphy pointer
  * @wdev: pointer to struct wireless_dev
  * @data: pointer to incoming NL vendor data

+ 3 - 2
core/hdd/src/wlan_hdd_gpio.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -31,13 +32,13 @@
 #include <wlan_hdd_gpio.h>
 
 /**
- * wlan_cfg80211_set_gpio_config - Set the gpio configuration
+ * __wlan_hdd_cfg80211_set_gpio_config() - Set the gpio configuration
  * @wiphy: pointer to wiphy
  * @wdev: pointer to wireless_wdev
  * @data: pointer to data
  * @data_len: data length
  *
- * __wlan_cfg80211_set_gpio_config will forward the GPIO setting to FW by
+ * __wlan_hdd_cfg80211_set_gpio_config will forward the GPIO setting to FW by
  * WMI_GPIO_CONFIG/OUTPUT_CMDID
  *
  * Return: 0 on success; errno on failure

+ 1 - 1
core/hdd/src/wlan_hdd_he.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_he.c
+ * DOC: wlan_hdd_he.c
  *
  * WLAN Host Device Driver file for 802.11ax (High Efficiency) support.
  *

+ 7 - 6
core/hdd/src/wlan_hdd_hostapd.h

@@ -78,9 +78,8 @@ int hdd_softap_set_channel_change(struct net_device *dev,
 /**
  * hdd_stop_sap_set_tx_power() - Function to set tx power
  * for unsafe channel if restriction bit mask is set else stop the SAP.
- *
  * @psoc: PSOC object information
- * @vdev_id: vdev id
+ * @adapter: AP/SAP adapter
  *
  * This function set tx power/stop the SAP interface
  *
@@ -93,7 +92,7 @@ void hdd_stop_sap_set_tx_power(struct wlan_objmgr_psoc *psoc,
 #ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
 /**
  * hdd_sap_restart_with_channel_switch() - SAP channel change with E/CSA
- * @wlan_objmgr_psoc: psoc common object
+ * @psoc: psoc common object
  * @ap_adapter: HDD adapter
  * @target_chan_freq: Channel frequency to which switch must happen
  * @target_bw: Bandwidth of the target channel
@@ -115,6 +114,7 @@ QDF_STATUS hdd_sap_restart_with_channel_switch(struct wlan_objmgr_psoc *psoc,
  * @psoc: PSOC object information
  * @vdev_id: vdev id
  * @ch_freq: channel to switch
+ * @channel_bw: channel bandwidth
  * @forced: Force to switch channel, ignore SCC/MCC check
  *
  * This function restarts SAP with a different channel
@@ -241,13 +241,14 @@ QDF_STATUS hdd_hostapd_sap_event_cb(struct sap_event *sap_event,
 /**
  * hdd_init_ap_mode() - to init the AP adaptor
  * @adapter: SAP/GO adapter
- * @rtnl_held: flag to indicate if RTNL lock needs to be acquired
+ * @reinit: true if re-init, otherwise initial init
  *
  * This API can be called to open the SAP session as well as
  * to create and store the vdev object. It also initializes necessary
  * SAP adapter related params.
  */
 QDF_STATUS hdd_init_ap_mode(struct hdd_adapter *adapter, bool reinit);
+
 /**
  * hdd_deinit_ap_mode() - to deinit the AP adaptor
  * @hdd_ctx: pointer to hdd_ctx
@@ -283,7 +284,7 @@ bool hdd_sap_create_ctx(struct hdd_adapter *adapter);
 bool hdd_sap_destroy_ctx(struct hdd_adapter *adapter);
 /**
  * hdd_sap_destroy_ctx_all() - Wrapper API to destroy all SAP context
- * @adapter: pointer to adapter
+ * @hdd_ctx: pointer to HDD context
  * @is_ssr: true if SSR is in progress
  *
  * This wrapper API can be called to destroy all the sap context.
@@ -384,7 +385,7 @@ void hdd_sap_indicate_disconnect_for_sta(struct hdd_adapter *adapter);
  * hdd_handle_acs_2g_preferred_sap_conc() - Handle 2G pereferred SAP
  * concurrency with GO
  * @psoc: soc object
- * @sap_ctx: sap context
+ * @adapter: HDD adapter context
  * @sap_config: sap config
  *
  * In SAP+GO concurrency, if GO is started on 2G and SAP is

+ 23 - 5
core/hdd/src/wlan_hdd_hostapd_wext.c

@@ -130,7 +130,7 @@ static iw_softap_get_ini_cfg(struct net_device *dev,
 }
 
 /**
- * iw_softap_set_two_ints_getnone() - Generic "set two integer" ioctl handler
+ * __iw_softap_set_two_ints_getnone() - Generic "set two integer" ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -257,6 +257,15 @@ static int __iw_softap_set_two_ints_getnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_softap_set_two_ints_getnone() - Generic "set two integer" ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_softap_set_two_ints_getnone(struct net_device *dev,
 					  struct iw_request_info *info,
 					  union iwreq_data *wrqu, char *extra)
@@ -1868,7 +1877,7 @@ static iw_softap_disassoc_sta(struct net_device *dev,
 }
 
 /**
- * iw_get_char_setnone() - Generic "get char" private ioctl handler
+ * __iw_get_char_setnone() - Generic "get char" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -1911,6 +1920,15 @@ static int __iw_get_char_setnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_get_char_setnone() - Generic "get char" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_get_char_setnone(struct net_device *dev,
 				struct iw_request_info *info,
 				union iwreq_data *wrqu, char *extra)
@@ -2583,7 +2601,7 @@ iw_get_softap_linkspeed(struct net_device *dev,
  * @dev: net device
  * @info: iwpriv request information
  * @wrqu: iwpriv command parameter
- * @extra
+ * @extra: extra data pointer
  *
  * This function will call wlan_cfg80211_mc_cp_stats_get_peer_rssi
  * to get rssi
@@ -2664,7 +2682,7 @@ __iw_get_peer_rssi(struct net_device *dev, struct iw_request_info *info,
  * @dev: net device
  * @info: iwpriv request information
  * @wrqu: iwpriv command parameter
- * @extra
+ * @extra: extra data pointer
  *
  * This function will call __iw_get_peer_rssi
  *
@@ -3294,7 +3312,7 @@ const struct iw_handler_def hostapd_handler_def = {
 };
 
 /**
- * hdd_register_wext() - register wext context
+ * hdd_register_hostapd_wext() - register hostapd wext context
  * @dev: net device handle
  *
  * Registers wext interface context for a given net device

+ 10 - 9
core/hdd/src/wlan_hdd_ioctl.c

@@ -308,9 +308,9 @@ static bool hdd_check_and_fill_freq(uint32_t in_chan, qdf_freq_t *freq,
 
 /**
  * _hdd_parse_bssid_and_chan() - helper function to parse bssid and channel
- * @data:            input data
- * @target_ap_bssid: pointer to bssid (output parameter)
- * @freq:         pointer to freq (output parameter)
+ * @data: input data
+ * @bssid: pointer to bssid (output parameter)
+ * @freq: pointer to freq (output parameter)
  * @pdev: pdev object
  *
  * Return: 0 if parsing is successful; -EINVAL otherwise
@@ -403,8 +403,8 @@ error:
 /**
  * hdd_parse_send_action_frame_v1_data() - HDD Parse send action frame data
  * @command: Pointer to input data
- * @bssid: Pointer to target Ap bssid
- * @channel: Pointer to the Target AP channel
+ * @bssid: Pointer to target AP BSSID
+ * @freq: Pointer to the Target AP channel frequency
  * @dwell_time: Pointer to the time to stay off-channel
  *              after transmitting action frame
  * @buf: Pointer to data
@@ -515,7 +515,7 @@ hdd_parse_send_action_frame_v1_data(const uint8_t *command,
 }
 
 /**
- * hdd_parse_reassoc_command_data() - HDD Parse reassoc command data
+ * hdd_parse_reassoc_command_v1_data() - HDD Parse reassoc command data
  * @command: Pointer to input data (its a NULL terminated string)
  * @bssid: Pointer to target Ap bssid
  * @freq: Pointer to the Target AP frequency
@@ -888,6 +888,7 @@ hdd_parse_sendactionframe_v1(struct hdd_adapter *adapter, const char *command)
  * @adapter:	Adapter upon which the command was received
  * @command:	Command that was received, ASCII command
  *		followed by binary data
+ * @total_len:  Length of @command
  *
  * This function parses the v2 SENDACTIONFRAME command with the format
  *
@@ -953,6 +954,7 @@ hdd_parse_sendactionframe_v2(struct hdd_adapter *adapter,
  * hdd_parse_sendactionframe() - parse the SENDACTIONFRAME command
  * @adapter:	Adapter upon which the command was received
  * @command:	Command that was received
+ * @total_len:  Length of @command
  *
  * There are two different versions of the SENDACTIONFRAME command.
  * Version 1 of the command contains a parameter list that is ASCII
@@ -2264,6 +2266,7 @@ static int wlan_hdd_get_link_status(struct hdd_adapter *adapter)
 #ifdef FEATURE_WLAN_ESE
 /**
  * hdd_parse_ese_beacon_req() - Parse ese beacon request
+ * @pdev: pdev object
  * @command: Pointer to data
  * @req:	Output pointer to store parsed ie information
  *
@@ -5589,13 +5592,11 @@ static int drv_cmd_rx_filter_add(struct hdd_adapter *adapter,
  * hdd_parse_setantennamode_command() - HDD Parse SETANTENNAMODE
  * command
  * @value: Pointer to SETANTENNAMODE command
- * @mode: Pointer to antenna mode
- * @reason: Pointer to reason for set antenna mode
  *
  * This function parses the SETANTENNAMODE command passed in the format
  * SETANTENNAMODE<space>mode
  *
- * Return: 0 for success non-zero for failure
+ * Return: parsed antenna mode
  */
 static int hdd_parse_setantennamode_command(const uint8_t *value)
 {

+ 2 - 2
core/hdd/src/wlan_hdd_ioctl.h

@@ -28,7 +28,7 @@ extern struct sock *cesium_nl_srv_sock;
 
 /**
  * hdd_ioctl() - ioctl handler (wrapper) for wlan network interfaces
- * @net_dev: device upon which the ioctl was received
+ * @dev: device upon which the ioctl was received
  * @ifr: ioctl request information
  * @cmd: ioctl command
  *
@@ -41,7 +41,7 @@ int hdd_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd);
 
 /**
  * hdd_dev_private_ioctl() - private ioctl handler for wlan network interfaces
- * @net_dev: device upon which the ioctl was received
+ * @dev: device upon which the ioctl was received
  * @ifr: ioctl request information
  * @data: pointer to the raw command data in the ioctl request
  * @cmd: ioctl command

+ 1 - 0
core/hdd/src/wlan_hdd_ipa.c

@@ -345,6 +345,7 @@ static uint32_t hdd_ipa_get_wake_up_idle(void)
 
 /**
  * hdd_ipa_set_wake_up_idle() - Set PF_WAKE_UP_IDLE flag in the task structure
+ * @wake_up_idle: Value to set PF_WAKE_UP_IDLE flag
  *
  * Set PF_WAKE_UP_IDLE flag in the task structure
  * This task and any task woken by this will be waken to idle CPU

+ 30 - 27
core/hdd/src/wlan_hdd_main.c

@@ -2769,7 +2769,7 @@ static void hdd_mon_turn_off_ps_and_wow(struct hdd_context *hdd_ctx)
 }
 
 /**
- * __hdd__mon_open() - HDD Open function
+ * __hdd_mon_open() - HDD Open function
  * @dev: Pointer to net_device structure
  *
  * This is called in response to ifconfig up
@@ -2846,7 +2846,7 @@ static int __hdd_mon_open(struct net_device *dev)
 
 /**
  * hdd_mon_open() - Wrapper function for __hdd_mon_open to protect it from SSR
- * @dev:	Pointer to net_device structure
+ * @net_dev: Pointer to net_device structure
  *
  * This is called in response to ifconfig up
  *
@@ -2922,7 +2922,7 @@ static int __hdd_pktcapture_open(struct net_device *dev)
 /**
  * hdd_pktcapture_open() - Wrapper function for hdd_pktcapture_open to
  * protect it from SSR
- * @dev:	Pointer to net_device structure
+ * @net_dev: Pointer to net_device structure
  *
  * This is called in response to ifconfig up
  *
@@ -4001,6 +4001,7 @@ static void hdd_wlan_unregister_pm_qos_notifier(struct hdd_context *hdd_ctx)
 
 /**
  * hdd_enable_power_management() - API to Enable Power Management
+ * @hdd_ctx: HDD context
  *
  * API invokes Bus Interface Layer power management functionality
  *
@@ -4019,6 +4020,7 @@ static void hdd_enable_power_management(struct hdd_context *hdd_ctx)
 
 /**
  * hdd_disable_power_management() - API to disable Power Management
+ * @hdd_ctx: HDD context
  *
  * API disable Bus Interface Layer Power management functionality
  *
@@ -4825,7 +4827,7 @@ reset_iface_opened:
 
 /**
  * hdd_stop() - Wrapper function for __hdd_stop to protect it from SSR
- * @dev: pointer to net_device structure
+ * @net_dev: pointer to net_device structure
  *
  * This is called in response to ifconfig down
  *
@@ -5526,7 +5528,6 @@ hdd_set_derived_multicast_list(struct wlan_objmgr_psoc *psoc,
 /**
  * __hdd_set_multicast_list() - set the multicast address list
  * @dev:	Pointer to the WLAN device.
- * @skb:	Pointer to OS packet (sk_buff).
  *
  * This function sets the multicast address list.
  *
@@ -5925,7 +5926,7 @@ static void hdd_set_pktcapture_ops(struct net_device *dev)
 /**
  * hdd_set_multi_client_ll_support() - set multi client ll support flag in
  * allocated station hdd adapter
- * @@adapter: pointer to hdd adapter
+ * @adapter: pointer to hdd adapter
  *
  * Return: none
  */
@@ -5955,6 +5956,7 @@ hdd_set_multi_client_ll_support(struct hdd_adapter *adapter)
  * hdd_alloc_station_adapter() - allocate the station hdd adapter
  * @hdd_ctx: global hdd context
  * @mac_addr: mac address to assign to the interface
+ * @name_assign_type: name assignment type
  * @name: User-visible name of the interface
  * @session_type: interface type to be created
  *
@@ -8476,7 +8478,7 @@ static void hdd_reset_scan_operation(struct hdd_context *hdd_ctx,
 #ifdef QCA_LL_LEGACY_TX_FLOW_CONTROL
 /**
  * hdd_adapter_abort_tx_flow() - Abort the tx flow control
- * @pAdapter: pointer to hdd_adapter_t
+ * @adapter: pointer to hdd adapter
  *
  * Resume tx and stop the tx flow control timer if the tx is paused
  * and the flow control timer is running. This function is called by
@@ -9848,9 +9850,8 @@ int hdd_wlan_notify_modem_power_state(int state)
 }
 
 /**
- *
  * hdd_post_cds_enable_config() - HDD post cds start config helper
- * @adapter - Pointer to the HDD
+ * @hdd_ctx: Pointer to the HDD
  *
  * Return: None
  */
@@ -10478,7 +10479,7 @@ bool wlan_hdd_sta_ndi_connected(hdd_cb_handle context, uint8_t vdev_id)
 }
 
 /**
- * hdd_pktlog_enable_disable() - Enable/Disable packet logging
+ * wlan_hdd_pktlog_enable_disable() - Enable/Disable packet logging
  * @context: HDD context
  * @enable_disable_flag: Flag to enable/disable
  * @user_triggered: triggered through iwpriv
@@ -10639,7 +10640,7 @@ static inline bool hdd_any_adapter_connected(hdd_cb_handle context)
 
 #ifdef WLAN_FEATURE_DP_BUS_BANDWIDTH
 /**
- * hdd_pld_remove_pm_qos() - Request PLD PM QoS request
+ * hdd_pld_request_pm_qos() - Request PLD PM QoS request
  * @context: HDD context
  *
  * Return: None
@@ -10660,7 +10661,7 @@ static inline void hdd_pld_request_pm_qos(hdd_cb_handle context)
 }
 
 /**
- * hdd_pld_request_pm_qos() - Remove PLD PM QoS request
+ * hdd_pld_remove_pm_qos() - Remove PLD PM QoS request
  * @context: HDD context
  *
  * Return: None
@@ -11076,7 +11077,6 @@ int hdd_wlan_clear_stats(struct hdd_adapter *adapter, int stats_id)
 #define ADAP_NETIFQ_LOG_LEN ((20 * WLAN_REASON_TYPE_MAX) + 50)
 
 /**
- *
  * hdd_display_netif_queue_history_compact() - display compact netifq history
  * @hdd_ctx: hdd context
  *
@@ -11257,6 +11257,7 @@ wlan_hdd_display_adapter_netif_queue_history(struct hdd_adapter *adapter)
 /**
  * wlan_hdd_display_netif_queue_history() - display netif queue history
  * @context: hdd context
+ * @verb_lvl: verbosity level
  *
  * Return: none
  */
@@ -11409,7 +11410,7 @@ static inline int wlan_hdd_set_wow_pulse(struct hdd_context *hdd_ctx, bool enabl
 
 /**
  * hdd_enable_fastpath() - Enable fastpath if enabled in config INI
- * @hdd_cfg: hdd config
+ * @hdd_ctx: hdd context
  * @context: lower layer context
  *
  * Return: none
@@ -11609,7 +11610,7 @@ hdd_store_sap_restart_channel(qdf_freq_t restart_chan, qdf_freq_t *restart_chan_
 
 /**
  * hdd_unsafe_channel_restart_sap() - restart sap if sap is on unsafe channel
- * @hdd_ctx: hdd context pointer
+ * @hdd_ctxt: hdd context pointer
  *
  * hdd_unsafe_channel_restart_sap check all unsafe channel list
  * and if ACS is enabled, driver will ask userspace to restart the
@@ -12197,7 +12198,7 @@ static uint32_t hdd_log_level_to_bitmask(enum host_log_level user_log_level)
 
 /**
  * hdd_set_trace_level_for_each - Set trace level for each INI config
- * @hdd_ctx - HDD context
+ * @hdd_ctx: HDD context
  *
  * Set trace level for each module based on INI config.
  *
@@ -12706,7 +12707,7 @@ static void hdd_init_cpu_cxpc_threshold_cfg(struct hdd_config *config,
 
 /**
  * hdd_cfg_params_init() - Initialize hdd params in hdd_config structure
- * @hdd_ctx - Pointer to HDD context
+ * @hdd_ctx: Pointer to HDD context
  *
  * Return: None
  */
@@ -13233,7 +13234,7 @@ static bool hdd_is_cfg_dot11_mode_11be(enum hdd_dot11_mode dot11_mode)
 }
 
 /**
- * hdd_is_host_11be_supported() - Check if 11 be is supported or not
+ * hdd_is_11be_supported() - Check if 11be is supported or not
  *
  * Return: True, if 11be is supported else return false
  */
@@ -13257,6 +13258,7 @@ static bool hdd_is_11be_supported(void)
 /**
  * hdd_get_wifi_standard() - Get wifi standard
  * @hdd_ctx: hdd context pointer
+ * @band_capability: band capability bitmap
  *
  * Return: WMI_HOST_WIFI_STANDARD
  */
@@ -14339,7 +14341,7 @@ static int hdd_set_auto_shutdown_cb(struct hdd_context *hdd_ctx)
 
 #ifdef MWS_COEX
 /**
- * hdd_set_mws_coex() - Set MWS coex configurations
+ * hdd_init_mws_coex() - Initialize MWS coex configurations
  * @hdd_ctx:   HDD context
  *
  * This function sends MWS-COEX 4G quick FTDM and
@@ -14571,7 +14573,7 @@ static int hdd_features_init(struct hdd_context *hdd_ctx)
 
 /**
  * hdd_register_bcn_cb() - register scan beacon callback
- * @hdd_ctx - Pointer to the HDD context
+ * @hdd_ctx: Pointer to the HDD context
  *
  * Return: QDF_STATUS
  */
@@ -14699,7 +14701,6 @@ static void hdd_hastings_bt_war_initialize(struct hdd_context *hdd_ctx)
 /**
  * hdd_configure_cds() - Configure cds modules
  * @hdd_ctx:	HDD context
- * @adapter:	Primary adapter context
  *
  * Enable Cds modules after WLAN firmware is up.
  *
@@ -15138,7 +15139,7 @@ done:
 #ifdef WLAN_FEATURE_MEMDUMP_ENABLE
 /**
  * hdd_state_info_dump() - prints state information of hdd layer
- * @buf: buffer pointer
+ * @buf_ptr: buffer pointer
  * @size: size of buffer to be filled
  *
  * This function is used to dump state information of hdd layer
@@ -16463,6 +16464,7 @@ static QDF_STATUS wlan_hdd_mlo_sap_reinit(struct hdd_context *hdd_ctx,
 /**
  * wlan_hdd_start_sap() - this function starts bss of SAP.
  * @ap_adapter: SAP adapter
+ * @reinit: true if this is a re-init, otherwise initial int
  *
  * This function will process the starting of sap adapter.
  *
@@ -17699,7 +17701,7 @@ static bool is_ftm_mode_supported(void)
 #endif
 
 /**
- * is_con_mode_valid() check con mode is valid or not
+ * is_con_mode_valid() - check con mode is valid or not
  * @mode: global con mode
  *
  * Return: TRUE on success FALSE on failure
@@ -18282,7 +18284,7 @@ EXPORT_SYMBOL(hdd_driver_unload);
  * wlan_boot_cb() - Wlan boot callback
  * @kobj:      object whose directory we're creating the link in.
  * @attr:      attribute the user is interacting with
- * @buff:      the buffer containing the user data
+ * @buf:       the buffer containing the user data
  * @count:     number of bytes in the buffer
  *
  * This callback is invoked when the fs is ready to start the
@@ -18881,7 +18883,7 @@ enum  sap_acs_dfs_mode wlan_hdd_get_dfs_mode(enum dfs_mode mode)
 
 /**
  * hdd_enable_disable_ca_event() - enable/disable channel avoidance event
- * @hddctx: pointer to hdd context
+ * @hdd_ctx: pointer to hdd context
  * @set_value: enable/disable
  *
  * When Host sends vendor command enable, FW will send *ONE* CA ind to
@@ -18945,6 +18947,7 @@ bool hdd_is_roaming_in_progress(struct hdd_context *hdd_ctx)
  * struct hdd_is_connection_in_progress_priv - adapter connection info
  * @out_vdev_id: id of vdev where connection is occurring
  * @out_reason: scan reject reason
+ * @connection_in_progress: true if connection is in progress
  */
 struct hdd_is_connection_in_progress_priv {
 	uint8_t out_vdev_id;
@@ -18956,7 +18959,7 @@ struct hdd_is_connection_in_progress_priv {
  * hdd_is_connection_in_progress_iterator() - Check adapter connection based
  * on device mode
  * @adapter: current adapter of interest
- * @context: user context supplied
+ * @ctx: user context supplied
  *
  * Check if connection is in progress for the current adapter according to the
  * device mode
@@ -19348,7 +19351,7 @@ int hdd_get_rssi_snr_by_bssid(struct hdd_adapter *adapter, const uint8_t *bssid,
 
 /**
  * hdd_reset_limit_off_chan() - reset limit off-channel command parameters
- * @adapter - HDD adapter
+ * @adapter: HDD adapter
  *
  * Return: 0 on success and non zero value on failure
  */

+ 3 - 2
core/hdd/src/wlan_hdd_main_module.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -15,9 +16,9 @@
  */
 
 /**
- * wlan_driver_resident: wlan_hdd_main_module.c
+ * DOC: wlan_hdd_main_module.c
  *
- * wlan_driver_resident: WLAN Host Device Driver module interface implementation
+ * WLAN Host Device Driver module interface implementation
  *
  */
 

+ 2 - 2
core/hdd/src/wlan_hdd_mcc_quota.h

@@ -38,8 +38,8 @@ extern const struct nla_policy
 set_mcc_quota_policy[QCA_WLAN_VENDOR_ATTR_MCC_QUOTA_MAX + 1];
 
 /**
- * wlan_hdd_set_mcc_adaptive_sched: Enable or disable MCC adaptive scheduling
- * @hdd_ctx: HDD context
+ * wlan_hdd_set_mcc_adaptive_sched() - Enable or disable MCC adaptive scheduling
+ * @psoc: psoc context
  * @enable: Enable (true) or disable (false)
  *
  * Return: 0 for success, Non zero failure code for errors

+ 2 - 2
core/hdd/src/wlan_hdd_medium_assess.c

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_medium_assess.c
+ * DOC: wlan_hdd_medium_assess.c
  *
  * WLAN Host Device Driver medium assess related implementation
  *
@@ -254,7 +254,7 @@ static int get_congestion_report_len(void)
 
 /**
  * hdd_congestion_reset_data() - reset/invalid the previous data
- * @vdev_id: vdev id
+ * @pdev_id: pdev id
  *
  * Return: None
  */

+ 3 - 2
core/hdd/src/wlan_hdd_medium_assess.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -15,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_medium_assess.h
+ * DOC: wlan_hdd_medium_assess.h
  *
  * WLAN Host Device Driver medium assess related implementation
  *
@@ -110,7 +111,7 @@ int hdd_cfg80211_medium_assess(struct wiphy *wiphy,
 void hdd_medium_assess_init(void);
 
 /**
- * hdd_cfg80211_medium_deinit() - medium assess deinit timer
+ * hdd_medium_assess_deinit() - medium assess deinit timer
  *
  * Return: none
  */

+ 10 - 17
core/hdd/src/wlan_hdd_memdump.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_memdump.c
+ * DOC: wlan_hdd_memdump.c
  *
  * WLAN Host Device Driver file for dumping firmware memory
  *
@@ -82,10 +82,10 @@ void hdd_driver_mem_cleanup(void)
 /**
  * __hdd_driver_memdump_read() - perform read operation in driver
  * memory dump proc file
- * @file  - handle for the proc file.
- * @buf   - pointer to user space buffer.
- * @count - number of bytes to be read.
- * @pos   - offset in the from buffer.
+ * @file:  handle for the proc file.
+ * @buf:   pointer to user space buffer.
+ * @count: number of bytes to be read.
+ * @pos:   offset in the from buffer.
  *
  * This function performs read operation for the driver memory dump proc file.
  *
@@ -175,10 +175,10 @@ static ssize_t __hdd_driver_memdump_read(struct file *file, char __user *buf,
 /**
  * hdd_driver_memdump_read() - perform read operation in driver
  * memory dump proc file
- * @file  - handle for the proc file.
- * @buf   - pointer to user space buffer.
- * @count - number of bytes to be read.
- * @pos   - offset in the from buffer.
+ * @file:  handle for the proc file.
+ * @buf:   pointer to user space buffer.
+ * @count: number of bytes to be read.
+ * @pos:   offset in the from buffer.
  *
  * This function performs read operation for the driver memory dump proc file.
  *
@@ -203,13 +203,6 @@ static ssize_t hdd_driver_memdump_read(struct file *file, char __user *buf,
 	return err_size;
 }
 
-/**
- * struct driver_dump_fops - file operations for driver dump feature
- * @read - read function for driver dump operation.
- *
- * This structure initialize the file operation handle for memory
- * dump feature
- */
 #if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0))
 static const struct proc_ops driver_dump_fops = {
 	.proc_read = hdd_driver_memdump_read,
@@ -223,7 +216,7 @@ static const struct file_operations driver_dump_fops = {
 
 /**
  * hdd_driver_memdump_procfs_init() - Initialize procfs for driver memory dump
- * @hdd_ctx Pointer to hdd context
+ * @hdd_ctx: Pointer to hdd context
  *
  * This function create file under proc file system to be used later for
  * processing driver memory dump

+ 1 - 1
core/hdd/src/wlan_hdd_mlo.c

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_mlo.c
+ * DOC: wlan_hdd_mlo.c
  *
  * WLAN Host Device Driver file for 802.11be (Extremely High Throughput)
  * support.

+ 2 - 2
core/hdd/src/wlan_hdd_nan_datapath.c

@@ -49,7 +49,7 @@
 /**
  * hdd_nan_datapath_target_config() - Configure NAN datapath features
  * @hdd_ctx: Pointer to HDD context
- * @cfg: Pointer to target device capability information
+ * @tgt_cfg: Pointer to target device capability information
  *
  * NAN datapath functionality is enabled if it is enabled in
  * .ini file and also supported on target device.
@@ -522,7 +522,7 @@ void hdd_ndp_event_handler(struct hdd_adapter *adapter,
 }
 
 /**
- * __wlan_hdd_cfg80211_process_ndp_cmds() - handle NDP request
+ * __wlan_hdd_cfg80211_process_ndp_cmd() - handle NDP request
  * @wiphy: pointer to wireless wiphy structure.
  * @wdev: pointer to wireless_dev structure.
  * @data: Pointer to the data to be passed via vendor interface

+ 11 - 11
core/hdd/src/wlan_hdd_nan_datapath.h

@@ -59,7 +59,7 @@ int hdd_init_nan_data_mode(struct hdd_adapter *adapter);
 void hdd_ndp_session_end_handler(struct hdd_adapter *adapter);
 
 /**
- * hdd_cleanup_ndi(): Cleanup NDI state/resources
+ * hdd_cleanup_ndi() - Cleanup NDI state/resources
  * @hdd_ctx: HDD context
  * @adapter: Pointer to the NDI adapter
  *
@@ -72,7 +72,7 @@ void hdd_cleanup_ndi(struct hdd_context *hdd_ctx,
 		     struct hdd_adapter *adapter);
 
 /**
- * hdd_ndi_start(): Start NDI adapter and create NDI vdev
+ * hdd_ndi_start() - Start NDI adapter and create NDI vdev
  * @iface_name: NDI interface name
  * @transaction_id: Transaction id given by framework to start the NDI.
  *                  Framework expects this in the immediate response when
@@ -88,7 +88,7 @@ enum nan_datapath_state;
 struct nan_datapath_inf_create_rsp;
 
 /**
- * hdd_ndi_open(): Open NDI interface
+ * hdd_ndi_open() - Open NDI interface
  * @iface_name: NDI interface name
  * @is_add_virtual_iface: is this interface getting created through add virtual
  * interface
@@ -98,7 +98,7 @@ struct nan_datapath_inf_create_rsp;
 int hdd_ndi_open(const char *iface_name, bool is_add_virtual_iface);
 
 /**
- * hdd_ndi_delete(): Delete NDI interface
+ * hdd_ndi_delete() - Delete NDI interface
  * @vdev_id: vdev id of the NDI interface
  * @iface_name: NDI interface name
  * @transaction_id: Transaction id
@@ -109,7 +109,7 @@ int hdd_ndi_delete(uint8_t vdev_id, const char *iface_name,
 		   uint16_t transaction_id);
 
 /**
- * hdd_ndi_close(): Close NDI interface
+ * hdd_ndi_close() - Close NDI interface
  * @vdev_id: vdev id of the NDI interface
  *
  * Return: None
@@ -117,7 +117,7 @@ int hdd_ndi_delete(uint8_t vdev_id, const char *iface_name,
 void hdd_ndi_close(uint8_t vdev_id);
 
 /**
- * hdd_ndi_drv_ndi_create_rsp_handler(): ndi create response handler
+ * hdd_ndi_drv_ndi_create_rsp_handler() - ndi create response handler
  * @vdev_id: vdev id of the NDI interface
  * @ndi_rsp: NDI create response
  *
@@ -127,7 +127,7 @@ void hdd_ndi_drv_ndi_create_rsp_handler(uint8_t vdev_id,
 					struct nan_datapath_inf_create_rsp *ndi_rsp);
 
 /**
- * hdd_ndi_drv_ndi_create_rsp_handler(): ndi delete response handler
+ * hdd_ndi_drv_ndi_delete_rsp_handler() - ndi delete response handler
  * @vdev_id: vdev id of the NDI interface
  *
  * Return: None
@@ -135,7 +135,7 @@ void hdd_ndi_drv_ndi_create_rsp_handler(uint8_t vdev_id,
 void hdd_ndi_drv_ndi_delete_rsp_handler(uint8_t vdev_id);
 
 /**
- * hdd_ndp_new_peer_handler(): NDP new peer indication handler
+ * hdd_ndp_new_peer_handler() - NDP new peer indication handler
  * @vdev_id: vdev id
  * @sta_id: STA ID
  * @peer_mac_addr: MAC address of the peer
@@ -148,11 +148,11 @@ int hdd_ndp_new_peer_handler(uint8_t vdev_id, uint16_t sta_id,
 			     bool first_peer);
 
 /**
- * hdd_ndp_peer_departed_handler(): Handle NDP peer departed indication
+ * hdd_ndp_peer_departed_handler() - Handle NDP peer departed indication
  * @vdev_id: vdev id
  * @sta_id: STA ID
  * @peer_mac_addr: MAC address of the peer
- * @first_peer: Indicates if it is last peer
+ * @last_peer: Indicates if it is last peer
  *
  * Return: None
  */
@@ -162,7 +162,7 @@ void hdd_ndp_peer_departed_handler(uint8_t vdev_id, uint16_t sta_id,
 
 #if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 12, 0))
 /**
- * hdd_ndi_set_mode(): set the adapter mode to NDI
+ * hdd_ndi_set_mode() - set the adapter mode to NDI
  * @iface_name: NDI interface name
  *
  * The adapter mode is STA while creating virtual interface.

+ 3 - 1
core/hdd/src/wlan_hdd_napi.c

@@ -263,6 +263,9 @@ int hdd_napi_event(enum qca_napi_event event, void *data)
 }
 
 #if defined HELIUMPLUS && defined MSM_PLATFORM
+
+static int napi_tput_policy_delay;
+
 /**
  * hdd_napi_perfd_cpufreq() - set/reset min CPU freq for cores
  * @req_state:  high/low
@@ -349,7 +352,6 @@ hnpc_ret:
  * Return: 0 : no action taken, or action return code
  *         !0: error, or action error code
  */
-static int napi_tput_policy_delay;
 int hdd_napi_apply_throughput_policy(struct hdd_context *hddctx,
 				     uint64_t tx_packets,
 				     uint64_t rx_packets)

+ 2 - 0
core/hdd/src/wlan_hdd_object_manager.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -81,6 +82,7 @@ int hdd_objmgr_release_and_destroy_psoc(struct hdd_context *hdd_ctx);
 /**
  * hdd_objmgr_update_tgt_max_vdev_psoc() - Update target max vdev number
  * @hdd_ctx: Hdd context
+ * @max_vdev: Max number of supported vdevs
  *
  * This API update target max vdev number to psoc object
  *

+ 7 - 4
core/hdd/src/wlan_hdd_ocb.c

@@ -100,7 +100,8 @@ static int dot11p_validate_qos_params(struct ocb_wmm_param qos_params[])
 
 /**
  * dot11p_validate_channel() - validates a DSRC channel
- * @center_freq: the channel's center frequency
+ * @wiphy: pointer to the wiphy
+ * @channel_freq: the channel's center frequency
  * @bandwidth: the channel's bandwidth
  * @tx_power: transmit power
  * @reg_power: (output) the max tx power from the regulatory domain
@@ -179,6 +180,7 @@ static int dot11p_validate_channel(struct wiphy *wiphy,
 
 /**
  * hdd_ocb_validate_config() - Validates the config data
+ * @adapter: Pointer to HDD Adapter
  * @config: configuration to be validated
  *
  * Return: 0 on success.
@@ -441,7 +443,7 @@ end:
  * __iw_set_dot11p_channel_sched() - Handler for WLAN_SET_DOT11P_CHANNEL_SCHED
  *				     ioctl
  * @dev: Pointer to net_device structure
- * @iw_request_info: IW Request Info
+ * @info: IW Request Info
  * @wrqu: IW Request Userspace Data Pointer
  * @extra: IW Request Kernel Data Pointer
  *
@@ -580,7 +582,7 @@ fail:
 /**
  * iw_set_dot11p_channel_sched() - IOCTL interface for setting channel schedule
  * @dev: Pointer to net_device structure
- * @iw_request_info: IW Request Info
+ * @info: IW Request Info
  * @wrqu: IW Request Userspace Data Pointer
  * @extra: IW Request Kernel Data Pointer
  *
@@ -707,7 +709,8 @@ const struct nla_policy qca_wlan_vendor_dcc_update_ndl[
  * struct wlan_hdd_ocb_config_channel
  * @chan_freq: frequency of the channel
  * @bandwidth: bandwidth of the channel, either 10 or 20 MHz
- * @mac_address: MAC address assigned to this channel
+ * @flags: channel flags
+ * @reserved: reserved padding, set to 0
  * @qos_params: QoS parameters
  * @max_pwr: maximum transmit power of the channel (1/2 dBm)
  * @min_pwr: minimum transmit power of the channel (1/2 dBm)

+ 37 - 7
core/hdd/src/wlan_hdd_ocb.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2015-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -72,6 +73,7 @@ struct dot11p_channel_sched {
 
 /**
  * enum qca_wlan_vendor_attr_ocb_set_config - vendor subcmd to set ocb config
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_CHANNEL_COUNT:
  *	number of channels in the configuration
  * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_SCHEDULE_SIZE: size of the schedule
@@ -84,6 +86,8 @@ struct dot11p_channel_sched {
  *	array of NDL active state configuration
  * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_FLAGS:
  *	flag to set the absolute expiry
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_ocb_set_config {
 	QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_INVALID = 0,
@@ -101,10 +105,13 @@ enum qca_wlan_vendor_attr_ocb_set_config {
 
 /**
  * enum qca_wlan_vendor_attr_ocb_set_utc_time - vendor subcmd to set UTC time
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_VALUE:
  *	the UTC time as an array of 10 bytes
  * @QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_ERROR:
  *	the time error as an array of 5 bytes
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_ocb_set_utc_time {
 	QCA_WLAN_VENDOR_ATTR_OCB_SET_UTC_TIME_INVALID = 0,
@@ -117,12 +124,16 @@ enum qca_wlan_vendor_attr_ocb_set_utc_time {
 
 /**
  * enum qca_wlan_vendor_attr_ocb_start_timing_advert - vendor subcmd to start
-						       sending timing advert
-						       frames
+ *						       sending timing advert
+ *						       frames
+ * @QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_CHANNEL_FREQ:
  *	channel frequency on which to send the frames
  * @QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_REPEAT_RATE:
  *	number of times the frame is sent in 5 seconds
+ * @QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_AFTER_LAST:
+ *	number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_ocb_start_timing_advert {
 	QCA_WLAN_VENDOR_ATTR_OCB_START_TIMING_ADVERT_INVALID = 0,
@@ -136,8 +147,12 @@ enum qca_wlan_vendor_attr_ocb_start_timing_advert {
 /**
  * enum qca_wlan_vendor_attr_ocb_stop_timing_advert - vendor subcmd to stop
  *						      timing advert
+ * @QCA_WLAN_VENDOR_ATTR_OCB_STOP_TIMING_ADVERT_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_OCB_STOP_TIMING_ADVERT_CHANNEL_FREQ:
  *	the channel frequency on which to stop the timing advert
+ * @QCA_WLAN_VENDOR_ATTR_OCB_STOP_TIMING_ADVERT_AFTER_LAST:
+ *	number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_OCB_STOP_TIMING_ADVERT_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_ocb_stop_timing_advert {
 	QCA_WLAN_VENDOR_ATTR_OCB_STOP_TIMING_ADVERT_INVALID = 0,
@@ -148,12 +163,15 @@ enum qca_wlan_vendor_attr_ocb_stop_timing_advert {
 };
 
 /**
- * enum qca_wlan_vendor_attr_dcc_get_tsf_response - vendor subcmd to get TSF
- *						    timer value
+ * enum qca_wlan_vendor_attr_ocb_get_tsf_resp - vendor subcmd to get TSF
+ *						timer value
+ * @QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_TIMER_HIGH:
  *      higher 32 bits of the timer
  * @QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_TIMER_LOW:
  *      lower 32 bits of the timer
+ * @QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_ocb_get_tsf_resp {
 	QCA_WLAN_VENDOR_ATTR_OCB_GET_TSF_RESP_INVALID = 0,
@@ -167,10 +185,13 @@ enum qca_wlan_vendor_attr_ocb_get_tsf_resp {
 /**
  * enum qca_wlan_vendor_attr_dcc_get_stats - vendor subcmd to get
  *					     dcc stats
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_CHANNEL_COUNT:
  *      the number of channels in the request array
- * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_REQUEST_ARRAY
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_REQUEST_ARRAY:
  *      array of the channel and information being requested
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_dcc_get_stats {
 	QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_INVALID = 0,
@@ -184,10 +205,13 @@ enum qca_wlan_vendor_attr_dcc_get_stats {
 /**
  * enum qca_wlan_vendor_attr_dcc_get_stats_resp - response event from get
  *						  dcc stats
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_CHANNEL_COUNT:
  *      the number of channels in the request array
- * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_STATS_ARRAY
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_STATS_ARRAY:
  *      array of the information being requested
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_dcc_get_stats_resp {
 	QCA_WLAN_VENDOR_ATTR_DCC_GET_STATS_RESP_INVALID = 0,
@@ -200,8 +224,11 @@ enum qca_wlan_vendor_attr_dcc_get_stats_resp {
 
 /**
  * enum qca_wlan_vendor_attr_dcc_clear_stats - vendor subcmd to clear DCC stats
+ * @QCA_WLAN_VENDOR_ATTR_DCC_CLEAR_STATS_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_DCC_CLEAR_STATS_BITMAP:
  *      mask of the type of stats to be cleared
+ * @QCA_WLAN_VENDOR_ATTR_DCC_CLEAR_STATS_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_DCC_CLEAR_STATS_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_dcc_clear_stats {
 	QCA_WLAN_VENDOR_ATTR_DCC_CLEAR_STATS_INVALID = 0,
@@ -212,13 +239,16 @@ enum qca_wlan_vendor_attr_dcc_clear_stats {
 };
 
 /**
- * enum qca_wlan_vendor_attr_ocb_set_config - vendor subcmd to update dcc
+ * enum qca_wlan_vendor_attr_dcc_update_ndl - vendor subcmd to update dcc
+ * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_INVALID: invalid value
  * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_CHANNEL_COUNT:
  *	number of channels in the configuration
  * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_CHANNEL_ARRAY: the array of NDL
  *  channel info
  * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_ACTIVE_STATE_ARRAY: the array of
  *  NDL active states
+ * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_AFTER_LAST: number of enumerators
+ * @QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_MAX: last enumerator
  */
 enum qca_wlan_vendor_attr_dcc_update_ndl {
 	QCA_WLAN_VENDOR_ATTR_DCC_UPDATE_NDL_INVALID = 0,

+ 26 - 43
core/hdd/src/wlan_hdd_p2p.c

@@ -18,11 +18,9 @@
  */
 
 /**
+ * DOC: wlan_hdd_p2p.c
  *
- * @file  wlan_hdd_p2p.c
- *
- * @brief WLAN Host Device Driver implementation for P2P commands interface
- *
+ * WLAN Host Device Driver implementation for P2P commands interface
  */
 
 #include "osif_sync.h"
@@ -483,24 +481,17 @@ int wlan_hdd_cfg80211_mgmt_tx_cancel_wait(struct wiphy *wiphy,
 }
 
 /**
- * hdd_set_p2p_noa
+ * hdd_set_p2p_noa() - Handle P2P_SET_NOA command
+ * @dev: Pointer to net device structure
+ * @command: Pointer to command
  *
- ***FUNCTION:
  * This function is called from hdd_hostapd_ioctl function when Driver
  * get P2P_SET_NOA command from wpa_supplicant using private ioctl
  *
- ***LOGIC:
- * Fill noa Struct According to P2P Power save Option and Pass it to SME layer
- *
- ***ASSUMPTIONS:
- *
+ * This function will construct the NoA Struct According to P2P Power
+ * save Option and Pass it to SME layer
  *
- ***NOTE:
- *
- * @param dev          Pointer to net device structure
- * @param command      Pointer to command
- *
- * @return Status
+ * Return: 0 on success, negative errno if error
  */
 
 int hdd_set_p2p_noa(struct net_device *dev, uint8_t *command)
@@ -567,24 +558,17 @@ int hdd_set_p2p_noa(struct net_device *dev, uint8_t *command)
 }
 
 /**
- * hdd_set_p2p_opps
+ * hdd_set_p2p_opps() - Handle P2P_SET_PS command
+ * @dev: Pointer to net device structure
+ * @command: Pointer to command
  *
- ***FUNCTION:
  * This function is called from hdd_hostapd_ioctl function when Driver
- * get P2P_SET_PS command from wpa_supplicant using private ioctl
- *
- ***LOGIC:
- * Fill noa Struct According to P2P Power save Option and Pass it to SME layer
+ * get P2P_SET_PS command from wpa_supplicant using private ioctl.
  *
- ***ASSUMPTIONS:
+ * This function will construct the NoA Struct According to P2P Power
+ * save Option and Pass it to SME layer
  *
- *
- ***NOTE:
- *
- * @param  dev         Pointer to net device structure
- * @param  command     Pointer to command
- *
- * @return Status
+ * Return: 0 on success, negative errno if error
  */
 
 int hdd_set_p2p_opps(struct net_device *dev, uint8_t *command)
@@ -723,9 +707,9 @@ wlan_hdd_set_ml_capab_add_iface(struct hdd_adapter_create_param *create_params,
  * @wiphy: wiphy pointer
  * @name: User-visible name of the interface
  * @name_assign_type: the name of assign type of the netdev
- * @nl80211_iftype: (virtual) interface types
+ * @type: (virtual) interface types
  * @flags: monitor configuration flags (not used)
- * @vif_params: virtual interface parameters (not used)
+ * @params: virtual interface parameters (not used)
  *
  * Return: the pointer of wireless dev, otherwise ERR_PTR.
  */
@@ -1405,9 +1389,10 @@ int32_t wlan_hdd_set_mas(struct hdd_adapter *adapter, uint8_t mas_value)
 /**
  * set_first_connection_operating_channel() - Function to set
  * first connection oerating channel
- * @adapter:   adapter data
- * @set_value: Quota value for the interface
- * @dev_mode:  Device mode
+ * @hdd_ctx: Hdd context
+ * @set_value: First connection operating channel
+ * @dev_mode: Device operating mode
+ *
  * This function is used to set the first adapter operating
  * channel
  *
@@ -1444,9 +1429,9 @@ static uint32_t set_first_connection_operating_channel(
 /**
  * set_second_connection_operating_channel() - Function to set
  * second connection oerating channel
- * @adapter:   adapter data
- * @set_value: Quota value for the interface
- * @vdev_id:  vdev id
+ * @hdd_ctx: Hdd context
+ * @set_value: Second connection operating channel
+ * @vdev_id: vdev id
  *
  * This function is used to set the first adapter operating
  * channel
@@ -1487,10 +1472,8 @@ static uint32_t set_second_connection_operating_channel(
 
 /**
  * wlan_hdd_set_mcc_p2p_quota() - Function to set quota for P2P
- * @psoc: PSOC object information
- * @set_value:          Qouta value for the interface
- * @operating_channel   First adapter operating channel
- * @vdev_id             vdev id
+ * @adapter: HDD adapter
+ * @set_value: Quota value for the interface
  *
  * This function is used to set the quota for P2P cases
  *

+ 2 - 1
core/hdd/src/wlan_hdd_p2p_listen_offload.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -27,7 +28,7 @@
 
 #ifdef FEATURE_P2P_LISTEN_OFFLOAD
 /**
- * __wlan_hdd_cfg80211_p2p_lo_start() - start P2P Listen Offload
+ * wlan_hdd_cfg80211_p2p_lo_start() - start P2P Listen Offload
  * @wiphy: Pointer to wireless phy
  * @wdev: Pointer to wireless device
  * @data: Pointer to data

+ 11 - 11
core/hdd/src/wlan_hdd_power.c

@@ -113,7 +113,7 @@ void hdd_wlan_suspend_resume_event(uint8_t state)
 }
 
 /**
- * hdd_wlan_offload_event()- send offloads event
+ * hdd_wlan_offload_event() - send offloads event
  * @type: offload type
  * @state: enabled or disabled
  *
@@ -443,7 +443,7 @@ int wlan_hdd_ipv6_changed(struct notifier_block *nb,
 /**
  * hdd_fill_ipv6_uc_addr() - fill IPv6 unicast addresses
  * @idev: pointer to net device
- * @ipv6addr: destination array to fill IPv6 addresses
+ * @ipv6_uc_addr: destination array to fill IPv6 addresses
  * @ipv6addr_type: IPv6 Address type
  * @scope_array: scope of ipv6 addr
  * @count: number of IPv6 addresses
@@ -496,7 +496,7 @@ static int hdd_fill_ipv6_uc_addr(struct inet6_dev *idev,
 /**
  * hdd_fill_ipv6_ac_addr() - fill IPv6 anycast addresses
  * @idev: pointer to net device
- * @ipv6addr: destination array to fill IPv6 addresses
+ * @ipv6_ac_addr: destination array to fill IPv6 addresses
  * @ipv6addr_type: IPv6 Address type
  * @scope_array: scope of ipv6 addr
  * @count: number of IPv6 addresses
@@ -1662,7 +1662,7 @@ flush_mc_list:
 }
 
 /**
- * hdd_update_conn_state_mask(): record info needed by wma_suspend_req
+ * hdd_update_conn_state_mask() - record info needed by wma_suspend_req
  * @adapter: adapter to get info from
  * @conn_state_mask: mask of connection info
  *
@@ -1677,8 +1677,6 @@ static void hdd_update_conn_state_mask(struct hdd_adapter *adapter,
 
 /**
  * hdd_suspend_wlan() - Driver suspend function
- * @callback: Callback function to invoke when driver is ready to suspend
- * @callbackContext: Context to pass back to @callback function
  *
  * Return: 0 on success else error code.
  */
@@ -1918,7 +1916,7 @@ QDF_STATUS hdd_wlan_shutdown(void)
 
 #ifdef FEATURE_WLAN_DIAG_SUPPORT
 /**
- * hdd_wlan_ssr_reinit_event()- send ssr reinit state
+ * hdd_wlan_ssr_reinit_event() - send ssr reinit state
  *
  * This Function send send ssr reinit state diag event
  *
@@ -1941,7 +1939,8 @@ static inline void hdd_wlan_ssr_reinit_event(void)
 
 #ifdef WLAN_FEATURE_DBAM_CONFIG
 /**
- * hdd_retore_dbam_config - restore and send dbam config to fw
+ * hdd_restore_dbam_config() - restore and send dbam config to fw
+ * @hdd_ctx: HDD context
  *
  * This function is used to send  store dbam config to fw
  * in case of wlan re-init
@@ -1998,7 +1997,8 @@ static void hdd_restore_dual_sta_config(struct hdd_context *hdd_ctx)
 }
 
 /**
- * hdd_send_default_scan_ies - send default scan ies to fw
+ * hdd_send_default_scan_ies() - send default scan ies to fw
+ * @hdd_ctx: HDD context
  *
  * This function is used to send default scan ies to fw
  * in case of wlan re-init
@@ -2026,7 +2026,7 @@ static void hdd_send_default_scan_ies(struct hdd_context *hdd_ctx)
 }
 
 /**
- * hdd_restore_sar_config - Restore the saved SAR config after SSR
+ * hdd_restore_sar_config() - Restore the saved SAR config after SSR
  * @hdd_ctx: HDD context
  *
  * Restore the SAR config that was lost during SSR.
@@ -2433,7 +2433,7 @@ static int _wlan_hdd_cfg80211_resume_wlan(struct wiphy *wiphy)
 		return 0;
 	}
 
-	/**
+	/*
 	 * Return success if recovery is in progress, otherwise, linux kernel
 	 * will shutdown all interfaces in wiphy_resume.
 	 */

+ 2 - 2
core/hdd/src/wlan_hdd_pre_cac.c

@@ -26,7 +26,7 @@
 #include "wlan_dp_ucfg_api.h"
 
 /**
- * __wlan_hdd_sap_pre_cac_failure() - Process the pre cac failure
+ * wlan_hdd_pre_cac_failure() - Process the pre cac failure
  * @adapter: AP adapter
  *
  * Deletes the pre cac adapter
@@ -49,7 +49,7 @@ static void wlan_hdd_pre_cac_failure(struct hdd_adapter *adapter)
 }
 
 /**
- * __wlan_hdd_sap_pre_cac_success() - Process the pre cac result
+ * wlan_hdd_pre_cac_success() - Process the pre cac result
  * @adapter: AP adapter
  *
  * Stops the pre cac adapter and moves the existing SAP to the pre cac

+ 10 - 3
core/hdd/src/wlan_hdd_regulatory.c

@@ -506,7 +506,8 @@ static void hdd_modify_wiphy(struct wiphy  *wiphy,
 
 /**
  * hdd_set_dfs_region() - set the dfs_region
- * @dfs_region: the dfs_region to set
+ * @hdd_ctx: HDD context
+ * @dfs_reg: the dfs_region to set
  *
  * Return: void
  */
@@ -701,8 +702,11 @@ static int hdd_regulatory_init_no_offload(struct hdd_context *hdd_ctx,
 
 /**
  * hdd_modify_indoor_channel_state_flags() - modify wiphy flags and cds state
+ * @hdd_ctx: HDD context
  * @wiphy_chan: wiphy channel number
  * @cds_chan: cds channel structure
+ * @chan_enum: enumerated value of the channel
+ * @chan_num: channel number
  * @disable: Disable/enable the flags
  *
  * Modify wiphy flags and cds state if channel is indoor.
@@ -999,6 +1003,7 @@ static void hdd_restore_custom_reg_settings(struct wiphy *wiphy,
 
 /**
  * hdd_restore_reg_flags() - restore regulatory flags
+ * @wiphy: device wiphy
  * @flags: regulatory flags
  *
  * Return: void
@@ -1270,8 +1275,9 @@ static void fill_wiphy_band_channels(struct wiphy *wiphy,
 #ifdef FEATURE_WLAN_CH_AVOID
 /**
  * hdd_ch_avoid_ind() - Avoid notified channels from FW handler
- * @adapter:	HDD adapter pointer
- * @indParam:	Channel avoid notification parameter
+ * @hdd_ctxt: HDD context
+ * @unsafe_chan_list: Channels that are unsafe
+ * @avoid_freq_list: Frequencies to avoid
  *
  * Avoid channel notification from FW handler.
  * FW will send un-safe channel list to avoid over wrapping.
@@ -1408,6 +1414,7 @@ static enum nl80211_dfs_regions dfs_reg_to_nl80211_dfs_regions(
 
 /**
  * hdd_set_dfs_pri_multiplier() - Set dfs_pri_multiplier for ETSI region
+ * @hdd_ctx: HDD context
  * @dfs_region: DFS region
  *
  * Return: none

+ 4 - 4
core/hdd/src/wlan_hdd_sar_limits.c

@@ -35,7 +35,7 @@
 
 #define WLAN_WAIT_TIME_SAR 5000
 /**
- * hdd_sar_context - hdd sar context
+ * struct hdd_sar_context - hdd sar context
  * @event: sar limit event
  */
 struct hdd_sar_context {
@@ -308,7 +308,7 @@ cleanup:
 
 /**
  * hdd_to_nl_sar_version - Map SAR version enum from hdd to nl
- * @cur_sar_version - Current SAR version stored in hdd_ctx
+ * @hdd_sar_version: Current SAR version stored in hdd_ctx
  *
  * This function is used to map SAR version enum stored in hdd_ctx to
  * nl
@@ -333,8 +333,8 @@ static u32 hdd_to_nl_sar_version(enum sar_version hdd_sar_version)
 
 /**
  * hdd_sar_fill_capability_response - Fill SAR capability
- * @skb - Pointer to socket buffer
- * @hdd_ctx - pointer to hdd context
+ * @skb: Pointer to socket buffer
+ * @hdd_ctx: pointer to hdd context
  *
  * This function fills SAR Capability in the socket buffer
  *

+ 3 - 2
core/hdd/src/wlan_hdd_sar_limits.h

@@ -39,7 +39,7 @@
 void wlan_hdd_sar_unsolicited_timer_start(struct hdd_context *hdd_ctx);
 
 /**
- * wlan_hdd_sar_safety_timer_reset() - Reset SAR sefety timer
+ * wlan_hdd_sar_timers_reset() - Reset SAR timers
  * @hdd_ctx: Pointer to HDD context
  *
  * This function checks the state of the sar safety timer, if the
@@ -211,7 +211,8 @@ void hdd_store_sar_config(struct hdd_context *hdd_ctx,
 			  struct sar_limit_cmd_params *sar_limit_cmd);
 
 /**
- * hdd_free_sar_config() - Free the resources allocated while storing SAR config
+ * wlan_hdd_free_sar_config() - Free the resources allocated while storing
+ *                              SAR config
  * @hdd_ctx: HDD context
  *
  * The driver stores the SAR config values in HDD context so that it can be

+ 8 - 11
core/hdd/src/wlan_hdd_scan.c

@@ -54,9 +54,9 @@
 
 /**
  * hdd_vendor_scan_callback() - Scan completed callback event
- * @hddctx: HDD context
- * @req : Scan request
- * @aborted : true scan aborted false scan success
+ * @adapter: HDD adapter
+ * @req: Scan request
+ * @aborted: true scan aborted false scan success
  *
  * This function sends scan completed callback event to NL.
  *
@@ -429,7 +429,6 @@ wlan_hdd_enqueue_blocked_scan_request(struct net_device *dev,
 /**
  * __wlan_hdd_cfg80211_scan() - API to process cfg80211 scan request
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to net device
  * @request: Pointer to scan request
  * @source: scan request source(NL/Vendor scan)
  *
@@ -686,7 +685,6 @@ error:
 /**
  * wlan_hdd_cfg80211_scan() - API to process cfg80211 scan request
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to net device
  * @request: Pointer to scan request
  *
  * This API responds to scan trigger and update cfg80211 scan database
@@ -1164,9 +1162,9 @@ error:
 /**
  * wlan_hdd_cfg80211_vendor_scan() -API to process venor scan request
  * @wiphy: Pointer to wiphy
- * @dev: Pointer to net device
- * @data : Pointer to the data
- * @data_len : length of the data
+ * @wdev: Pointer to wireless device
+ * @data: Pointer to the data
+ * @data_len: length of the data
  *
  * This is called from userspace to request scan.
  *
@@ -1194,9 +1192,8 @@ int wlan_hdd_cfg80211_vendor_scan(struct wiphy *wiphy,
  * __wlan_hdd_vendor_abort_scan() - API to process vendor command for
  * abort scan
  * @wiphy: Pointer to wiphy
- * @wdev: Pointer to net device
- * @data : Pointer to the data
- * @data_len : length of the data
+ * @data: Pointer to the data
+ * @data_len: length of the data
  *
  * API to process vendor abort scan
  *

+ 2 - 1
core/hdd/src/wlan_hdd_scan.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -17,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_scan.h
+ * DOC: wlan_hdd_scan.h
  *
  * WLAN Host Device Driver scan related implementation
  *

+ 2 - 1
core/hdd/src/wlan_hdd_softap_tx_rx.c

@@ -63,7 +63,7 @@
 /* Type declarations */
 #ifdef FEATURE_WDS
 /**
- * Layer-2 update frame format
+ * struct l2_update_frame - Layer-2 update frame format
  * @eh: ethernet header
  * @l2_update_pdu: llc pdu format
  * @l2_update_xid_info: xid command information field
@@ -374,6 +374,7 @@ hdd_reset_sta_info_during_reattach(struct hdd_station_info *sta_info)
  *                      the sta_info obj.
  * @sta_info: The station info structure that is to be attached to the
  *            container object.
+ * @sta_mac: MAC address of the station
  *
  * This function re-attaches the station if it gets re-connect after
  * disconnecting and before its all references are released.

+ 4 - 4
core/hdd/src/wlan_hdd_son.c

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : contains son hdd API implementation
+ * DOC: contains son hdd API implementation
  */
 
 #include <qdf_types.h>
@@ -1114,7 +1114,7 @@ static uint32_t hdd_son_get_sta_space(struct wlan_objmgr_vdev *vdev)
 }
 
 /**
- * hdd_son_get_stalist() - get connected station list
+ * hdd_son_get_sta_list() - get connected station list
  * @vdev: vdev
  * @si: pointer to ieee80211req_sta_info
  * @space: space left
@@ -1408,7 +1408,7 @@ static int hdd_son_del_acl_mac(struct wlan_objmgr_vdev *vdev,
 /**
  * hdd_son_kickout_mac() - kickout sta with given mac
  * @vdev: vdev
- * @acl_mac: sta mac to kickout
+ * @mac: sta mac to kickout
  *
  * Return: 0 on success, negative errno on failure
  */
@@ -2519,7 +2519,7 @@ uint32_t hdd_son_get_peer_max_mcs_idx(struct wlan_objmgr_vdev *vdev,
 }
 
 /**
- * hdd_son_sta_stats() - get connected sta rssi and estimated data rate
+ * hdd_son_get_sta_stats() - get connected sta rssi and estimated data rate
  * @vdev: pointer to vdev
  * @mac_addr: connected sta mac addr
  * @stats: pointer to ieee80211_nodestats

+ 1 - 1
core/hdd/src/wlan_hdd_son.h

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : contains son hdd API implementation
+ * DOC: contains son hdd API implementation
  */
 
 #ifndef WLAN_HDD_SON_H

+ 19 - 11
core/hdd/src/wlan_hdd_sta_info.h

@@ -40,7 +40,7 @@
 #define hdd_sta_info_entry qdf_list_node_t
 
 /**
- * struct dhcp_phase - Per Peer DHCP Phases
+ * enum dhcp_phase - Per Peer DHCP Phases
  * @DHCP_PHASE_ACK: upon receiving DHCP_ACK/NAK message in REQUEST phase or
  *         DHCP_DELINE message in OFFER phase
  * @DHCP_PHASE_DISCOVER: upon receiving DHCP_DISCOVER message in ACK phase
@@ -56,7 +56,7 @@ enum dhcp_phase {
 };
 
 /**
- * struct dhcp_nego_status - Per Peer DHCP Negotiation Status
+ * enum dhcp_nego_status - Per Peer DHCP Negotiation Status
  * @DHCP_NEGO_STOP: when the peer is in ACK phase or client disassociated
  * @DHCP_NEGO_IN_PROGRESS: when the peer is in DISCOVER or REQUEST
  *         (Renewal process) phase
@@ -66,7 +66,7 @@ enum dhcp_nego_status {
 	DHCP_NEGO_IN_PROGRESS
 };
 
-/**
+/*
  * Pending frame type of EAP_FAILURE, bit number used in "pending_eap_frm_type"
  * of sta_info.
  */
@@ -112,7 +112,7 @@ enum dhcp_nego_status {
  * @STA_INFO_WLAN_HDD_CFG80211_DUMP_STATION: NL80211_CMD_GET_STATION dumpit
  *                                           handler for SoftAP
  * @STA_INFO_SON_GET_DATRATE_INFO: gets datarate info for a SON node
- *
+ * @STA_INFO_ID_MAX: Number of enumerators
  */
 /*
  * New value added to the enum must also be reflected in function
@@ -157,7 +157,7 @@ typedef enum {
 
 /**
  * sta_info_string_from_dbgid() - Convert dbgid to respective string
- * @id -  debug id
+ * @id: debug id
  *
  * Debug support function to convert  dbgid to string.
  * Please note to add new string in the array at index equal to
@@ -191,6 +191,7 @@ char *sta_info_string_from_dbgid(wlan_sta_info_dbgid id);
  * @rx_bytes: Bytes received from current station
  * @last_tx_rx_ts: Last tx/rx timestamp with current station
  * @assoc_ts: Current station association timestamp
+ * @disassoc_ts: Current station disassociation timestamp
  * @tx_rate: Tx rate with current station reported from F/W
  * @rx_rate: Rx rate with current station reported from F/W
  * @ampdu: Ampdu enable or not of the station
@@ -216,6 +217,8 @@ char *sta_info_string_from_dbgid(wlan_sta_info_dbgid id);
  * @vht_caps: VHT capabilities of current station
  * @reason_code: Disconnection reason code for current station
  * @rssi: RSSI of the current station reported from F/W
+ * @dhcp_phase: Current phase of DHCP
+ * @dhcp_nego_status: Status of DHCP negotiation
  * @capability: Capability information of current station
  * @support_mode: Max supported mode of a station currently
  * connected to sap
@@ -240,8 +243,8 @@ char *sta_info_string_from_dbgid(wlan_sta_info_dbgid id);
  * @pending_eap_frm_type: EAP frame type in tx queue without tx completion
  * @is_attached: Flag to check if the stainfo is attached/detached
  * @peer_rssi_per_chain: Average value of RSSI (dbm) per chain
- * @num_tx_rate_counts: Num tx rate count for current peer
- * @num_rx_rate_counts: Num rx rate count for current peer
+ * @num_tx_rate_count: Num tx rate count for current peer
+ * @num_rx_rate_count: Num rx rate count for current peer
  * @tx_pkt_per_mcs: Number of tx rate counts for each MCS
  * @rx_pkt_per_mcs: Number of rx rate counts for each MCS
  */
@@ -380,6 +383,7 @@ hdd_get_front_sta_info_no_lock(struct hdd_sta_info_obj *sta_info_container,
  *
  * @sta_info_container: The station info container obj that stores and maintains
  *                      the sta_info obj.
+ * @current_sta_info: The station that was previously retrieved
  * @out_sta_info: The station info structure that acts as the container object.
  *
  * Return: QDF_STATUS
@@ -398,6 +402,8 @@ hdd_get_next_sta_info_no_lock(struct hdd_sta_info_obj *sta_info_container,
  * @sta_info_container: The station info container obj that stores and maintains
  *			the sta_info obj.
  * @sta_info: The station info structure that acts as the iterator object.
+ * @next_sta_info: A temporary node for maintaining del safe.
+ * @sta_info_dbgid: Debug ID of the caller API
  */
 #define __hdd_take_ref_and_fetch_front_sta_info_safe(sta_info_container, \
 						     sta_info, next_sta_info, \
@@ -421,6 +427,8 @@ hdd_get_next_sta_info_no_lock(struct hdd_sta_info_obj *sta_info_container,
  * @sta_info_container: The station info container obj that stores and maintains
  *			the sta_info obj.
  * @sta_info: The station info structure that acts as the iterator object.
+ * @next_sta_info: A temporary node for maintaining del safe.
+ * @sta_info_dbgid: Debug ID of the caller API
  */
 #define __hdd_take_ref_and_fetch_next_sta_info_safe(sta_info_container, \
 						    sta_info, next_sta_info, \
@@ -476,7 +484,7 @@ hdd_get_next_sta_info_no_lock(struct hdd_sta_info_obj *sta_info_container,
 							 sta_info_dbgid))
 
 /**
- * wlan_sta_info_init() - Initialise the wlan hdd station info container obj
+ * hdd_sta_info_init() - Initialise the wlan hdd station info container obj
  * @sta_info_container: The station info container obj that stores and maintains
  *                      the sta_info obj.
  *
@@ -485,7 +493,7 @@ hdd_get_next_sta_info_no_lock(struct hdd_sta_info_obj *sta_info_container,
 QDF_STATUS hdd_sta_info_init(struct hdd_sta_info_obj *sta_info_container);
 
 /**
- * wlan_sta_info_deinit() - Deinit the wlan hdd station info container obj
+ * hdd_sta_info_deinit() - Deinit the wlan hdd station info container obj
  * @sta_info_container: The station info container obj that stores and maintains
  *                      the sta_info obj.
  *
@@ -549,8 +557,8 @@ struct hdd_station_info *hdd_get_sta_info_by_mac(
 
 /**
  * hdd_clear_cached_sta_info() - Clear the cached sta info from the container
- * @sta_info_container: The station info container obj that stores and maintains
- *                      the sta_info obj.
+ * @hdd_adapter: The adapter containing the station info container obj that
+ *               stores and maintains the sta_info obj.
  *
  * Return: None
  */

+ 16 - 11
core/hdd/src/wlan_hdd_station_info.c

@@ -194,7 +194,7 @@ static int hdd_get_sta_congestion(struct hdd_adapter *adapter,
 /**
  * hdd_get_station_assoc_fail() - Handle get station assoc fail
  * @hdd_ctx: HDD context within host driver
- * @wdev: wireless device
+ * @adapter: pointer to adapter
  *
  * Handles QCA_NL80211_VENDOR_SUBCMD_GET_STATION_ASSOC_FAIL.
  * Validate cmd attributes and send the station info to upper layers.
@@ -244,11 +244,11 @@ fail:
 }
 
 /**
- * hdd_map_auth_type() - transform auth type specific to
+ * hdd_convert_auth_type() - transform auth type specific to
  * vendor command
  * @auth_type: csr auth type
  *
- * Return: Success(0) or reason code for failure
+ * Return: vendor command auth type
  */
 static int hdd_convert_auth_type(uint32_t auth_type)
 {
@@ -347,11 +347,11 @@ static int hdd_convert_auth_type(uint32_t auth_type)
 }
 
 /**
- * hdd_map_dot_11_mode() - transform dot11mode type specific to
+ * hdd_convert_dot11mode() - transform dot11mode type specific to
  * vendor command
- * @dot11mode: dot11mode
+ * @dot11mode: CSR dot11 mode
  *
- * Return: Success(0) or reason code for failure
+ * Return: vendor command dot11 mode
  */
 static int hdd_convert_dot11mode(uint32_t dot11mode)
 {
@@ -384,7 +384,7 @@ static int hdd_convert_dot11mode(uint32_t dot11mode)
 /**
  * hdd_add_tx_bitrate() - add tx bitrate attribute
  * @skb: pointer to sk buff
- * @hdd_sta_ctx: pointer to hdd station context
+ * @adapter: pointer to adapter
  * @idx: attribute index
  *
  * Return: Success(0) or reason code for failure
@@ -452,7 +452,8 @@ fail:
 /**
  * hdd_add_sta_info() - add station info attribute
  * @skb: pointer to sk buff
- * @hdd_sta_ctx: pointer to hdd station context
+ * @hdd_ctx: pointer to hdd station context
+ * @adapter: pointer to adapter
  * @idx: attribute index
  *
  * Return: Success(0) or reason code for failure
@@ -529,7 +530,8 @@ fail:
 /**
  * hdd_add_link_standard_info() - add link info attribute
  * @skb: pointer to sk buff
- * @hdd_sta_ctx: pointer to hdd station context
+ * @hdd_ctx: pointer to hdd context
+ * @adapter: pointer to adapter
  * @idx: attribute index
  *
  * Return: Success(0) or reason code for failure
@@ -850,7 +852,7 @@ static uint32_t hdd_add_survey_info_sap_get_len(void)
 }
 
 /**
- * hdd_add_survey_info - add survey info attribute
+ * hdd_add_survey_info_sap() - add survey info attribute
  * @skb: pointer to response skb buffer
  * @stainfo: station information
  * @idx: attribute type index for nla_next_start()
@@ -948,6 +950,7 @@ static uint32_t hdd_add_sta_info_sap_get_len(void)
 /**
  * hdd_add_sta_info_sap - add sta signal info attribute
  * @skb: pointer to response skb buffer
+ * @rssi: station RSSI
  * @stainfo: station information
  * @idx: attribute type index for nla_next_start()
  *
@@ -999,6 +1002,7 @@ static uint32_t hdd_add_link_standard_info_sap_get_len(void)
 /**
  * hdd_add_link_standard_info_sap - add add link info attribute
  * @skb: pointer to response skb buffer
+ * @rssi: station RSSI
  * @stainfo: station information
  * @idx: attribute type index for nla_next_start()
  *
@@ -1282,10 +1286,11 @@ fail:
 }
 
 /**
- * hdd_get_cached_station_remote() - get connected peer's info
+ * hdd_get_connected_station_info() - get connected peer's info
  * @hdd_ctx: hdd context
  * @adapter: hostapd interface
  * @mac_addr: mac address of requested peer
+ * @stainfo: location to store peer info
  *
  * This function collect and indicate the connected peer's info
  *

+ 21 - 17
core/hdd/src/wlan_hdd_stats.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_stats.c
+ * DOC: wlan_hdd_stats.c
  *
  * WLAN Host Device Driver statistics related implementation
  *
@@ -457,8 +457,9 @@ int wlan_hdd_qmi_put_suspend(void)
  * @result_param_id: Received link layer stats ID
  * @result: received stats from FW
  * @more_data: if more stats are pending
- * @no_of_radios: no of radios
- * @no_of_peers: no of peers
+ * @stats_nradio_npeer: union of counts
+ * @stats_nradio_npeer.no_of_radios: no of radios
+ * @stats_nradio_npeer.no_of_peers: no of peers
  */
 struct hdd_ll_stats {
 	qdf_list_node_t ll_stats_node;
@@ -473,7 +474,7 @@ struct hdd_ll_stats {
 
 /**
  * struct hdd_ll_stats_priv - hdd link layer stats private
- * @ll_stats: head to different link layer stats received in scheduler
+ * @ll_stats_q: head to different link layer stats received in scheduler
  *            thread context
  * @request_id: userspace-assigned link layer stats request id
  * @request_bitmap: userspace-assigned link layer stats request bitmap
@@ -732,7 +733,7 @@ static bool put_wifi_interface_info(struct wifi_interface_info *stats,
 /**
  * put_wifi_iface_stats() - put wifi interface stats
  * @if_stat: Pointer to interface stats context
- * @num_peer: Number of peers
+ * @num_peers: Number of peers
  * @vendor_event: Pointer to vendor event
  *
  * Return: bool
@@ -1390,7 +1391,7 @@ failure:
  * @adapter: Pointer to device adapter
  * @more_data: More data
  * @radio_stat: Pointer to stats data
- * @num_radios: Number of radios
+ * @num_radio: Number of radios
  *
  * Receiving Link Layer Radio statistics from FW.This function converts
  * the firmware data to the NL data and sends the same to the kernel/upper
@@ -2807,7 +2808,7 @@ hdd_populate_tx_failure_info(struct sir_wifi_iface_tx_fail *tx_fail,
 
 /**
  * hdd_populate_wifi_channel_cca_info() - put channel cca info to vendor event
- * @info: cca info array for all channels
+ * @cca: cca info array for all channels
  * @vendor_event: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -2855,7 +2856,7 @@ hdd_populate_wifi_channel_cca_info(struct sir_wifi_chan_cca_stats *cca,
 
 /**
  * hdd_populate_wifi_signal_info - put chain signal info
- * @info: RF chain signal info
+ * @peer_signal: RF chain signal info
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -2924,7 +2925,7 @@ hdd_populate_wifi_signal_info(struct sir_wifi_peer_signal_stats *peer_signal,
 
 /**
  * hdd_populate_wifi_wmm_ac_tx_info() - put AC TX info
- * @info: tx info
+ * @tx_stats: tx info
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -3011,7 +3012,7 @@ put_attr_fail:
 
 /**
  * hdd_populate_wifi_wmm_ac_rx_info() - put AC RX info
- * @info: rx info
+ * @rx_stats: rx info
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -3079,7 +3080,7 @@ put_attr_fail:
 
 /**
  * hdd_populate_wifi_wmm_ac_info() - put WMM AC info
- * @info: per AC stats
+ * @ac_stats: per AC stats
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -3112,7 +3113,7 @@ put_attr_fail:
 
 /**
  * hdd_populate_wifi_ll_ext_peer_info() - put per peer info
- * @info: peer stats
+ * @peers: peer stats
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -3169,7 +3170,7 @@ hdd_populate_wifi_ll_ext_peer_info(struct sir_wifi_ll_ext_peer_stats *peers,
 
 /**
  * hdd_populate_wifi_ll_ext_stats() - put link layer extension stats
- * @info: link layer stats
+ * @stats: link layer stats
  * @skb: vendor event buffer
  *
  * Return: 0 Success, EINVAL failure
@@ -4113,8 +4114,8 @@ enum roam_event_rt_info_reset {
  * struct roam_ap - Roamed/Failed AP info
  * @num_cand: number of candidate APs
  * @bssid:    BSSID of roamed/failed AP
- * rssi:      RSSI of roamed/failed AP
- * freq:      Frequency of roamed/failed AP
+ * @rssi:     RSSI of roamed/failed AP
+ * @freq:     Frequency of roamed/failed AP
  */
 struct roam_ap {
 	uint32_t num_cand;
@@ -5117,6 +5118,7 @@ static void hdd_fill_rate_info(struct wlan_objmgr_psoc *psoc,
 /**
  * wlan_hdd_fill_station_info() - fill station_info struct
  * @psoc: psoc context
+ * @adapter: The HDD adapter structure
  * @sinfo: station_info struct pointer
  * @stainfo: stainfo pointer
  * @stats: fw txrx status pointer
@@ -5522,6 +5524,7 @@ static void wlan_hdd_fill_os_he_rateflags(struct rate_info *os_rate,
  * @legacy_rate: 802.11abg rate
  * @os_rate: rate info for os
  * @mcs_index: mcs
+ * @nss: number of spatial streams
  * @dcm: dcm from rate
  * @guard_interval: guard interval from rate
  *
@@ -6932,7 +6935,9 @@ static bool hdd_is_rcpi_applicable(struct hdd_adapter *adapter,
 /**
  * wlan_hdd_get_rcpi_cb() - callback function for rcpi response
  * @context: Pointer to rcpi context
- * @rcpi_req: Pointer to rcpi response
+ * @mac_addr: peer MAC address
+ * @rcpi: RCPI response
+ * @status: QDF_STATUS of the request
  *
  * Return: None
  */
@@ -7188,7 +7193,6 @@ struct snr_priv {
 /**
  * hdd_get_snr_cb() - "Get SNR" callback function
  * @snr: Current SNR of the station
- * @sta_id: ID of the station
  * @context: opaque context originally passed to SME.  HDD always passes
  *	a cookie for the request context
  *

+ 5 - 6
core/hdd/src/wlan_hdd_stats.h

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_stats.h
+ * DOC: wlan_hdd_stats.h
  *
  * WLAN Host Device Driver statistics related implementation
  *
@@ -115,11 +115,11 @@ struct index_vht_data_rate_type {
 };
 
 /**
- * enum - data_rate_11ac_max_mcs
+ * enum data_rate_11ac_max_mcs - possible VHT max MCS values
  * @DATA_RATE_11AC_MAX_MCS_7: MCS7 rate
  * @DATA_RATE_11AC_MAX_MCS_8: MCS8 rate
  * @DATA_RATE_11AC_MAX_MCS_9: MCS9 rate
- * @DATA_RATE_11AC_MAX_MCS_NA:i Not applicable
+ * @DATA_RATE_11AC_MAX_MCS_NA: Not applicable
  */
 enum data_rate_11ac_max_mcs {
 	DATA_RATE_11AC_MAX_MCS_7,
@@ -191,7 +191,7 @@ static inline bool hdd_link_layer_stats_supported(void)
 }
 
 /**
- * __wlan_hdd_cfg80211_ll_stats_ext_set_param - config monitor parameters
+ * wlan_hdd_cfg80211_ll_stats_ext_set_param() - config monitor parameters
  * @wiphy: wiphy handle
  * @wdev: wdev handle
  * @data: user layer input
@@ -545,7 +545,6 @@ wlan_cfg80211_mc_cp_get_big_data_stats(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_cfg80211_mc_cp_stats_free_big_data_stats_event() - API to release big
  * data statistics buffer
- * @vdev:    Pointer to vdev
  * @info:    pointer to object to populate with big data stats
  *
  * Return: None
@@ -631,7 +630,7 @@ void wlan_hdd_display_tx_multiq_stats(hdd_cb_handle context, uint8_t vdev_id)
  * @rate: The station_info tx/rx rate to be filled
  * @signal: signal from station_info
  * @rate_flags: TX/RX rate flags computed from tx/rx rate
- * @mcs_index; The TX/RX mcs index computed from tx/rx rate
+ * @mcs_index: The TX/RX mcs index computed from tx/rx rate
  * @fw_rate: The tx/rx rate from fw stats
  * @nss: The TX/RX NSS from fw stats
  *

+ 2 - 2
core/hdd/src/wlan_hdd_sysfs_add_timestamp.h

@@ -45,8 +45,8 @@
 int hdd_sysfs_dp_pkt_add_ts_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_dp_pkt_add_ts_destroy() -
- *   API to destroy dp trace related files
+ * hdd_sysfs_dp_pkt_add_ts_destroy() - API to destroy dp trace related files
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 2 - 1
core/hdd/src/wlan_hdd_sysfs_dl_modes.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_DL_MODES)
 /**
- * wlan_hdd_sysfs_dl_modes_create() - API to create motion
+ * hdd_sysfs_dl_modes_create() - API to create motion
  * detection sysfs attributes
  * @adapter: hdd adapter
  *

+ 5 - 4
core/hdd/src/wlan_hdd_sysfs_dp_aggregation.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -39,7 +40,7 @@
  * Return: 0 on success and errno on failure
  */
 int
-hdd_sysfs_dp_aggregation_create(struct kobject *drv_kobj);
+hdd_sysfs_dp_aggregation_create(struct kobject *driver_kobject);
 
 /**
  * hdd_sysfs_dp_aggregation_destroy() - API to destroy dp aggregation
@@ -49,16 +50,16 @@ hdd_sysfs_dp_aggregation_create(struct kobject *drv_kobj);
  * Return: None
  */
 void
-hdd_sysfs_dp_aggregation_destroy(struct kobject *drv_kobj);
+hdd_sysfs_dp_aggregation_destroy(struct kobject *driver_kobject);
 #else
 static inline int
-hdd_sysfs_dp_aggregation_create(struct kobject *drv_kobj)
+hdd_sysfs_dp_aggregation_create(struct kobject *driver_kobject)
 {
 	return 0;
 }
 
 static inline void
-hdd_sysfs_dp_aggregation_destroy(struct kobject *drv_kobj)
+hdd_sysfs_dp_aggregation_destroy(struct kobject *driver_kobject)
 {
 }
 #endif

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_dp_trace.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -53,8 +54,8 @@
 int hdd_sysfs_dp_trace_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_dp_trace_destroy() -
- *   API to destroy dp trace related files
+ * hdd_sysfs_dp_trace_destroy() - API to destroy dp trace related files
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 1 - 1
core/hdd/src/wlan_hdd_sysfs_eht_rate.c

@@ -16,7 +16,7 @@
  */
 
 /**
- * DOC : wlan_hdd_sysfs_eht_rate.c
+ * DOC: wlan_hdd_sysfs_eht_rate.c
  *
  * implementation for creating sysfs file 11be_rate
  *

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_fw_mode_config.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -40,8 +41,8 @@
 int hdd_sysfs_fw_mode_config_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_fw_mode_config_destroy() -
- *   API to destroy fw_mode_config sysfs file
+ * hdd_sysfs_fw_mode_config_destroy() - API to destroy fw_mode_config sysfs file
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 1 - 0
core/hdd/src/wlan_hdd_sysfs_get_freq_for_pwr.h

@@ -41,6 +41,7 @@ int hdd_sysfs_get_valid_freq_for_power_create(struct kobject *driver_kobject);
 /**
  * hdd_sysfs_get_valid_freq_for_power_destroy() -
  * API to destroy get_valid_freq sysfs
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 3 - 3
core/hdd/src/wlan_hdd_sysfs_gtx_bw_mask.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_GTX_BW_MASK)
 /**
- * wlan_hdd_sysfs_gtx_bw_mask_create() - API to create gtx_bw_mask
+ * hdd_sysfs_gtx_bw_mask_create() - API to create gtx_bw_mask
  * @adapter: hdd adapter
  *
  * this file is created per adapter.
@@ -40,8 +41,7 @@
 int hdd_sysfs_gtx_bw_mask_create(struct hdd_adapter *adapter);
 
 /**
- * hdd_sysfs_gtx_bw_mask_destroy() -
- *   API to destroy gtx_bw_mask
+ * hdd_sysfs_gtx_bw_mask_destroy() - API to destroy gtx_bw_mask
  * @adapter: pointer to adapter
  *
  * Return: none

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_mem_stats.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -40,8 +41,8 @@
 int hdd_sysfs_mem_stats_create(struct kobject *wlan_kobject);
 
 /**
- * hdd_sysfs_mem_stats_destroy() - API to destroy
- * wlan_mem_stats
+ * hdd_sysfs_mem_stats_destroy() - API to destroy wlan_mem_stats
+ * @wlan_kobject: sysfs wlan kobject
  *
  * Return: none
  */

+ 2 - 1
core/hdd/src/wlan_hdd_sysfs_motion_detection.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(WLAN_FEATURE_MOTION_DETECTION)
 /**
- * wlan_hdd_sysfs_motion_detection_create() - API to create motion
+ * hdd_sysfs_motion_detection_create() - API to create motion
  * detection sysfs attributes
  * @adapter: hdd adapter
  *

+ 2 - 1
core/hdd/src/wlan_hdd_sysfs_radar.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_SYSFS_RADAR)
 /**
- * wlan_hdd_sysfs_radar_create() - API to create radar sysfs file
+ * hdd_sysfs_radar_create() - API to create radar sysfs file
  * (for sap mode only)
  * @adapter: hdd adapter
  *

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_scan_config.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -38,8 +39,8 @@
 int hdd_sysfs_scan_config_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_scan_config_destroy() -
- *   API to destroy scan_config sysfs file
+ * hdd_sysfs_scan_config_destroy() - API to destroy scan_config sysfs file
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 2 - 0
core/hdd/src/wlan_hdd_sysfs_scan_disable.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -41,6 +42,7 @@ int hdd_sysfs_scan_disable_create(struct kobject *driver_kobject);
 
 /**
  * hdd_sysfs_scan_disable_destroy() - API to destroy scan_disable
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_thermal_cfg.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -39,8 +40,8 @@
 int hdd_sysfs_thermal_cfg_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_thermal_cfg_destroy() -
- *   API to destroy thermal_cfg
+ * hdd_sysfs_thermal_cfg_destroy() - API to destroy thermal_cfg
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 2 - 1
core/hdd/src/wlan_hdd_sysfs_txrx_fw_st_rst.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_TXRX_FW_ST_RST)
 /**
- * wlan_hdd_sysfs_txrx_fw_st_rst_create() - API to create txrx_fw_st_rst
+ * hdd_sysfs_txrx_fw_st_rst_create() - API to create txrx_fw_st_rst
  * @adapter: hdd adapter
  *
  * this file is created per adapter.

+ 2 - 1
core/hdd/src/wlan_hdd_sysfs_txrx_fw_stats.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_TXRX_FW_STATS)
 /**
- * wlan_hdd_sysfs_txrx_fw_stats_create() - API to create txrx_fw_stats
+ * hdd_sysfs_txrx_fw_stats_create() - API to create txrx_fw_stats
  * @adapter: hdd adapter
  *
  * this file is created per adapter.

+ 3 - 3
core/hdd/src/wlan_hdd_sysfs_txrx_stats.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -25,7 +26,7 @@
 
 #if defined(WLAN_SYSFS) && defined(CONFIG_WLAN_TXRX_STATS)
 /**
- * wlan_hdd_sysfs_txrx_stats_create() - API to create txrx_stats
+ * hdd_sysfs_txrx_stats_create() - API to create txrx_stats
  * @adapter: hdd adapter
  *
  * this file is created per adapter.
@@ -39,8 +40,7 @@
 int hdd_sysfs_txrx_stats_create(struct hdd_adapter *adapter);
 
 /**
- * hdd_sysfs_txrx_stats_destroy() -
- *   API to destroy txrx_stats
+ * hdd_sysfs_txrx_stats_destroy() - API to destroy txrx_stats
  * @adapter: pointer to adapter
  *
  * Return: none

+ 2 - 0
core/hdd/src/wlan_hdd_sysfs_wlan_dbg.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -39,6 +40,7 @@ int hdd_sysfs_wlan_dbg_create(struct kobject *driver_kobject);
 
 /**
  * hdd_sysfs_wlan_dbg_destroy() - API to destroy wlan_dbg sysfs file
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 3 - 2
core/hdd/src/wlan_hdd_sysfs_wow_ito.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -40,8 +41,8 @@
 int hdd_sysfs_wow_ito_create(struct kobject *driver_kobject);
 
 /**
- * hdd_sysfs_wow_ito_destroy() -
- *   API to destroy wow_ito
+ * hdd_sysfs_wow_ito_destroy() - API to destroy wow_ito
+ * @driver_kobject: sysfs driver kobject
  *
  * Return: none
  */

+ 3 - 15
core/hdd/src/wlan_hdd_tdls.c

@@ -316,7 +316,7 @@ int wlan_hdd_cfg80211_exttdls_get_status(struct wiphy *wiphy,
 /**
  * __wlan_hdd_cfg80211_exttdls_enable() - enable an externally controllable
  *                                      TDLS peer and set parameters
- * wiphy: wiphy
+ * @wiphy: pointer to wireless wiphy structure.
  * @wdev: wireless dev pointer
  * @data: netlink buffer with peer MAC address and configuration parameters
  * @data_len: size of data in bytes
@@ -367,7 +367,7 @@ int wlan_hdd_cfg80211_exttdls_enable(struct wiphy *wiphy,
 /**
  * __wlan_hdd_cfg80211_exttdls_disable() - disable an externally controllable
  *                                       TDLS peer
- * wiphy: wiphy
+ * @wiphy: wiphy
  * @wdev: wireless dev pointer
  * @data: netlink buffer with peer MAC address
  * @data_len: size of data in bytes
@@ -435,19 +435,6 @@ static int __wlan_hdd_cfg80211_tdls_mgmt(struct wiphy *wiphy,
 				u16 status_code, u32 peer_capability,
 				const u8 *buf, size_t len)
 #else
-/**
- * __wlan_hdd_cfg80211_tdls_mgmt() - handle management actions on a given peer
- * @wiphy: wiphy
- * @dev: net device
- * @peer: MAC address of the TDLS peer
- * @action_code: action code
- * @dialog_token: dialog token
- * @status_code: status code
- * @buf: additional IE to include
- * @len: length of buf in bytes
- *
- * Return: 0 if success; negative errno otherwise
- */
 #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 17, 0))
 static int __wlan_hdd_cfg80211_tdls_mgmt(struct wiphy *wiphy,
 				struct net_device *dev, const uint8_t *peer,
@@ -929,6 +916,7 @@ int hdd_set_tdls_scan_type(struct hdd_context *hdd_ctx, int val)
  * antenna mode in standalone station
  * @hdd_ctx: Pointer to hdd context
  * @adapter: Pointer to hdd adapter
+ * @mode: enum antenna_mode
  *
  * Return: 0 if success else non zero
  */

+ 14 - 13
core/hdd/src/wlan_hdd_thermal.h

@@ -30,19 +30,20 @@
 
 
 /**
- * enum hdd_thermal_states   - The various thermal states as supported by WLAN
- * @HDD_THERMAL_STATE_NONE   - The normal working state
- * @HDD_THERMAL_STATE_LIGHT  - Intermediate states, WLAN must perform partial
- *                             mitigation
- * @HDD_THERMAL_STATE_MODERATE - Intermediate states, WLAN must perform partial
- *                               mitigation
- * @HDD_THERMAL_STATE_SEVERE - Intermediate states, WLAN must perform partial
- *                             mitigation
- * @HDD_THERMAL_STATE_CRITICAL - Intermediate states, WLAN must perform partial
- *                               mitigation
- * @HDD_THERMAL_STATE_EMERGENCY - The highest state, WLAN must enter forced
- *                                IMPS and will disconnect any active STA
- *                                connection
+ * enum hdd_thermal_states - The various thermal states as supported by WLAN
+ * @HDD_THERMAL_STATE_NONE: The normal working state
+ * @HDD_THERMAL_STATE_LIGHT: Intermediate states, WLAN must perform partial
+ *                           mitigation
+ * @HDD_THERMAL_STATE_MODERATE: Intermediate states, WLAN must perform partial
+ *                              mitigation
+ * @HDD_THERMAL_STATE_SEVERE: Intermediate states, WLAN must perform partial
+ *                            mitigation
+ * @HDD_THERMAL_STATE_CRITICAL: Intermediate states, WLAN must perform partial
+ *                              mitigation
+ * @HDD_THERMAL_STATE_EMERGENCY: The highest state, WLAN must enter forced
+ *                               IMPS and will disconnect any active STA
+ *                               connection
+ * @HDD_THERMAL_STATE_INVAL: Placeholder for invalid/unknown state
  */
 enum hdd_thermal_states {
 	HDD_THERMAL_STATE_NONE = 0,

+ 8 - 11
core/hdd/src/wlan_hdd_tsf.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * wlan_hdd_tsf.c - WLAN Host Device Driver tsf related implementation
+ * DOC: wlan_hdd_tsf.c - WLAN Host Device Driver tsf related implementation
  */
 
 #include "osif_sync.h"
@@ -94,9 +94,8 @@ struct hdd_tsf_report {
 
 /**
  * enum hdd_tsf_op_result - result of tsf operation
- *
- * HDD_TSF_OP_SUCC:  succeed
- * HDD_TSF_OP_FAIL:  fail
+ * @HDD_TSF_OP_SUCC:  succeed
+ * @HDD_TSF_OP_FAIL:  fail
  */
 enum hdd_tsf_op_result {
 	HDD_TSF_OP_SUCC,
@@ -853,12 +852,10 @@ static enum hdd_tsf_op_result hdd_indicate_tsf_internal(
 #define CAP_TSF_TIMER_FIX_SEC 1
 
 /**
- * TS_STATUS - timestamp status
- *
- * HDD_TS_STATUS_WAITING:  one of the stamp-pair
- *    is not updated
- * HDD_TS_STATUS_READY:  valid tstamp-pair
- * HDD_TS_STATUS_INVALID: invalid tstamp-pair
+ * enum hdd_ts_status - timestamp status
+ * @HDD_TS_STATUS_WAITING:  one of the stamp-pair is not updated
+ * @HDD_TS_STATUS_READY:  valid tstamp-pair
+ * @HDD_TS_STATUS_INVALID: invalid tstamp-pair
  */
 enum hdd_ts_status {
 	HDD_TS_STATUS_WAITING,
@@ -2378,7 +2375,7 @@ enum hdd_tsf_op_result hdd_netbuf_timestamp(qdf_nbuf_t netbuf,
 
 /**
  * hdd_tx_timestamp() - time stamp TX netbuf
- *
+ * @status: TX status
  * @netbuf: pointer to a TX netbuf
  * @target_time: TX time for the netbuf
  *

+ 10 - 9
core/hdd/src/wlan_hdd_twt.c

@@ -18,7 +18,7 @@
  */
 
 /**
- * DOC : wlan_hdd_twt.c
+ * DOC: wlan_hdd_twt.c
  *
  * WLAN Host Device Driver file for TWT (Target Wake Time) support.
  *
@@ -169,6 +169,7 @@ void wlan_hdd_twt_init(struct hdd_context *hdd_ctx)
  * operation in the received vendor command and
  * send it to firmware
  * @adapter: adapter pointer
+ * @vdev: associated vdev object
  * @twt_param_attr: nl attributes
  *
  * Handles QCA_WLAN_TWT_TERMINATE
@@ -712,7 +713,7 @@ QDF_STATUS hdd_twt_check_all_twt_support(struct wlan_objmgr_psoc *psoc,
 /**
  * hdd_twt_get_params_resp_len() - Calculates the length
  * of twt get_params nl response
- * @params twt session stats parameters
+ * @params: twt session stats parameters
  *
  * Return: Length of get params nl response
  */
@@ -1036,6 +1037,7 @@ static int hdd_is_twt_command_allowed(struct hdd_adapter *adapter)
 /**
  * hdd_send_inactive_session_reply  -  Send session state as inactive for
  * dialog ID for which setup is not done.
+ * @adapter: hdd_adapter
  * @params: TWT session parameters
  *
  * Return: QDF_STATUS
@@ -1431,7 +1433,7 @@ wmi_twt_nudge_status_to_vendor_twt_status(enum WMI_HOST_NUDGE_TWT_STATUS status)
 /**
  * wmi_twt_add_cmd_to_vendor_twt_resp_type() - convert from
  * WMI_HOST_TWT_COMMAND to qca_wlan_vendor_twt_setup_resp_type
- * @status: WMI_HOST_TWT_COMMAND value from firmware
+ * @type: WMI_HOST_TWT_COMMAND value from firmware
  *
  * Return: qca_wlan_vendor_twt_setup_resp_type values for valid
  * WMI_HOST_TWT_COMMAND value and -EINVAL for invalid value
@@ -1733,7 +1735,7 @@ hdd_twt_setup_pack_resp_nlmsg(struct sk_buff *reply_skb,
 
 /**
  * hdd_send_twt_setup_response  - Send TWT setup response to userspace
- * @hdd_adapter: Pointer to HDD adapter. This pointer is expected to
+ * @adapter: Pointer to HDD adapter. This pointer is expected to
  * be validated by the caller.
  * @add_dialog_comp_ev_params: Add dialog completion event structure
  *
@@ -3362,7 +3364,6 @@ hdd_twt_resume_pack_resp_nlmsg(struct sk_buff *reply_skb,
  * hdd_twt_resume_dialog_comp_cb() - callback function
  * to get twt resume command complete event
  * @psoc: Pointer to global psoc
- * @vdev_id: Vdev id
  * @params: Pointer to resume dialog complete event buffer
  *
  * Return: None
@@ -3771,7 +3772,7 @@ wmi_twt_get_stats_status_to_vendor_twt_status(enum WMI_HOST_GET_STATS_TWT_STATUS
 
 /**
  * hdd_twt_pack_get_stats_resp_nlmsg()- Packs and sends twt get stats response
- * hdd_ctx: pointer to the hdd context
+ * @hdd_ctx: pointer to the hdd context
  * @reply_skb: pointer to response skb buffer
  * @params: Pointer to twt session parameter buffer
  * @num_session_stats: number of twt statistics
@@ -3976,8 +3977,8 @@ static int hdd_twt_clear_session_traffic_stats(struct hdd_adapter *adapter,
 }
 
 /**
- * hdd_twt_get_session_traffic_stats() - Obtains twt session traffic statistics
- * and sends response to the user space
+ * hdd_twt_request_session_traffic_stats() - Obtains twt session
+ * traffic statistics and sends response to the user space
  * @adapter: hdd_adapter
  * @dialog_id: dialog id of the twt session
  * @peer_mac: Mac address of the peer
@@ -4041,7 +4042,7 @@ free_event:
 }
 
 /**
- * hdd_twt_get_session_stats() - Parses twt nl attrributes, obtains twt
+ * hdd_twt_get_session_traffic_stats() - Parses twt nl attributes, obtains twt
  * session parameters based on dialog_id and returns to user via nl layer
  * @adapter: hdd_adapter
  * @twt_param_attr: twt nl attributes

+ 4 - 2
core/hdd/src/wlan_hdd_tx_rx.c

@@ -910,11 +910,12 @@ static void wlan_hdd_update_unpause_time(struct hdd_adapter *adapter)
 /**
  * wlan_hdd_update_pause_time() - update pause time
  * @adapter: adapter handle
+ * @temp_map: pause map
  *
  * Return: none
  */
 static void wlan_hdd_update_pause_time(struct hdd_adapter *adapter,
-	 uint32_t temp_map)
+				       uint32_t temp_map)
 {
 	qdf_time_t curr_time = qdf_system_ticks();
 	uint8_t i;
@@ -953,7 +954,8 @@ wlan_hdd_dump_queue_history_state(struct hdd_netif_queue_history *queue_history,
 
 /**
  * wlan_hdd_update_queue_history_state() - Save a copy of dev TX queues state
- * @adapter: adapter handle
+ * @dev: interface netdev
+ * @q_hist: adapter queue history
  *
  * Save netdev TX queues state into adapter queue history.
  *

+ 1 - 1
core/hdd/src/wlan_hdd_wds.h

@@ -17,7 +17,7 @@
  */
 
 /**
- * DOC : wlan_hdd_wds.h
+ * DOC: wlan_hdd_wds.h
  *
  * WLAN Host Device Driver file for wds (4 address format in mac header when
  * SA and TA are not same) support.

+ 137 - 15
core/hdd/src/wlan_hdd_wext.c

@@ -2988,7 +2988,7 @@ static int hdd_we_dump_stats(struct hdd_adapter *adapter, int value)
 }
 
 /**
- * iw_get_linkspeed() - Get current link speed ioctl
+ * __iw_get_linkspeed() - Get current link speed ioctl
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -3037,6 +3037,15 @@ static int __iw_get_linkspeed(struct net_device *dev,
 	return 0;
 }
 
+/**
+ * iw_get_linkspeed() - Get current link speed ioctl
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: extra ioctl buffer
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_get_linkspeed(struct net_device *dev,
 			    struct iw_request_info *info,
 			    union iwreq_data *wrqu, char *extra)
@@ -4799,7 +4808,7 @@ static setint_getnone_fn hdd_get_setint_getnone_cb(int param)
 }
 
 /**
- * iw_setint_getnone() - Generic "set integer" private ioctl handler
+ * __iw_setint_getnone() - Generic "set integer" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -4843,6 +4852,15 @@ static int __iw_setint_getnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_setint_getnone() - Generic "set integer" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_setint_getnone(struct net_device *dev,
 			     struct iw_request_info *info,
 			     union iwreq_data *wrqu,
@@ -4935,8 +4953,9 @@ static int iw_setnone_get_threeint(struct net_device *dev,
 
 	return errno;
 }
+
 /**
- * iw_setchar_getnone() - Generic "set string" private ioctl handler
+ * __iw_setchar_getnone() - Generic "set string" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -5076,6 +5095,15 @@ static int __iw_setchar_getnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_setchar_getnone() - Generic "set string" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_setchar_getnone(struct net_device *dev,
 			      struct iw_request_info *info,
 			      union iwreq_data *wrqu, char *extra)
@@ -5095,7 +5123,7 @@ static int iw_setchar_getnone(struct net_device *dev,
 }
 
 /**
- * iw_setnone_getint() - Generic "get integer" private ioctl handler
+ * __iw_setnone_getint() - Generic "get integer" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -5586,6 +5614,15 @@ static int __iw_setnone_getint(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_setnone_getint() - Generic "get integer" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_setnone_getint(struct net_device *dev,
 			     struct iw_request_info *info,
 			     union iwreq_data *wrqu, char *extra)
@@ -5645,7 +5682,7 @@ static int hdd_set_fwtest(int argc, int cmd, int value)
 }
 
 /**
- * iw_set_three_ints_getnone() - Generic "set 3 params" private ioctl handler
+ * __iw_set_three_ints_getnone() - Generic "set 3 params" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -5723,6 +5760,15 @@ static int __iw_set_three_ints_getnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_set_three_ints_getnone() - Generic "set 3 params" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 int iw_set_three_ints_getnone(struct net_device *dev,
 			      struct iw_request_info *info,
 			      union iwreq_data *wrqu, char *extra)
@@ -5823,7 +5869,7 @@ static int hdd_get_sta_cxn_info(struct hdd_context *hdd_ctx,
 #endif
 
 /**
- * iw_get_char_setnone() - Generic "get string" private ioctl handler
+ * __iw_get_char_setnone() - Generic "get string" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -6321,6 +6367,15 @@ static int __iw_get_char_setnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_get_char_setnone() - Generic "get string" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_get_char_setnone(struct net_device *dev,
 			       struct iw_request_info *info,
 			       union iwreq_data *wrqu, char *extra)
@@ -6340,7 +6395,7 @@ static int iw_get_char_setnone(struct net_device *dev,
 }
 
 /**
- * iw_setnone_getnone() - Generic "action" private ioctl handler
+ * __iw_setnone_getnone() - Generic "action" private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -6433,6 +6488,15 @@ static int __iw_setnone_getnone(struct net_device *dev,
 	return ret;
 }
 
+/**
+ * iw_setnone_getnone() - Generic "action" private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_setnone_getnone(struct net_device *dev,
 			      struct iw_request_info *info,
 			      union iwreq_data *wrqu, char *extra)
@@ -6900,7 +6964,7 @@ static int __iw_set_var_ints_getnone(struct net_device *dev,
  * @dev: pointer to net_device structure
  * @info: pointer to iw_request_info structure
  * @wrqu: pointer to iwreq_data
- * @extra; extra
+ * @extra: extra
  *
  * Return: 0 on success, error number otherwise
  *
@@ -6982,7 +7046,7 @@ int iw_set_var_ints_getnone(struct net_device *dev,
 }
 
 /**
- * iw_add_tspec - Add TSpec private ioctl handler
+ * __iw_add_tspec - Add TSpec private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7144,6 +7208,15 @@ static int __iw_add_tspec(struct net_device *dev, struct iw_request_info *info,
 	return 0;
 }
 
+/**
+ * iw_add_tspec - Add TSpec private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_add_tspec(struct net_device *dev,
 			struct iw_request_info *info,
 			union iwreq_data *wrqu, char *extra)
@@ -7163,7 +7236,7 @@ static int iw_add_tspec(struct net_device *dev,
 }
 
 /**
- * iw_del_tspec - Delete TSpec private ioctl handler
+ * __iw_del_tspec - Delete TSpec private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7216,6 +7289,15 @@ static int __iw_del_tspec(struct net_device *dev, struct iw_request_info *info,
 	return 0;
 }
 
+/**
+ * iw_del_tspec - Delete TSpec private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_del_tspec(struct net_device *dev,
 			struct iw_request_info *info,
 			union iwreq_data *wrqu, char *extra)
@@ -7235,7 +7317,7 @@ static int iw_del_tspec(struct net_device *dev,
 }
 
 /**
- * iw_get_tspec - Get TSpec private ioctl handler
+ * __iw_get_tspec - Get TSpec private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7281,6 +7363,15 @@ static int __iw_get_tspec(struct net_device *dev, struct iw_request_info *info,
 	return 0;
 }
 
+/**
+ * iw_get_tspec - Get TSpec private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_get_tspec(struct net_device *dev,
 			struct iw_request_info *info,
 			union iwreq_data *wrqu, char *extra)
@@ -7300,7 +7391,7 @@ static int iw_get_tspec(struct net_device *dev,
 }
 
 /**
- * iw_set_fties - Set FT IEs private ioctl handler
+ * __iw_set_fties - Set FT IEs private ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7353,6 +7444,19 @@ static int __iw_set_fties(struct net_device *dev, struct iw_request_info *info,
 	return 0;
 }
 
+/**
+ * iw_set_fties - Set FT IEs private ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Each time the supplicant has the auth_request or reassoc request
+ * IEs ready they are pushed to the driver. The driver will in turn
+ * use it to send out the auth req and reassoc req for 11r FT Assoc.
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_set_fties(struct net_device *dev,
 			struct iw_request_info *info,
 			union iwreq_data *wrqu, char *extra)
@@ -7400,7 +7504,7 @@ static int iw_set_dynamic_mcbc_filter(struct net_device *dev,
 }
 
 /**
- * iw_set_host_offload - Set host offload ioctl handler
+ * __iw_set_host_offload - Set host offload ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7484,6 +7588,15 @@ static int __iw_set_host_offload(struct net_device *dev,
 	return 0;
 }
 
+/**
+ * iw_set_host_offload - Set host offload ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_set_host_offload(struct net_device *dev,
 			       struct iw_request_info *info,
 			       union iwreq_data *wrqu, char *extra)
@@ -7503,7 +7616,7 @@ static int iw_set_host_offload(struct net_device *dev,
 }
 
 /**
- * iw_set_keepalive_params - Set keepalive params ioctl handler
+ * __iw_set_keepalive_params - Set keepalive params ioctl handler
  * @dev: device upon which the ioctl was received
  * @info: ioctl request information
  * @wrqu: ioctl request data
@@ -7580,6 +7693,15 @@ static int __iw_set_keepalive_params(struct net_device *dev,
 	return 0;
 }
 
+/**
+ * iw_set_keepalive_params - Set keepalive params ioctl handler
+ * @dev: device upon which the ioctl was received
+ * @info: ioctl request information
+ * @wrqu: ioctl request data
+ * @extra: ioctl extra data
+ *
+ * Return: 0 on success, non-zero on error
+ */
 static int iw_set_keepalive_params(struct net_device *dev,
 				   struct iw_request_info *info,
 				   union iwreq_data *wrqu,
@@ -7602,8 +7724,8 @@ static int iw_set_keepalive_params(struct net_device *dev,
 #ifdef WLAN_FEATURE_PACKET_FILTERING
 /**
  * validate_packet_filter_params_size() - Validate the size of the params rcvd
- * @priv_data: Pointer to the priv data from user space
  * @request: Pointer to the struct containing the copied data from user space
+ * @length: length of the request
  *
  * Return: False on invalid length, true otherwise
  */

+ 3 - 7
core/hdd/src/wlan_hdd_wmm.c

@@ -135,10 +135,6 @@ config_tspec_policy[QCA_WLAN_VENDOR_ATTR_CONFIG_TSPEC_MAX + 1] = {
 	[CONFIG_TSPEC_SURPLUS_BANDWIDTH_ALLOWANCE] = {.type = NLA_U16},
 };
 
-/**
- * enum hdd_wmm_linuxac: AC/Queue Index values for Linux Qdisc to
- * operate on different traffic.
- */
 #ifdef QCA_LL_TX_FLOW_CONTROL_V2
 void wlan_hdd_process_peer_unauthorised_pause(struct hdd_adapter *adapter)
 {
@@ -334,9 +330,9 @@ static void hdd_wmm_free_context(struct hdd_wmm_qos_context *qos_context)
  *
  * Return: None
  */
-#define MAX_NOTIFY_LEN 50
 static void hdd_wmm_notify_app(struct hdd_wmm_qos_context *qos_context)
 {
+#define MAX_NOTIFY_LEN 50
 	struct hdd_adapter *adapter;
 	union iwreq_data wrqu;
 	char buf[MAX_NOTIFY_LEN + 1];
@@ -1728,7 +1724,7 @@ QDF_STATUS hdd_wmm_adapter_clear(struct hdd_adapter *adapter)
 }
 
 /**
- * hdd_wmm_close() - WMM close function
+ * hdd_wmm_adapter_close() - WMM close function
  * @adapter: [in]  pointer to adapter context
  *
  * Function which will perform any necessary work to to clean up the
@@ -1849,7 +1845,7 @@ hdd_check_and_upgrade_udp_qos(struct hdd_adapter *adapter,
  * these critical packets. This is done as skb->cb amay be overwritten between
  * _select_queue and_hard_start_xmit functions. hdd_wmm_classify_critical_pkt
  * and wlan_hdd_mark_critical_pkt should be in sync w.r.t packet types.
-
+ *
  * Return: None
  */
 static

+ 2 - 2
core/hdd/src/wlan_hdd_wowl.c

@@ -18,9 +18,9 @@
  */
 
 /**
- * @file wlan_hdd_wowl.c
+ * DOC: wlan_hdd_wowl.c
  *
- * @brief wake up on WLAN API file
+ * wake up on WLAN API file
  */
 
 /* Include Files */