samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: dp: remove debug log output in isr

Browse Source 
Remove all debug logs and replace them with event logs in the isr
path. This change will reduce the likelihood of an interrupt storm
causing a watchdog bark if display threads are being prevented
from completing execution due to debug logs holding the console
lock.

CRs-Fixed: 2810115
Change-Id: I906f19fb73a7501114fd0a62e9ae66c83dde4d5d
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
This commit is contained in:
Tatenda Chipeperekwa
2020-11-23 15:48:50 -08:00
committed by Gerrit - the friendly Code Review server
parent 13c448e20f
commit c90f535a24
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
msm/dp/dp_ctrl.c
View File

@@ -10,6 +10,7 @@
#include "dp_ctrl.h"
#include "dp_debug.h"
#include "sde_dbg.h"
#define DP_MST_DEBUG(fmt, ...) DP_DEBUG(fmt, ##__VA_ARGS__)
@@ -93,13 +94,11 @@ enum notification_status {
static void dp_ctrl_idle_patterns_sent(struct dp_ctrl_private *ctrl)
{
DP_DEBUG("idle_patterns_sent\n");
complete(&ctrl->idle_comp);
}
static void dp_ctrl_video_ready(struct dp_ctrl_private *ctrl)
{
DP_DEBUG("dp_video_ready\n");
complete(&ctrl->video_comp);
}
@@ -185,6 +184,8 @@ static void dp_ctrl_wait4video_ready(struct dp_ctrl_private *ctrl)
{
if (!wait_for_completion_timeout(&ctrl->video_comp, HZ / 2))
DP_WARN("SEND_VIDEO time out\n");
else
DP_DEBUG("SEND_VIDEO triggered\n");
}
static int dp_ctrl_update_sink_vx_px(struct dp_ctrl_private *ctrl)
@@ -1410,12 +1411,14 @@ static void dp_ctrl_isr(struct dp_ctrl *dp_ctrl)
{
struct dp_ctrl_private *ctrl;
SDE_EVT32_EXTERNAL(SDE_EVTLOG_FUNC_ENTRY);
if (!dp_ctrl)
return;
ctrl = container_of(dp_ctrl, struct dp_ctrl_private, dp_ctrl);
ctrl->catalog->get_interrupt(ctrl->catalog);
SDE_EVT32_EXTERNAL(ctrl->catalog->isr);
if (ctrl->catalog->isr & DP_CTRL_INTR_READY_FOR_VIDEO)
dp_ctrl_video_ready(ctrl);
@@ -1428,6 +1431,7 @@ static void dp_ctrl_isr(struct dp_ctrl *dp_ctrl)
if (ctrl->catalog->isr5 & DP_CTRL_INTR_MST_DP1_VCPF_SENT)
dp_ctrl_idle_patterns_sent(ctrl);
SDE_EVT32_EXTERNAL(SDE_EVTLOG_FUNC_EXIT);
}
void dp_ctrl_set_sim_mode(struct dp_ctrl *dp_ctrl, bool en)