samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Null check while calling md_host_evt_cb

Browse Source 
wma_motion_det_host_event_handler() get called when FW sent
WMI_MOTION_DET_HOST_EVENTID message.
After the initial processing, pmac->sme.md_host_evt_cb() is
called to send the relevant data back up to the upper layers
of WLAN.
Since this callback function is dynamically registered there
are cases where it might not be registered before this FW event
is received, resulting in a NULL pointer dereference.

Change-Id: I06b7907b39f4da0837196ccf377ecc2da325be8c
CRs-Fixed: 2428803
This commit is contained in:
Harprit Chhabada
2019-04-09 11:39:22 -07:00
committed by nshrivas
parent e2b469f61f
commit c67478f0d7
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/wma/src/wma_main.c
View File

@@ -8018,6 +8018,11 @@ int wma_motion_det_host_event_handler(void *handle, uint8_t *event,
return -EINVAL; return -EINVAL;
} }
if (!pmac || !pmac->sme.md_host_evt_cb) {
WMA_LOGE("Invalid motion detect callback");
return -EINVAL;
}
motion_det_event_hdr = param_buf->fixed_param; motion_det_event_hdr = param_buf->fixed_param;
WMA_LOGA("motion detect host event received, vdev_id=%d, status=%d", WMA_LOGA("motion detect host event received, vdev_id=%d, status=%d",
motion_det_event_hdr->vdev_id, motion_det_event_hdr->status); motion_det_event_hdr->vdev_id, motion_det_event_hdr->status);