From c4db9c63b8e1c2725134c2f5af575a0baa5c2109 Mon Sep 17 00:00:00 2001 From: Jinwei Chen Date: Sun, 5 Feb 2023 21:57:22 -0800 Subject: [PATCH] qcacmn: remove raw mpdu check in dp_rx_reo_err_entry_process Raw mpdu check in dp_rx_reo_err_entry_process() is introduced from change "Free the raw mode mpdus in REO error ring", it is fixing the low memory issue during MLO STA T-put test which reports REO error code 0 - HAL_REO_ERR_QUEUE_DESC_ADDR_0 frequently. this introduce regression for SAP certification case 4.3.3.1. it seems REO error 0 is hard and not expected to be reproduced during MLO STA T-put test, remove the raw mpdu check in dp_rx_reo_err_entry_process() to not block SAP certification. Change-Id: I509e80eb38d57f20b24c32ba1da2ad7132358030 CRs-Fixed: 3387453 --- dp/wifi3.0/dp_rx_err.c | 8 -------- dp/wifi3.0/dp_stats.c | 7 ------- dp/wifi3.0/dp_types.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/dp/wifi3.0/dp_rx_err.c b/dp/wifi3.0/dp_rx_err.c index 8f8fc6eb1b..e302139691 100644 --- a/dp/wifi3.0/dp_rx_err.c +++ b/dp/wifi3.0/dp_rx_err.c @@ -1556,14 +1556,6 @@ more_msdu_link_desc: err_code); } - if (qdf_unlikely(mpdu_desc_info->mpdu_flags & - HAL_MPDU_F_RAW_AMPDU)) { - dp_err_rl("RAW ampdu in REO error not expected"); - DP_STATS_INC(soc, rx.err.reo_err_raw_mpdu_drop, 1); - qdf_nbuf_list_free(head_nbuf); - goto process_next_msdu; - } - rx_tlv_hdr_first = qdf_nbuf_data(head_nbuf); rx_tlv_hdr_last = qdf_nbuf_data(tail_nbuf); diff --git a/dp/wifi3.0/dp_stats.c b/dp/wifi3.0/dp_stats.c index 918fbd78de..a015619329 100644 --- a/dp/wifi3.0/dp_stats.c +++ b/dp/wifi3.0/dp_stats.c @@ -7295,8 +7295,6 @@ void dp_txrx_path_stats(struct dp_soc *soc) pdev->soc->stats.rx.err.reo_err_oor_to_stack); DP_PRINT_STATS("REO err oor msdu drop: %u", pdev->soc->stats.rx.err.reo_err_oor_drop); - DP_PRINT_STATS("REO err raw mpdu drop: %u", - pdev->soc->stats.rx.err.reo_err_raw_mpdu_drop); DP_PRINT_STATS("Rx err msdu rejected: %d", soc->stats.rx.err.rejected); DP_PRINT_STATS("Rx raw frame dropped: %d", @@ -8031,9 +8029,6 @@ dp_print_soc_rx_stats(struct dp_soc *soc) DP_PRINT_STATS("REO err oor msdu drop: %d", soc->stats.rx.err.reo_err_oor_drop); - DP_PRINT_STATS("REO err raw ampdu drop: %d", - soc->stats.rx.err.reo_err_raw_mpdu_drop); - DP_PRINT_STATS("Rx err msdu rejected: %d", soc->stats.rx.err.rejected); @@ -9038,8 +9033,6 @@ QDF_STATUS dp_txrx_get_soc_stats(struct cdp_soc_t *soc_hdl, soc->stats.rx.err.reo_err_msdu_buf_invalid_cookie; soc_stats->rx.err.rx_hw_err_oor_drop = soc->stats.rx.err.reo_err_oor_drop; - soc_stats->rx.err.rx_hw_err_raw_mpdu_drop = - soc->stats.rx.err.reo_err_raw_mpdu_drop; soc_stats->rx.err.rx_hw_err_oor_to_stack = soc->stats.rx.err.reo_err_oor_to_stack; soc_stats->rx.err.rx_hw_err_oor_sg_count = diff --git a/dp/wifi3.0/dp_types.h b/dp/wifi3.0/dp_types.h index 874e6810ae..8ccc0b05a1 100644 --- a/dp/wifi3.0/dp_types.h +++ b/dp/wifi3.0/dp_types.h @@ -1313,8 +1313,6 @@ struct dp_soc_stats { uint32_t reo_err_oor_to_stack; /* REO OOR scattered msdu count */ uint32_t reo_err_oor_sg_count; - /* REO ERR RAW mpdu drops */ - uint32_t reo_err_raw_mpdu_drop; /* RX msdu rejected count on delivery to vdev stack_fn*/ uint32_t rejected; /* Incorrect msdu count in MPDU desc info */