qcacld-3.0: Fix error handling in peer creation

Return error instead of QDF_BUG(0) in ol_txrx_peer_attach() when it
times out on duplicate peer detection. Peer unmap events from firmware
may take more than 500 ms timeout observed by this routine.
wma_create_peer() should return error status on failure to create peer.

CRs-Fixed: 2004665
Change-Id: I8368c6320139f97584bd1647f1806a695d4a5929

core/dp/txrx/ol_txrx.c

@@ -2455,8 +2455,14 @@ ol_txrx_peer_attach(struct cdp_vdev *pvdev, uint8_t *peer_mac_addr)
 			if (cds_is_self_recovery_enabled())
 				cds_trigger_recovery(false);
 			else
-				/* Added for debugging only */
-				QDF_BUG(0);
+
+				/*
+				 * Add equivalent of following line when it
+				 * becomes available.
+				 * wma_peer_debug_dump();
+				 */
+				QDF_ASSERT(0);
+
 			vdev->wait_on_peer_id = OL_TXRX_INVALID_LOCAL_PEER_ID;
 			return NULL;
 		}