Ver Fonte

qcacmn: Fix camelCase issues with DHCP Offload

Both the unified DHCP offload struct dhcp_offload_info_params and all
of the function prototypes use "camelCase" which is frowned upon by
the Linux Coding Style. Replace the camelCase.

Change-Id: I3f2ce74bc150668b96b1946ef7b2d556c23dad94
CRs-Fixed: 2121485
Jeff Johnson há 7 anos atrás
pai
commit
bcb1eefaf6

+ 1 - 1
wmi/inc/wmi_unified_api.h

@@ -801,7 +801,7 @@ QDF_STATUS wmi_unified_nan_req_cmd(void *wmi_hdl,
 			struct nan_req_params *nan_req);
 
 QDF_STATUS wmi_unified_process_dhcpserver_offload_cmd(void *wmi_hdl,
-				struct dhcp_offload_info_params *pDhcpSrvOffloadInfo);
+				struct dhcp_offload_info_params *params);
 
 QDF_STATUS wmi_unified_process_ch_avoid_update_cmd(void *wmi_hdl);
 

+ 6 - 6
wmi/inc/wmi_unified_param.h

@@ -3121,15 +3121,15 @@ struct tdls_channel_switch_params {
 /**
  * struct dhcp_offload_info_params - dhcp offload parameters
  * @vdev_id: request data length
- * @dhcpSrvOffloadEnabled: dhcp offload enabled
- * @dhcpClientNum: dhcp client no
- * @dhcpSrvIP: dhcp server ip
+ * @dhcp_offload_enabled: dhcp offload enabled
+ * @dhcp_client_num: dhcp client no
+ * @dhcp_srv_addr: dhcp server ip
  */
 struct dhcp_offload_info_params {
 	uint32_t vdev_id;
-	uint32_t dhcpSrvOffloadEnabled;
-	uint32_t dhcpClientNum;
-	uint32_t dhcpSrvIP;
+	bool dhcp_offload_enabled;
+	uint32_t dhcp_client_num;
+	uint32_t dhcp_srv_addr;
 };
 
 /**

+ 1 - 1
wmi/inc/wmi_unified_priv.h

@@ -654,7 +654,7 @@ QDF_STATUS (*send_nan_req_cmd)(wmi_unified_t wmi_handle,
 			struct nan_req_params *nan_req);
 
 QDF_STATUS (*send_process_dhcpserver_offload_cmd)(wmi_unified_t wmi_handle,
-				struct dhcp_offload_info_params *pDhcpSrvOffloadInfo);
+				struct dhcp_offload_info_params *params);
 
 QDF_STATUS (*send_process_ch_avoid_update_cmd)(wmi_unified_t wmi_handle);
 

+ 2 - 2
wmi/src/wmi_unified_api.c

@@ -2594,13 +2594,13 @@ QDF_STATUS wmi_unified_nan_req_cmd(void *wmi_hdl,
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS wmi_unified_process_dhcpserver_offload_cmd(void *wmi_hdl,
-				struct dhcp_offload_info_params *pDhcpSrvOffloadInfo)
+				struct dhcp_offload_info_params *params)
 {
 	wmi_unified_t wmi_handle = (wmi_unified_t) wmi_hdl;
 
 	if (wmi_handle->ops->send_process_dhcpserver_offload_cmd)
 		return wmi_handle->ops->send_process_dhcpserver_offload_cmd(wmi_handle,
-			    pDhcpSrvOffloadInfo);
+			    params);
 
 	return QDF_STATUS_E_FAILURE;
 }

+ 9 - 9
wmi/src/wmi_unified_tlv.c

@@ -9670,12 +9670,13 @@ static QDF_STATUS send_nan_req_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_process_dhcpserver_offload_cmd_tlv() - enable DHCP server offload
  * @wmi_handle: wmi handle
- * @pDhcpSrvOffloadInfo: DHCP server offload info
+ * @params: DHCP server offload info
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
-static QDF_STATUS send_process_dhcpserver_offload_cmd_tlv(wmi_unified_t wmi_handle,
-		struct dhcp_offload_info_params *pDhcpSrvOffloadInfo)
+static QDF_STATUS
+send_process_dhcpserver_offload_cmd_tlv(wmi_unified_t wmi_handle,
+					struct dhcp_offload_info_params *params)
 {
 	wmi_set_dhcp_server_offload_cmd_fixed_param *cmd;
 	wmi_buf_t buf;
@@ -9689,16 +9690,15 @@ static QDF_STATUS send_process_dhcpserver_offload_cmd_tlv(wmi_unified_t wmi_hand
 	}
 
 	cmd = (wmi_set_dhcp_server_offload_cmd_fixed_param *) wmi_buf_data(buf);
-	qdf_mem_zero(cmd, sizeof(*cmd));
 
 	WMITLV_SET_HDR(&cmd->tlv_header,
 	       WMITLV_TAG_STRUC_wmi_set_dhcp_server_offload_cmd_fixed_param,
 	       WMITLV_GET_STRUCT_TLVLEN
 	       (wmi_set_dhcp_server_offload_cmd_fixed_param));
-	cmd->vdev_id = pDhcpSrvOffloadInfo->vdev_id;
-	cmd->enable = pDhcpSrvOffloadInfo->dhcpSrvOffloadEnabled;
-	cmd->num_client = pDhcpSrvOffloadInfo->dhcpClientNum;
-	cmd->srv_ipv4 = pDhcpSrvOffloadInfo->dhcpSrvIP;
+	cmd->vdev_id = params->vdev_id;
+	cmd->enable = params->dhcp_offload_enabled;
+	cmd->num_client = params->dhcp_client_num;
+	cmd->srv_ipv4 = params->dhcp_srv_addr;
 	cmd->start_lsb = 0;
 	status = wmi_unified_cmd_send(wmi_handle, buf,
 				   sizeof(*cmd),
@@ -9709,7 +9709,7 @@ static QDF_STATUS send_process_dhcpserver_offload_cmd_tlv(wmi_unified_t wmi_hand
 		return QDF_STATUS_E_FAILURE;
 	}
 	WMI_LOGD("Set dhcp server offload to vdevId %d",
-		 pDhcpSrvOffloadInfo->vdev_id);
+		 params->vdev_id);
 
 	return status;
 }