From dca59625e5af71e1eda08ee3b58983c978ce19c8 Mon Sep 17 00:00:00 2001 From: Amine Najahi Date: Mon, 17 May 2021 17:16:04 -0400 Subject: [PATCH] disp: msm: sde: add checks when retrieving blob feature data Add checks when retrieving CP blob feature data to avoid intermittent issue with pointer access. Change-Id: I3a3bd870bb6a5d7bb8d13188af8cc4b9bd06acc5 Signed-off-by: Amine Najahi --- msm/sde/sde_color_processing.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/msm/sde/sde_color_processing.c b/msm/sde/sde_color_processing.c index c93fe055cd..65148d10f2 100644 --- a/msm/sde/sde_color_processing.c +++ b/msm/sde/sde_color_processing.c @@ -1004,6 +1004,12 @@ static struct drm_property_blob *_sde_cp_get_crtc_feature_data(u32 feature, memset(hw_cfg, 0, sizeof(*hw_cfg)); *feature_enabled = false; + if (!property || !prop_node) { + DRM_ERROR("invalid feature:%d, property:%pK, prop_node:%pK\n", + feature, property, prop_node); + goto end; + } + if (property->flags & DRM_MODE_PROP_BLOB) { blob = drm_property_lookup_blob(crtc->base.dev, pstate->prop_val); @@ -1036,7 +1042,7 @@ static struct drm_property_blob *_sde_cp_get_crtc_feature_data(u32 feature, } else { DRM_ERROR("property type is not supported\n"); } - +end: return blob; }