samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Refine struct wmi_unified_pmk_cache (phase 1)

Browse Source 
The current definition of struct wmi_unified_pmk_cache has the
following anomalies:
1) It contains an unnecessary tlv_header field. Only the fw-api
   structs should contain TLV headers.
2) It contains a mis-named session_id field. Common structures should
   use converged terminology, in this case vdev_id

To fix the first issue just remove the tlv_header field since it isn't
used.  To fix the second issue takes a phased approach. For phase 1
replace the session_id field with an anonymous union which contains
both the existing session_id field and a new vdev_id field. Being part
of a union these field will overlay each other.

Subsequent phases will replace session_id references with vdev_id
references, and then remove the union, leaving just the vdev_id field.

Change-Id: If4be27111c604c16ea437aa654210cdff28220a7
CRs-Fixed: 2363430
This commit is contained in:
Jeff Johnson
2018-12-07 14:31:36 -08:00
committed by nshrivas
parent da15920d5b
commit b9f08212f6
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wmi/inc/wmi_unified_sta_param.h
View File

@@ -287,7 +287,7 @@ struct sar_limit_event {
/**
* struct wmi_unified_pmk_cache - used to set del pmkid cache
* @tlv_header: TLV header, TLV tag and len; tag equals WMITLV_TAG_ARRAY_UINT32
* @vdev_id: ID of the vdev being configured
* @pmk_len: PMK len
* for big-endian hosts, manual endian conversion will be needed to keep
* the array values in their original order in spite of the automatic
@@ -302,9 +302,11 @@ struct sar_limit_event {
* @action_flag: add/delete the entry
*/
struct wmi_unified_pmk_cache {
uint32_t tlv_header;
uint32_t pmk_len;
union {
uint8_t vdev_id;
uint8_t session_id;
};
uint32_t pmk_len;
uint8_t pmk[WMI_UNIFIED_MAX_PMK_LEN];
uint32_t pmkid_len;
uint8_t pmkid[WMI_UNIFIED_MAX_PMKID_LEN];