samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Fix SAP OWE roaming issue

Browse Source 
SAP fails to get RSN IE from reassoc request frame body.

Assoc request and reassoc request have different fixed parameters.
IE should be retrieved based on frame subtype.

Change-Id: I72cfc4cc28cdfeb9a35269d6c1a8c638dea87631
CRs-Fixed: 3283683
This commit is contained in:
Bing Sun
2022-09-06 10:05:46 +08:00
committed by Madan Koyyalamudi
parent b4669d07b2
commit b9a91ebcaa
2 changed files with 31 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
core/sap/src/sap_fsm.c
View File

@@ -61,6 +61,7 @@
#include "wlan_mlme_vdev_mgr_interface.h"
#include "wlan_vdev_mgr_utils_api.h"
#include "wlan_pre_cac_api.h"
#include <wlan_cmn_ieee80211.h>
/*----------------------------------------------------------------------------
* Preprocessor Definitions and Constants
@@ -1785,6 +1786,7 @@ static void sap_handle_acs_scan_event(struct sap_context *sap_context,
* Function to fill OWE IE in assoc indication
* @assoc_ind: SAP STA association indication
* @sme_assoc_ind: SME association indication
* @reassoc: True if it is reassoc frame
*
* This function is to get OWE IEs (RSN IE, DH IE etc) from assoc request
* and fill them in association indication.
@@ -1792,19 +1794,37 @@ static void sap_handle_acs_scan_event(struct sap_context *sap_context,
* Return: true for success and false for failure
*/
static bool sap_fill_owe_ie_in_assoc_ind(tSap_StationAssocIndication *assoc_ind,
struct assoc_ind *sme_assoc_ind)
struct assoc_ind *sme_assoc_ind,
bool reassoc)
{
uint32_t owe_ie_len, rsn_ie_len, dh_ie_len;
const uint8_t *rsn_ie, *dh_ie;
uint8_t *assoc_req_ie;
uint16_t assoc_req_ie_len;
if (assoc_ind->assocReqLength < ASSOC_REQ_IE_OFFSET) {
if (reassoc) {
if (assoc_ind->assocReqLength < WLAN_REASSOC_REQ_IES_OFFSET) {
sap_err("Invalid reassoc req");
return false;
}
assoc_req_ie = assoc_ind->assocReqPtr +
WLAN_REASSOC_REQ_IES_OFFSET;
assoc_req_ie_len = assoc_ind->assocReqLength -
WLAN_REASSOC_REQ_IES_OFFSET;
} else {
if (assoc_ind->assocReqLength < WLAN_ASSOC_REQ_IES_OFFSET) {
sap_err("Invalid assoc req");
return false;
}
assoc_req_ie = assoc_ind->assocReqPtr +
WLAN_ASSOC_REQ_IES_OFFSET;
assoc_req_ie_len = assoc_ind->assocReqLength -
WLAN_ASSOC_REQ_IES_OFFSET;
}
rsn_ie = wlan_get_ie_ptr_from_eid(DOT11F_EID_RSN,
assoc_ind->assocReqPtr + ASSOC_REQ_IE_OFFSET,
assoc_ind->assocReqLength - ASSOC_REQ_IE_OFFSET);
assoc_req_ie, assoc_req_ie_len);
if (!rsn_ie) {
sap_err("RSN IE is not present");
return false;
@@ -1817,8 +1837,7 @@ static bool sap_fill_owe_ie_in_assoc_ind(tSap_StationAssocIndication *assoc_ind,
}
dh_ie = wlan_get_ext_ie_ptr_from_ext_id(DH_OUI_TYPE, DH_OUI_TYPE_SIZE,
assoc_ind->assocReqPtr + ASSOC_REQ_IE_OFFSET,
(uint16_t)(assoc_ind->assocReqLength - ASSOC_REQ_IE_OFFSET));
assoc_req_ie, assoc_req_ie_len);
if (!dh_ie) {
sap_err("DH IE is not present");
return false;
@@ -2269,7 +2288,8 @@ QDF_STATUS sap_signal_hdd_event(struct sap_context *sap_ctx,
assoc_ind->ecsa_capable = csr_roaminfo->ecsa_capable;
if (csr_roaminfo->owe_pending_assoc_ind) {
if (!sap_fill_owe_ie_in_assoc_ind(assoc_ind,
csr_roaminfo->owe_pending_assoc_ind)) {
csr_roaminfo->owe_pending_assoc_ind,
csr_roaminfo->fReassocReq)) {
sap_err("Failed to fill OWE IE");
qdf_mem_free(csr_roaminfo->
owe_pending_assoc_ind);

1
core/sme/src/csr/csr_api_roam.c
View File

@@ -3919,6 +3919,7 @@ csr_roam_chk_lnk_assoc_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
#endif
roam_info->addIELen = (uint8_t)pAssocInd->addIE.length;
roam_info->paddIE = pAssocInd->addIE.addIEdata;
roam_info->fReassocReq = pAssocInd->reassocReq;
qdf_mem_copy(roam_info->peerMac.bytes,
pAssocInd->peerMacAddr,
sizeof(tSirMacAddr));