samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Fix out buffer overflow and un-intialized variable access

Browse Source 
In function pmo_core_send_lphb_enable check index before accessing array.
In function pmo_core_is_wow_applicable initialize vaiable before access.

Change-Id: Iadba3175d10da3e4e311d8ab9e8a850053d3da24
CRs-Fixed: 2162257
This commit is contained in:
Naveen Rawat
2018-01-06 17:36:16 -08:00
committed by snandini
parent 98c74b071a
commit b91e6eb90f
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/pmo/core/src/wlan_pmo_lphb.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2017 The Linux Foundation. All rights reserved. * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for * Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the * any purpose with or without fee is hereby granted, provided that the
@@ -59,7 +59,7 @@ static QDF_STATUS pmo_core_send_lphb_enable(struct wlan_objmgr_psoc *psoc,
} }
/* target already configured, now cache command status */ /* target already configured, now cache command status */
if (ts_lphb_enable->enable) { if (ts_lphb_enable->enable && ts_lphb_enable->item > 0) {
i = ts_lphb_enable->item - 1; i = ts_lphb_enable->item - 1;
qdf_spin_lock_bh(&psoc_ctx->lock); qdf_spin_lock_bh(&psoc_ctx->lock);
psoc_ctx->wow.lphb_cache[i].cmd psoc_ctx->wow.lphb_cache[i].cmd

4
components/pmo/core/src/wlan_pmo_wow.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2017 The Linux Foundation. All rights reserved. * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for * Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the * any purpose with or without fee is hereby granted, provided that the
@@ -262,7 +262,7 @@ bool pmo_core_is_wow_applicable(struct wlan_objmgr_psoc *psoc)
{ {
int vdev_id; int vdev_id;
struct wlan_objmgr_vdev *vdev; struct wlan_objmgr_vdev *vdev;
bool is_wow_applicable; bool is_wow_applicable = false;
QDF_STATUS status; QDF_STATUS status;
if (!psoc) { if (!psoc) {