From b6322f435410553bd1e4644032465b8114fe0e29 Mon Sep 17 00:00:00 2001 From: Akshay Kosigi Date: Tue, 6 Feb 2018 16:02:25 +0530 Subject: [PATCH] qcacmn: Replace void pointers with appropriate/common structure types Void pointer usage may lead to memory corruption due to wrong pointer is typecasted. Hence define structure for all, and modules internally typecasting based on their type Change-Id: I6271ed8aa3f94254fd85f41962f23ea36895154e CRs-Fixed: 2182452 --- src/target_if_tdls.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/target_if_tdls.c b/src/target_if_tdls.c index e0a0ef23f9..bbb3c32cf0 100644 --- a/src/target_if_tdls.c +++ b/src/target_if_tdls.c @@ -57,7 +57,7 @@ target_if_tdls_event_handler(ol_scn_t scn, uint8_t *data, uint32_t datalen) target_if_err("null psoc"); return -EINVAL; } - wmi_handle = GET_WMI_HDL_FROM_PSOC(psoc); + wmi_handle = get_wmi_unified_hdl_from_psoc(psoc); if (wmi_extract_vdev_tdls_ev_param(wmi_handle, data, &info)) { target_if_err("Failed to extract wmi tdls event"); @@ -122,7 +122,7 @@ target_if_tdls_set_uapsd(struct wlan_objmgr_psoc *psoc, struct sta_uapsd_trig_params *params) { QDF_STATUS ret; - wmi_unified_t wmi_handle = GET_WMI_HDL_FROM_PSOC(psoc); + wmi_unified_t wmi_handle = get_wmi_unified_hdl_from_psoc(psoc); if (!wmi_service_enabled(wmi_handle, wmi_sta_uapsd_basic_auto_trig) || @@ -145,17 +145,19 @@ QDF_STATUS target_if_tdls_register_event_handler(struct wlan_objmgr_psoc *psoc, void *arg) { - return wmi_unified_register_event(GET_WMI_HDL_FROM_PSOC(psoc), - wmi_tdls_peer_event_id, - target_if_tdls_event_handler); + return wmi_unified_register_event( + get_wmi_unified_hdl_from_psoc(psoc), + wmi_tdls_peer_event_id, + target_if_tdls_event_handler); } QDF_STATUS target_if_tdls_unregister_event_handler(struct wlan_objmgr_psoc *psoc, void *arg) { - return wmi_unified_unregister_event(GET_WMI_HDL_FROM_PSOC(psoc), - wmi_tdls_peer_event_id); + return wmi_unified_unregister_event( + get_wmi_unified_hdl_from_psoc(psoc), + wmi_tdls_peer_event_id); } QDF_STATUS