Jelajahi Sumber

qca-wifi: Fix KW issues in cfr component

Fix Suspicious dereference of pointer 'payload' before NULL check.
Fix 'status' might be used uninitialized in this function.

Change-Id: Ib799043555faafc655919c1e42d0fbc43c716b2f
Vikram Kandukuri 6 tahun lalu
induk
melakukan
b5d061ff6a
1 mengubah file dengan 5 tambahan dan 2 penghapusan
  1. 5 2
      cfr/src/target_if_cfr_8074v2.c

+ 5 - 2
cfr/src/target_if_cfr_8074v2.c

@@ -203,8 +203,8 @@ int correlate_and_relay(struct wlan_objmgr_pdev *pdev, uint32_t cookie,
 bool cfr_dbr_event_handler(struct wlan_objmgr_pdev *pdev,
 						   struct direct_buf_rx_data *payload)
 {
-	uint8_t *data = payload->vaddr;
-	uint32_t cookie = payload->cookie;
+	uint8_t *data = NULL;
+	uint32_t cookie = 0;
 	struct whal_cfir_dma_hdr dma_hdr = {0};
 	int  length = 8, tones = 0, status = 0;
 	struct wlan_objmgr_psoc *psoc;
@@ -230,6 +230,9 @@ bool cfr_dbr_event_handler(struct wlan_objmgr_pdev *pdev,
 		return true;
 	}
 
+	data = payload->vaddr;
+	cookie = payload->cookie;
+
 	cfr_debug("bufferaddr: 0x%pK cookie: %u", payload->paddr, cookie);
 	qdf_mem_copy(&dma_hdr, &data[0], sizeof(struct whal_cfir_dma_hdr));