Procházet zdrojové kódy

msm: camera: sync: Sync Driver Null Pointer Fix

Fixed null pointer dereference and uninitialized index variable.

CRs-Fixed: 3394193
Change-Id: I4a77060e227a9b39bb127c041515481549a99a42
Signed-off-by: Atiya Kailany <[email protected]>
Atiya Kailany před 2 roky
rodič
revize
b5af93e730
2 změnil soubory, kde provedl 3 přidání a 4 odebrání
  1. 2 2
      drivers/cam_sync/cam_sync.c
  2. 1 2
      drivers/cam_sync/cam_sync_synx.c

+ 2 - 2
drivers/cam_sync/cam_sync.c

@@ -1934,11 +1934,11 @@ static int cam_generic_fence_handle_sync_create(
 	struct cam_dma_fence_create_sync_obj_payload dma_sync_create;
 	struct cam_generic_fence_input_info *fence_input_info = NULL;
 	struct cam_generic_fence_config *fence_cfg = NULL;
-	bool synx_obj_created;
+	bool synx_obj_created = false;
 	struct sync_synx_obj_info synx_obj_create;
 #if IS_ENABLED(CONFIG_TARGET_SYNX_ENABLE)
 	int32_t fence_flag;
-	int32_t synx_obj_row_idx;
+	int32_t synx_obj_row_idx = 0;
 	struct cam_synx_obj_release_params synx_release_params;
 	struct dma_fence *dma_fence_ptr;
 #endif

+ 1 - 2
drivers/cam_sync/cam_sync_synx.c

@@ -140,8 +140,7 @@ static void __cam_synx_obj_signal_cb(u32 h_synx, int status, void *data)
 
 	if (!data) {
 		CAM_ERR(CAM_SYNX,
-			"Invalid data passed to synx obj : %d callback function.",
-			synx_obj_row->synx_obj);
+			"Invalid data passed to synx obj : No callback function set.");
 		return;
 	}