From b29d1e9018ff265bb66f53f7fc4a238ba90d8a16 Mon Sep 17 00:00:00 2001 From: Srinivas Girigowda Date: Tue, 2 Mar 2021 22:51:56 -0800 Subject: [PATCH] qcacmn: TWT: Add support for not in range and IE validation fail status code Add support for TWT AP params not in range and IE validation failed status code. Presence of num_additional_twt_params is enough to extract the additional params sent by the firmware, there is no need for extra status check. Change-Id: I9fa6afd22aa4de1b2a5b75fa98a00f89768dd8cf CRs-Fixed: 2890682 --- wmi/inc/wmi_unified_twt_param.h | 6 ++++++ wmi/src/wmi_unified_twt_tlv.c | 10 ---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/wmi/inc/wmi_unified_twt_param.h b/wmi/inc/wmi_unified_twt_param.h index 986db34671..12c104d662 100644 --- a/wmi/inc/wmi_unified_twt_param.h +++ b/wmi/inc/wmi_unified_twt_param.h @@ -303,6 +303,10 @@ struct wmi_twt_add_dialog_param { * WMI_HOST_ADD_TWT_STATUS_DENIED: AP did not accept the request * WMI_HOST_ADD_TWT_STATUS_UNKNOWN_ERROR: adding TWT dialog failed with * an unknown reason + * WMI_HOST_ADD_TWT_STATUS_AP_PARAMS_NOT_IN_RANGE: peer AP wake interval, + * duration not in range + * WMI_HOST_ADD_TWT_STATUS_AP_IE_VALIDATION_FAILED: + * peer AP IE Validation Failed */ enum WMI_HOST_ADD_TWT_STATUS { WMI_HOST_ADD_TWT_STATUS_OK, @@ -315,6 +319,8 @@ enum WMI_HOST_ADD_TWT_STATUS { WMI_HOST_ADD_TWT_STATUS_NO_RESPONSE, WMI_HOST_ADD_TWT_STATUS_DENIED, WMI_HOST_ADD_TWT_STATUS_UNKNOWN_ERROR, + WMI_HOST_ADD_TWT_STATUS_AP_PARAMS_NOT_IN_RANGE, + WMI_HOST_ADD_TWT_STATUS_AP_IE_VALIDATION_FAILED }; /** diff --git a/wmi/src/wmi_unified_twt_tlv.c b/wmi/src/wmi_unified_twt_tlv.c index 811ffb4f0f..8bd07696a5 100644 --- a/wmi/src/wmi_unified_twt_tlv.c +++ b/wmi/src/wmi_unified_twt_tlv.c @@ -534,16 +534,6 @@ static QDF_STATUS extract_twt_add_dialog_comp_additional_parameters ev = param_buf->fixed_param; - /* - * For Alternate values from AP, Firmware sends additional params - * with WMI_HOST_ADD_TWT_STATUS_DENIED - */ - if (ev->status != WMI_HOST_ADD_TWT_STATUS_OK && - ev->status != WMI_HOST_ADD_TWT_STATUS_DENIED) { - wmi_err("Status of add dialog complete is not success"); - return QDF_STATUS_E_INVAL; - } - if (idx >= param_buf->num_twt_params) { wmi_err("Invalid idx %d while num_twt_params = %d", idx, param_buf->num_twt_params);