From b24581bf285331d518998d5fc2d238648fea8f07 Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Fri, 14 Oct 2022 16:41:25 -0700 Subject: [PATCH] qcacmn: qdf: Rename misspelled "suppressed" variables/functions Multiple QDF rate limit identifiers use a misspelling of the word "suppressed" so fix those misspellings. For two public functions create macros with the old names to avoid breaking existing clients. Change-Id: I0107b157374046ab8f3467801563c02f0f2651fa CRs-Fixed: 3313685 --- qdf/inc/qdf_trace.h | 16 ++++++++++------ qdf/linux/src/qdf_trace.c | 22 +++++++++++----------- 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/qdf/inc/qdf_trace.h b/qdf/inc/qdf_trace.h index 2f78cf27eb..52d525f56d 100644 --- a/qdf/inc/qdf_trace.h +++ b/qdf/inc/qdf_trace.h @@ -684,18 +684,18 @@ void qdf_rl_print_count_set(uint32_t rl_print_count); void qdf_rl_print_time_set(uint32_t rl_print_time); /** - * qdf_rl_print_supressed_log() - print the supressed logs count + * qdf_rl_print_suppressed_log() - print the suppressed logs count * * Return: none */ -void qdf_rl_print_supressed_log(void); +void qdf_rl_print_suppressed_log(void); /** - * qdf_rl_print_supressed_inc() - increment the supressed logs count + * qdf_rl_print_suppressed_inc() - increment the suppressed logs count * * Return: none */ -void qdf_rl_print_supressed_inc(void); +void qdf_rl_print_suppressed_inc(void); #else /* WLAN_MAX_LOGS_PER_SEC */ static inline bool qdf_detected_excessive_logging(void) @@ -704,10 +704,14 @@ static inline bool qdf_detected_excessive_logging(void) } static inline void qdf_rl_print_count_set(uint32_t rl_print_count) {} static inline void qdf_rl_print_time_set(uint32_t rl_print_time) {} -static inline void qdf_rl_print_supressed_log(void) {} -static inline void qdf_rl_print_supressed_inc(void) {} +static inline void qdf_rl_print_suppressed_log(void) {} +static inline void qdf_rl_print_suppressed_inc(void) {} #endif /* WLAN_MAX_LOGS_PER_SEC */ +/* legacy misspelled names */ +#define qdf_rl_print_supressed_log qdf_rl_print_suppressed_log +#define qdf_rl_print_supressed_inc qdf_rl_print_suppressed_inc + #ifdef ENABLE_MTRACE_LOG /** * qdf_mtrace_log() - Logs a message tracepoint to DIAG diff --git a/qdf/linux/src/qdf_trace.c b/qdf/linux/src/qdf_trace.c index 77ecd12410..fee541bd32 100644 --- a/qdf/linux/src/qdf_trace.c +++ b/qdf/linux/src/qdf_trace.c @@ -3650,7 +3650,7 @@ static qdf_time_t __log_window_end; static qdf_atomic_t __log_window_count; uint32_t qdf_rl_print_count = WLAN_MAX_LOGS_PER_SEC; uint32_t qdf_rl_print_time = 1; -uint32_t qdf_rl_print_supressed; +uint32_t qdf_rl_print_suppressed; /** * qdf_detected_excessive_logging() - Excessive logging detected @@ -3699,32 +3699,32 @@ void qdf_rl_print_time_set(uint32_t rl_print_time) qdf_export_symbol(qdf_rl_print_time_set); -void qdf_rl_print_supressed_log(void) +void qdf_rl_print_suppressed_log(void) { - if (qdf_rl_print_supressed) { + if (qdf_rl_print_suppressed) { pr_err("QDF Ratelimiting: %d prints suppressed", - qdf_rl_print_supressed); - qdf_rl_print_supressed = 0; + qdf_rl_print_suppressed); + qdf_rl_print_suppressed = 0; } } -void qdf_rl_print_supressed_inc(void) +void qdf_rl_print_suppressed_inc(void) { - qdf_rl_print_supressed++; + qdf_rl_print_suppressed++; } #else -#define qdf_rl_print_supressed_log() -#define qdf_rl_print_supressed_inc() +#define qdf_rl_print_suppressed_log() +#define qdf_rl_print_suppressed_inc() #endif /* WLAN_MAX_LOGS_PER_SEC */ #ifdef QDF_TRACE_PRINT_ENABLE static inline void print_to_console(char *str_buffer) { if (qdf_in_interrupt() && qdf_detected_excessive_logging()) { - qdf_rl_print_supressed_inc(); + qdf_rl_print_suppressed_inc(); return; } - qdf_rl_print_supressed_log(); + qdf_rl_print_suppressed_log(); pr_err("%s\n", str_buffer); } #else