samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Peer ref count leaks in ppdu stats and descriptor deliver

Browse Source 
Because of reference counter decrement is not triggered for every
condition path, it is possible that peer reference counter leaking
happens under some perticular circumstance. Make sure the peer ref
count unreference is called for each possible path.

CRs-Fixed: 2352433
Change-Id: I60bc5a5210519c26c57cdc563d0d1b02d799e090
This commit is contained in:
chenguo
2018-11-19 19:17:12 +08:00
committed by nshrivas
parent d0d365d87e
commit b21a49a57e
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dp/wifi3.0/dp_htt.c
View File

@@ -2480,11 +2480,10 @@ void dp_ppdu_desc_deliver(struct dp_pdev *pdev,
dp_tx_stats_update(pdev->soc, peer, dp_tx_stats_update(pdev->soc, peer,
&ppdu_desc->user[i], &ppdu_desc->user[i],
ppdu_desc->ack_rssi); ppdu_desc->ack_rssi);
dp_peer_unref_del_find_by_id(peer);
} }
dp_tx_rate_stats_update(peer, &ppdu_desc->user[i]); dp_tx_rate_stats_update(peer, &ppdu_desc->user[i]);
dp_peer_unref_del_find_by_id(peer);
} }
/* /*

18
dp/wifi3.0/dp_rx_mon_status.c
View File

@@ -416,16 +416,16 @@ dp_rx_handle_ppdu_stats(struct dp_soc *soc, struct dp_pdev *pdev,
sizeof(struct cdp_rx_indication_ppdu)); sizeof(struct cdp_rx_indication_ppdu));
cdp_rx_ppdu = (struct cdp_rx_indication_ppdu *)ppdu_nbuf->data; cdp_rx_ppdu = (struct cdp_rx_indication_ppdu *)ppdu_nbuf->data;
peer = dp_peer_find_by_id(soc, cdp_rx_ppdu->peer_id); peer = dp_peer_find_by_id(soc, cdp_rx_ppdu->peer_id);
if (cdp_rx_ppdu->peer_id != HTT_INVALID_PEER) { if (peer) {
if (peer) {
dp_rx_stats_update(pdev, peer, cdp_rx_ppdu);
dp_wdi_event_handler(WDI_EVENT_RX_PPDU_DESC,
soc, ppdu_nbuf, cdp_rx_ppdu->peer_id,
WDI_NO_VAL, pdev->pdev_id);
dp_peer_unref_del_find_by_id(peer);
}
} else if (pdev->mcopy_mode) {
dp_rx_stats_update(pdev, peer, cdp_rx_ppdu); dp_rx_stats_update(pdev, peer, cdp_rx_ppdu);
dp_peer_unref_del_find_by_id(peer);
}
if (cdp_rx_ppdu->peer_id != HTT_INVALID_PEER) {
dp_wdi_event_handler(WDI_EVENT_RX_PPDU_DESC,
soc, ppdu_nbuf,
cdp_rx_ppdu->peer_id,
WDI_NO_VAL, pdev->pdev_id);
} else if (pdev->mcopy_mode) {
dp_wdi_event_handler(WDI_EVENT_RX_PPDU_DESC, soc, dp_wdi_event_handler(WDI_EVENT_RX_PPDU_DESC, soc,
ppdu_nbuf, HTT_INVALID_PEER, ppdu_nbuf, HTT_INVALID_PEER,
WDI_NO_VAL, pdev->pdev_id); WDI_NO_VAL, pdev->pdev_id);