qcacld-3.0: Reset txrx handles during STA deinit

HDD currently reset various txrx handles during the deinit of an access
point (AP) interface, but fails to do so for station interfaces. This
can lead to a user-after-free while changing the interface mode from
station to something else. Reset the txrx handles during deinit for
station interfaces.

Change-Id: I189089fabefb9c430da493c0c99473179d02b5cd
CRs-Fixed: 2283532

core/hdd/src/wlan_hdd_softap_tx_rx.c

@@ -749,14 +749,13 @@ QDF_STATUS hdd_softap_init_tx_rx(struct hdd_adapter *adapter)
 
 QDF_STATUS hdd_softap_deinit_tx_rx(struct hdd_adapter *adapter)
 {
-	if (adapter == NULL) {
-		hdd_err("Called with adapter = NULL.");
+	QDF_BUG(adapter);
+	if (!adapter)
 		return QDF_STATUS_E_FAILURE;
-	}
 
 	adapter->txrx_vdev = NULL;
 	adapter->tx_fn = NULL;
-	hdd_info("Deregistering TX function hook !");
+
 	return QDF_STATUS_SUCCESS;
 }
 

core/hdd/src/wlan_hdd_tx_rx.c

@@ -1329,15 +1329,14 @@ QDF_STATUS hdd_init_tx_rx(struct hdd_adapter *adapter)
  */
 QDF_STATUS hdd_deinit_tx_rx(struct hdd_adapter *adapter)
 {
-	QDF_STATUS status = QDF_STATUS_SUCCESS;
-
-	if (NULL == adapter) {
-		hdd_err("adapter is NULL");
-		QDF_ASSERT(0);
+	QDF_BUG(adapter);
+	if (!adapter)
 		return QDF_STATUS_E_FAILURE;
-	}
 
-	return status;
+	adapter->txrx_vdev = NULL;
+	adapter->tx_fn = NULL;
+
+	return QDF_STATUS_SUCCESS;
 }
 
 #ifdef FEATURE_MONITOR_MODE_SUPPORT