samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: sde: remove an uninitialized index variable

Browse Source 
Avoid exposing any uninitialized data when setting up the
interrupt tables.

Change-Id: I00d3dc8b5acc843401148585a129fde58e326beb
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
Signed-off-by: Steve Cohen <cohens@codeaurora.org>
This commit is contained in:
Narendra Muppalla
2020-02-03 18:19:46 -08:00
committed by Gerrit - the friendly Code Review server
parent 9beffdfdc6
commit b03a7413a4
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
msm/sde/sde_hw_interrupts.c
View File

@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
/* /*
* Copyright (c) 2016-2019, The Linux Foundation. All rights reserved. * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved.
*/ */
#include <linux/bitops.h> #include <linux/bitops.h>
@@ -1119,7 +1119,7 @@ static int _sde_hw_intr_init_irq_tables(struct sde_hw_intr *intr,
struct sde_mdss_cfg *m) struct sde_mdss_cfg *m)
{ {
struct sde_intr_irq_offsets *item; struct sde_intr_irq_offsets *item;
int i, idx, sde_irq_tbl_idx = 0, ret = 0; int i, sde_irq_tbl_idx = 0, ret = 0;
u32 low_idx, high_idx; u32 low_idx, high_idx;
u32 sde_irq_map_idx = 0; u32 sde_irq_map_idx = 0;
@@ -1128,9 +1128,6 @@ static int _sde_hw_intr_init_irq_tables(struct sde_hw_intr *intr,
low_idx = sde_irq_map_idx; low_idx = sde_irq_map_idx;
high_idx = low_idx + _get_irq_map_size(item); high_idx = low_idx + _get_irq_map_size(item);
pr_debug("init[%d]=%d low:%d high:%d\n",
sde_irq_tbl_idx, idx, low_idx, high_idx);
if (sde_irq_tbl_idx >= intr->sde_irq_size || if (sde_irq_tbl_idx >= intr->sde_irq_size ||
sde_irq_tbl_idx < 0) { sde_irq_tbl_idx < 0) {
ret = -EINVAL; ret = -EINVAL;