samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Initialize scheduler_msg on stack before posting message

Browse Source 
Initialize scheduler_msg on stack before posting using scheduler API
such that un-used fields in message structure are initialized to 0.

Change-Id: Ib3183b2c65eb9affd6610f4572c751c39a25fff7
CRs-Fixed: 2034772
This commit is contained in:
Rajeev Kumar
2017-04-17 17:00:41 -07:00
committed by Sandeep Puligilla
parent b83f9e70ea
commit afc63bc8af
5 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scheduler/src/scheduler_api.c
View File

@@ -196,6 +196,14 @@ QDF_STATUS scheduler_post_msg_by_priority(QDF_MODULE_ID qid,
return QDF_STATUS_E_FAILURE;
}
if ((0 != pMsg->reserved) && (SYS_MSG_COOKIE != pMsg->reserved)) {
QDF_TRACE(QDF_MODULE_ID_SCHEDULER, QDF_TRACE_LEVEL_ERROR,
"%s: Un-initialized message pointer.. please initialize it",
__func__);
QDF_BUG(0);
return QDF_STATUS_E_FAILURE;
}
/* Target_If is a special message queue in phase 3 convergence beacause
* its used by both legacy WMA and as well as new UMAC components which
* directly populate callback handlers in message body.
@@ -516,7 +524,7 @@ QDF_STATUS scheduler_deregister_sys_legacy_handler(void)
void scheduler_mc_timer_callback(unsigned long data)
{
qdf_mc_timer_t *timer = (qdf_mc_timer_t *)data;
struct scheduler_msg msg;
struct scheduler_msg msg = {0};
QDF_STATUS status;
qdf_mc_timer_callback_t callback = NULL;