samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Reduce logging for hdd netdev notifier

Browse Source 
Reduce error logs in __hdd_netdev_notifier_call which do not alway
indicate an error.

Change-Id: I7386cb26993877ed86802b60240cd04b85dd4e8b
CRs-Fixed: 2287681
This commit is contained in:
Dustin Brown
2018-07-30 17:20:32 -07:00
committed by nshrivas
parent 53791fa58b
commit aeb556490f
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/hdd/src/wlan_hdd_main.c
View File

@@ -603,14 +603,13 @@ static int __hdd_netdev_notifier_call(struct notifier_block *nb,
hdd_enter_dev(dev); hdd_enter_dev(dev);
if (!dev->ieee80211_ptr) { if (!dev->ieee80211_ptr) {
hdd_err("ieee80211_ptr is NULL!!!"); hdd_debug("ieee80211_ptr is null");
return NOTIFY_DONE; return NOTIFY_DONE;
} }
hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
if (!hdd_ctx) { if (!hdd_ctx) {
hdd_err("HDD Context is Null"); hdd_err("HDD Context is Null");
QDF_ASSERT(0);
return NOTIFY_DONE; return NOTIFY_DONE;
} }
@@ -622,7 +621,7 @@ static int __hdd_netdev_notifier_call(struct notifier_block *nb,
/* Make sure that this callback corresponds to our device. */ /* Make sure that this callback corresponds to our device. */
adapter = hdd_get_adapter_by_iface_name(hdd_ctx, dev->name); adapter = hdd_get_adapter_by_iface_name(hdd_ctx, dev->name);
if (!adapter) { if (!adapter) {
hdd_err("Couldn't find adapter for dev name %s", dev->name); hdd_debug("failed to look up adapter for '%s'", dev->name);
return NOTIFY_DONE; return NOTIFY_DONE;
} }
@@ -631,8 +630,13 @@ static int __hdd_netdev_notifier_call(struct notifier_block *nb,
return NOTIFY_DONE; return NOTIFY_DONE;
} }
if (cds_is_driver_recovering() || cds_is_driver_in_bad_state()) { if (cds_is_driver_recovering()) {
hdd_err("Driver is in recovery or bad state"); hdd_debug("Driver is recovering");
return NOTIFY_DONE;
}
if (cds_is_driver_in_bad_state()) {
hdd_debug("Driver is in failed recovery state");
return NOTIFY_DONE; return NOTIFY_DONE;
} }