Эх сурвалжийг харах

qcacld-3.0: Cleanup in mac_open to avoid freeing p_mac

In “Change-Id: I3638b576b76c26181cb180d8b37e195ba3b0ecad”
replaced dynamic allocation of p_mac to used memory from
.bss segment, So do not free p_mac.

Change-Id: I2aab77871b8b96de65d7732a001934586df635d0
CRs-Fixed: 2026241
Arif Hussain 8 жил өмнө
parent
commit
ae99ff0b8a

+ 2 - 6
core/mac/src/sys/legacy/src/system/src/mac_init_api.c

@@ -130,10 +130,8 @@ tSirRetStatus mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
 
 	{
 		/* Call routine to initialize CFG data structures */
-		if (eSIR_SUCCESS != cfg_init(p_mac)) {
-			qdf_mem_free(p_mac);
+		if (eSIR_SUCCESS != cfg_init(p_mac))
 			return eSIR_FAILURE;
-		}
 
 		sys_init_globals(p_mac);
 	}
@@ -143,10 +141,8 @@ tSirRetStatus mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
 	p_mac->first_scan_done = false;
 
 	status =  pe_open(p_mac, cds_cfg);
-	if (eSIR_SUCCESS != status) {
+	if (eSIR_SUCCESS != status)
 		pe_err("pe_open() failure");
-		qdf_mem_free(p_mac);
-	}
 
 	return status;
 }