From ab482ac2b47d8de1a8e996ebdf68096fb629d1cd Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Fri, 9 Jun 2017 17:00:44 -0700 Subject: [PATCH] qcacld-3.0: Print build timestamp with driver version As part of driver init, the version string gets printed. To help in debugging, also print a timestamp from when the driver was compiled. Change-Id: Icf064af6a0d84434d239b54603092bf2276df596 CRs-Fixed: 2059303 --- Kbuild | 3 +++ core/hdd/src/wlan_hdd_main.c | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/Kbuild b/Kbuild index c60815df89..169b024ff4 100644 --- a/Kbuild +++ b/Kbuild @@ -2158,3 +2158,6 @@ endif # Module information used by KBuild framework obj-$(CONFIG_QCA_CLD_WLAN) += $(MODNAME).o $(MODNAME)-y := $(OBJS) + +# inject some build related information +CDEFINES += -DBUILD_TIMESTAMP=\"$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')\" diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index ea1b2a525d..da3a29449f 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -275,10 +275,12 @@ void wlan_hdd_txrx_pause_cb(uint8_t vdev_id, } /* - * Store WLAN driver version info in a global variable such that crash debugger - * can extract it from driver debug symbol and crashdump for post processing + * Store WLAN driver version and timestamp info in global variables such that + * crash debugger can extract them from driver debug symbol and crashdump for + * post processing */ uint8_t g_wlan_driver_version[] = QWLAN_VERSIONSTR; +uint8_t g_wlan_driver_timestamp[] = BUILD_TIMESTAMP; /** * hdd_device_mode_to_string() - return string conversion of device mode @@ -10606,8 +10608,11 @@ static int __hdd_module_init(void) { int ret = 0; - pr_err("%s: Loading driver v%s\n", WLAN_MODULE_NAME, - QWLAN_VERSIONSTR TIMER_MANAGER_STR MEMORY_DEBUG_STR); + pr_err("%s: Loading driver v%s (%s)%s\n", + WLAN_MODULE_NAME, + QWLAN_VERSIONSTR, + BUILD_TIMESTAMP, + TIMER_MANAGER_STR MEMORY_DEBUG_STR); ret = wlan_hdd_state_ctrl_param_create(); if (ret) { @@ -10840,17 +10845,12 @@ static int wlan_deinit_sysfs(void) */ static int hdd_module_init(void) { - int ret = 0; - - pr_err("%s: Loading driver v%s\n", WLAN_MODULE_NAME, - QWLAN_VERSIONSTR TIMER_MANAGER_STR MEMORY_DEBUG_STR); - if (__hdd_module_init()) { pr_err("%s: Failed to register handler\n", __func__); - ret = -EINVAL; + return -EINVAL; } - return ret; + return 0; } #else static int __init hdd_module_init(void)