qcacld-3.0: Fix pe session leak

Preauth ROC timer is LIM_FT_PREAUTH_SCAN_TIME which is 50 ms, while
the preauth timeout is 1 second, in case of offchannel operation
scan complete firstly before auth resp frame received, host doesn't
stop the preauth timer or indicate that preauth req is processed,
before sending resp(failure) to connection manager. Thus if auth
resp is received after scan complete, it is processed and create
pe session which won't be deleted later.

Fix is to not initiate the failure from scan ROC complete but let the
preauth timer take care of the failure.

Change-Id: Ib93b4d2c6c6f0044535a8f41af0ef4baeaf468f6
CRs-Fixed: 2992079

core/mac/src/pe/lim/lim_ft_preauth.c

@@ -484,16 +484,19 @@ send_rsp:
 	if ((pe_session->curr_op_freq !=
 	     pe_session->ftPEContext.pFTPreAuthReq->pre_auth_channel_freq) ||
 	    lim_is_in_mcc(mac)) {
+		pe_debug("Pre auth on diff freq as connected AP freq %d or mcc pe sessions exist, so abort scan",
+			 pe_session->ftPEContext.pFTPreAuthReq->pre_auth_channel_freq);
+
 		/* Need to move to the original AP channel */
 		lim_process_abort_scan_ind(mac, pe_session->smeSessionId,
 			pe_session->ftPEContext.pFTPreAuthReq->scan_id,
 			mac->lim.req_id | PREAUTH_REQUESTOR_ID);
-	} else {
-		pe_debug("Pre auth on same freq as connected AP freq %d and no mcc pe sessions exist",
-			 pe_session->ftPEContext.pFTPreAuthReq->
-			 pre_auth_channel_freq);
-		lim_ft_process_pre_auth_result(mac, pe_session);
 	}
+	/*
+	 * Send resp to connection manager, even in case scan needs abort,
+	 * scan complete will be no-op.
+	 */
+	lim_ft_process_pre_auth_result(mac, pe_session);
 }
 
 /*
@@ -785,8 +788,9 @@ void lim_preauth_scan_event_handler(struct mac_context *mac_ctx,
 		 * Scan either completed successfully or or got terminated
 		 * after successful auth, or timed out. Either way, STA
 		 * is back to home channel. Data traffic can continue.
+		 * Don't do anything as preauth timer/auth resp will take care
+		 * of the sending resp to the connection manager.
 		 */
-		lim_ft_process_pre_auth_result(mac_ctx, session_entry);
 		break;
 
 	case SIR_SCAN_EVENT_FOREIGN_CHANNEL:

core/mac/src/pe/lim/lim_process_auth_frame.c

@@ -1829,12 +1829,13 @@ QDF_STATUS lim_process_auth_frame_no_session(struct mac_context *mac,
 		qdf_mem_free(rx_auth_frame);
 		return QDF_STATUS_E_FAILURE;
 	}
+	pe_info("Pre-Auth RX: type: %d seqnum: %d status: %d %d from " QDF_MAC_ADDR_FMT,
+		(uint32_t)rx_auth_frame->authAlgoNumber,
+		(uint32_t)rx_auth_frame->authTransactionSeqNumber,
+		(uint32_t)rx_auth_frame->authStatusCode,
+		(uint32_t)mac->lim.gLimNumPreAuthContexts,
+		QDF_MAC_ADDR_REF(pHdr->sa));
 
-	pe_debug("Received Auth frame with type: %d seqnum: %d status: %d %d",
-		       (uint32_t)rx_auth_frame->authAlgoNumber,
-		       (uint32_t)rx_auth_frame->authTransactionSeqNumber,
-		       (uint32_t)rx_auth_frame->authStatusCode,
-		       (uint32_t)mac->lim.gLimNumPreAuthContexts);
 	switch (rx_auth_frame->authTransactionSeqNumber) {
 	case SIR_MAC_AUTH_FRAME_2:
 		if (rx_auth_frame->authStatusCode != STATUS_SUCCESS) {