qcacld-3.0: Remove wlan_hdd_validate_session_id()

Previously I06f948d8de4b8a98bfe66e18ae38b1040204fdb4 ("qcacld-3.0:
Replace wlan_hdd_validate_session_id()") replaced all instances of
wlan_hdd_validate_session_id() with wlan_hdd_validate_vdev_id().
However this change left behind the wlan_hdd_validate_session_id()
macro. Subsequently I7584fb5db036d1643bd7d56076d30a0c75008a98
("qcacld-3.0: Handle OWE info update from hostapd") added a new
instance of invoking wlan_hdd_validate_session_id(). So rename the new
instance, and remove the macro to prevent the addition of any future
instances.

Change-Id: I132a749d2f694b44296a44f2aa31e9aec5f0878f
CRs-Fixed: 2408166

core/hdd/inc/wlan_hdd_main.h

@@ -2154,10 +2154,6 @@ int __hdd_validate_adapter(struct hdd_adapter *adapter, const char *func);
 
 int __wlan_hdd_validate_vdev_id(uint8_t vdev_id, const char *func);
 
-/* legacy interface to be replaced */
-#define wlan_hdd_validate_session_id(session_id) \
-	wlan_hdd_validate_vdev_id(session_id)
-
 /**
  * hdd_is_valid_mac_address() - validate MAC address
  * @mac_addr:	Pointer to the input MAC address

core/hdd/src/wlan_hdd_cfg80211.c

@@ -19697,8 +19697,8 @@ __wlan_hdd_cfg80211_update_owe_info(struct wiphy *wiphy,
 		return -EINVAL;
 	}
 
-	if (wlan_hdd_validate_session_id(adapter->vdev_id)) {
-		hdd_err("invalid session id: %d", adapter->vdev_id);
+	if (wlan_hdd_validate_vdev_id(adapter->vdev_id)) {
+		hdd_err("invalid vdev id: %d", adapter->vdev_id);
 		return -EINVAL;
 	}