samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Remove qdf_exit_thread()

Browse Source 
While migrating from v5.15 to v5.19 of the Linux Kernel, a build error
was observed:

ERROR: modpost: "do_exit" [...] undefined!

The reason do_exit is undefined is because Linux Kernel commit
eb55e716ac1a ("exit: Stop exporting do_exit") removed the
EXPORT_SYMBOL() with the justification "there are no more modular uses
of do_exit".

Commit eb55e716ac1a was preceded by commit 111e70490d2a
("exit/kthread: Have kernel threads return instead of calling
do_exit") which details why, since commit 63706172f332 ("kthreads:
rework kthread_stop()"), it is unnecessary to call do_exit().

Note that commit 63706172f332 was introduced in 2009 in v2.6.31-rc1.
Since we do not need to support any kernels before that time, we can
follow the same advice and return instead of calling do_exit().

Currently do_exit() is only called from qdf_exit_thread(). As a result
of the preceding investigation, all former callers of qdf_exit_thread()
have been modified to no longer call it.  Since it is obsolete, remove
it.

Change-Id: I22f27692fa8766df080630b9b0640c259285557c
CRs-Fixed: 3300460
This commit is contained in:
Jeff Johnson
2022-09-26 16:35:36 -07:00
committed by Madan Koyyalamudi
parent 8b3dca1820
commit a5d454cfef
2 changed files with 2 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
qdf/inc/qdf_event.h
View File

@@ -1,5 +1,6 @@
/*
* Copyright (c) 2014-2018, 2021 The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -126,14 +127,6 @@ void qdf_event_list_init(void);
*/
void qdf_event_list_destroy(void);
/**
* qdf_exit_thread() - exit thread execution
* @status: QDF status
*
* Return: QDF status
*/
QDF_STATUS qdf_exit_thread(QDF_STATUS status);
#ifdef __cplusplus
}
#endif /* __cplusplus */

12
qdf/linux/src/qdf_event.c
View File

@@ -1,5 +1,6 @@
/*
* Copyright (c) 2014-2021 The Linux Foundation. All rights reserved.
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -384,14 +385,3 @@ void qdf_event_list_destroy(void)
qdf_spinlock_destroy(&qdf_wait_event_lock);
}
qdf_export_symbol(qdf_event_list_destroy);
QDF_STATUS qdf_exit_thread(QDF_STATUS status)
{
if (status == QDF_STATUS_SUCCESS)
do_exit(0);
else
do_exit(SIGKILL);
return QDF_STATUS_SUCCESS;
}
qdf_export_symbol(qdf_exit_thread);