Преглед изворни кода

qcacld-3.0: Remove logs for wlan_hdd_validate_vdev_id() checks

wlan_hdd_validate_vdev_id() function already takes care of logging
the caller function name in case of any error. Hence there is no need to
add the error log again.

Getting rid of these unnecessary logs reduces driver memory footprint.

Change-Id: Ic42aeacb4ed55cece038fe8cef8cde0df2ae6c4d
CRs-Fixed: 2769596
Srinivas Girigowda пре 4 година
родитељ
комит
a3e792efe9

+ 1 - 3
core/hdd/src/wlan_hdd_btc_chain_mode.c

@@ -45,10 +45,8 @@ wlan_hdd_btc_chain_mode_handler(struct wlan_objmgr_vdev *vdev)
 	}
 
 	vdev_id = wlan_vdev_get_id(vdev);
-	if (wlan_hdd_validate_vdev_id(vdev_id)) {
-		hdd_err("Invalid vdev id: %d", vdev_id);
+	if (wlan_hdd_validate_vdev_id(vdev_id))
 		return QDF_STATUS_E_INVAL;
-	}
 
 	psoc = wlan_vdev_get_psoc(vdev);
 	if (!psoc) {

+ 1 - 3
core/hdd/src/wlan_hdd_cfg80211.c

@@ -22341,10 +22341,8 @@ __wlan_hdd_cfg80211_update_owe_info(struct wiphy *wiphy,
 		return -EINVAL;
 	}
 
-	if (wlan_hdd_validate_vdev_id(adapter->vdev_id)) {
-		hdd_err("invalid vdev id: %d", adapter->vdev_id);
+	if (wlan_hdd_validate_vdev_id(adapter->vdev_id))
 		return -EINVAL;
-	}
 
 	hdd_debug("owe_status %d", owe_info->status);
 

+ 1 - 3
core/hdd/src/wlan_hdd_hostapd.c

@@ -5944,10 +5944,8 @@ static int __wlan_hdd_cfg80211_stop_ap(struct wiphy *wiphy,
 		goto exit;
 	}
 
-	if (wlan_hdd_validate_vdev_id(adapter->vdev_id)) {
-		hdd_err("vdev is invalid. Hence return");
+	if (wlan_hdd_validate_vdev_id(adapter->vdev_id))
 		goto exit;
-	}
 
 	qdf_mtrace(QDF_MODULE_ID_HDD, QDF_MODULE_ID_HDD,
 		   TRACE_CODE_HDD_CFG80211_STOP_AP,

+ 1 - 3
core/hdd/src/wlan_hdd_rssi_monitor.c

@@ -77,10 +77,8 @@ __wlan_hdd_cfg80211_monitor_rssi(struct wiphy *wiphy,
 
 	hdd_enter_dev(dev);
 
-	if (wlan_hdd_validate_vdev_id(adapter->vdev_id)) {
-		hdd_err("invalid session id: %d", adapter->vdev_id);
+	if (wlan_hdd_validate_vdev_id(adapter->vdev_id))
 		return -EINVAL;
-	}
 
 	ret = wlan_hdd_validate_context(hdd_ctx);
 	if (ret)