Przeglądaj źródła

msm: synx: Move dprintk outside spinlock

synx_client_destroy prints a log holding a spinlock which causes
watchdog bite due to excessive log. This change prints the log after
releasing the lock.

Change-Id: I42021fd8d07cc595a31a0396f138ac18bcb5bd0f
Signed-off-by: Pravin Kumar Ravi <[email protected]>
Pravin Kumar Ravi 2 lat temu
rodzic
commit
a1825820d5
1 zmienionych plików z 2 dodań i 2 usunięć
  1. 2 2
      msm/synx/synx_util.c

+ 2 - 2
msm/synx/synx_util.c

@@ -1363,6 +1363,8 @@ static void synx_client_cleanup(struct work_struct *dispatch)
 	struct synx_handle_coredata *curr;
 	struct hlist_node *tmp;
 
+	dprintk(SYNX_INFO, "[sess :%llu] session removed %s\n",
+		client->id, client->name);
 	/*
 	 * go over all the remaining synx obj handles
 	 * un-released from this session and remove them.
@@ -1390,8 +1392,6 @@ static void synx_client_destroy(struct kref *kref)
 		container_of(kref, struct synx_client, refcount);
 
 	hash_del(&client->node);
-	dprintk(SYNX_INFO, "[sess :%llu] session removed %s\n",
-		client->id, client->name);
 
 	INIT_WORK(&client->dispatch, synx_client_cleanup);
 	queue_work(synx_dev->wq_cleanup, &client->dispatch);