From 8f00f9a40a9c409421bf44d0f90ad52767ca6075 Mon Sep 17 00:00:00 2001 From: Amine Najahi Date: Mon, 13 Apr 2020 08:44:59 -0400 Subject: [PATCH] disp: msm: sde: remove unnecessary DSPP HW resource check The color-processing partial update check wrongly assumes that all pipes in a CRTC have a DSPP attached. This inhibits the use of any LMs without a valid DSPP. Fix the issue by removing this invalid check since whenever a DSPP feature is required, the HW resource availability is already confirmed during the color-processing property validation. Change-Id: I5b4565865644e4a0fa3d0542a299067f21756863 Signed-off-by: Amine Najahi --- msm/sde/sde_color_processing.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/msm/sde/sde_color_processing.c b/msm/sde/sde_color_processing.c index e236e08806..addb4afcc1 100644 --- a/msm/sde/sde_color_processing.c +++ b/msm/sde/sde_color_processing.c @@ -1699,11 +1699,6 @@ static int sde_cp_crtc_check_pu_features(struct drm_crtc *crtc) DRM_ERROR("invalid ctl in mixer %d\n", i); return -EINVAL; } - - if (!sde_crtc->mixers[i].hw_dspp) { - DRM_ERROR("invalid dspp in mixer %d\n", i); - return -EINVAL; - } } /* early return when not a partial update frame */ @@ -1846,11 +1841,6 @@ static int sde_cp_crtc_set_pu_features(struct drm_crtc *crtc, bool *need_flush) DRM_ERROR("invalid ctl in mixer %d\n", i); return -EINVAL; } - - if (!sde_crtc->mixers[i].hw_dspp) { - DRM_ERROR("invalid dspp in mixer %d\n", i); - return -EINVAL; - } } /* early return if not a partial update frame or no change in rois */