samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: fix null-ptr-deref Read issue

Browse Source 
Add sanity check in function target_if_init_spectral_capability
to avoid null-ptr-deref read issue.

Change-Id: Iccd79051ee8294f421704eadbedf6c9d9bf9a7b9
CRs-Fixed: 2692688
This commit is contained in:
Paul Zhang
2020-05-22 14:40:41 +08:00
committed by nshrivas
parent efbca64bbe
commit a027a582cc
1 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
target_if/spectral/target_if_spectral.c
View File

@@ -1554,18 +1554,23 @@ target_if_init_spectral_capability(struct target_if_spectral *spectral,
pcap->agile_spectral_cap_80p80 = false; pcap->agile_spectral_cap_80p80 = false;
} }
for (param_idx = 0; param_idx < num_bin_scaling_params; param_idx++) { if (scaling_params) {
if (scaling_params[param_idx].pdev_id == pdev_id) { for (param_idx = 0; param_idx < num_bin_scaling_params;
pcap->is_scaling_params_populated = true; param_idx++) {
pcap->formula_id = scaling_params[param_idx].formula_id; if (scaling_params[param_idx].pdev_id == pdev_id) {
pcap->low_level_offset = pcap->is_scaling_params_populated = true;
scaling_params[param_idx].low_level_offset; pcap->formula_id =
pcap->high_level_offset = scaling_params[param_idx].formula_id;
scaling_params[param_idx].high_level_offset; pcap->low_level_offset =
pcap->rssi_thr = scaling_params[param_idx].rssi_thr; scaling_params[param_idx].low_level_offset;
pcap->default_agc_max_gain = pcap->high_level_offset =
scaling_params[param_idx].default_agc_max_gain; scaling_params[param_idx].high_level_offset;
break; pcap->rssi_thr =
scaling_params[param_idx].rssi_thr;
pcap->default_agc_max_gain =
scaling_params[param_idx].default_agc_max_gain;
break;
}
} }
} }