samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: camera: isp: Check for execution context prior to obtaining lock

Browse Source 
Currently, in_interrupt() is used to determine task context.
in_interrupt() would return 0 if the execution is in task context;
a spin lock is obtained with bh disabled. Since the bh's are disabled,
the preempt count/soft_irq disable count would increase.
When we attempt to release the lock, the same in_interrupt() API
would now return non-zero, failing to release the lock.
The change uses appropriate preempt API to determine execution context.

CRs-Fixed: 3509317
Change-Id: I43f981bf3a2d4c238cebc4b29fa8a9aa0a8e0df3
Signed-off-by: Soumen Ghosh <quic_soumeng@quicinc.com>
This commit is contained in:
Soumen Ghosh
2023-06-22 15:10:18 -07:00
committed by Camera Software Integration
parent 3a2d1f7f4e
commit 9e69478cf5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cam_isp/cam_isp_context.c
View File

@@ -3683,7 +3683,7 @@ static int __cam_isp_ctx_validate_for_req_reapply_util(
struct cam_isp_ctx_req *req_isp = NULL; struct cam_isp_ctx_req *req_isp = NULL;
struct cam_context *ctx = ctx_isp->base; struct cam_context *ctx = ctx_isp->base;
if (!in_interrupt()) if (in_task())
spin_lock_bh(&ctx->lock); spin_lock_bh(&ctx->lock);
/* Check for req in active/wait lists */ /* Check for req in active/wait lists */
@@ -3744,7 +3744,7 @@ static int __cam_isp_ctx_validate_for_req_reapply_util(
} }
end: end:
if (!in_interrupt()) if (in_task())
spin_unlock_bh(&ctx->lock); spin_unlock_bh(&ctx->lock);
return rc; return rc;
} }