samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Tdls avoid peer access after peer deletion

Browse Source 
Currently, peer can be accessed after deletion in hdd because
cdp_clear_peer called via tdls_process_del_peer_rsp
tries to remove peer from physical device after deletion of
peer in datapath.

Fix is to remove cdp_clear_peer from hdd as it is handled by
cdp_peer_delete.

Change-Id: Ibdeb9a2a8dcf3318d66a48b9e9c7ca4d5cd74cb3
CRs-Fixed: 2663555
This commit is contained in:
Pankaj Singh
2020-04-14 13:23:01 +05:30
committed by nshrivas
parent 23671b27af
commit 9dcc7e0e82
11 changed files with 1 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
components/tdls/core/src/wlan_tdls_cmds_process.c
View File

@@ -1529,17 +1529,8 @@ QDF_STATUS tdls_process_del_peer_rsp(struct tdls_del_sta_rsp *rsp)
id = wlan_vdev_get_id(vdev);
if (TDLS_IS_LINK_CONNECTED(curr_peer)) {
soc_obj->tdls_dereg_peer(
soc_obj->tdls_peer_context,
id, &curr_peer->peer_mac);
if (TDLS_IS_LINK_CONNECTED(curr_peer))
tdls_decrement_peer_count(soc_obj);
} else if (TDLS_LINK_CONNECTING ==
curr_peer->link_status) {
soc_obj->tdls_dereg_peer(
soc_obj->tdls_peer_context,
id, &curr_peer->peer_mac);
}
}
tdls_reset_peer(vdev_obj, macaddr);
conn_rec[sta_idx].valid_entry = false;

5
components/tdls/core/src/wlan_tdls_ct.c
View File

@@ -1294,11 +1294,6 @@ void tdls_disable_offchan_and_teardown_links(
*/
tdls_reset_peer(tdls_vdev, curr_peer->peer_mac.bytes);
if (tdls_soc->tdls_dereg_peer)
tdls_soc->tdls_dereg_peer(
tdls_soc->tdls_peer_context,
wlan_vdev_get_id(vdev),
&curr_peer->peer_mac);
tdls_decrement_peer_count(tdls_soc);
tdls_soc->tdls_conn_info[staidx].valid_entry = false;
tdls_soc->tdls_conn_info[staidx].session_id = 255;

5
components/tdls/core/src/wlan_tdls_main.c
View File

@@ -514,11 +514,6 @@ static QDF_STATUS tdls_process_reset_all_peers(struct wlan_objmgr_vdev *vdev)
tdls_reset_peer(tdls_vdev, curr_peer->peer_mac.bytes);
if (tdls_soc->tdls_dereg_peer)
tdls_soc->tdls_dereg_peer(
tdls_soc->tdls_peer_context,
wlan_vdev_get_id(vdev),
&curr_peer->peer_mac);
tdls_decrement_peer_count(tdls_soc);
tdls_soc->tdls_conn_info[staidx].valid_entry = false;
tdls_soc->tdls_conn_info[staidx].session_id = 255;

2
components/tdls/core/src/wlan_tdls_main.h
View File

@@ -172,7 +172,6 @@ struct tdls_set_state_info {
* @tdls_evt_cb_data: tdls event user data
* @tdls_peer_context: userdata for register/deregister TDLS peer
* @tdls_reg_peer: register tdls peer with datapath
* @tdls_dereg_peer: deregister tdls peer from datapath
* @tx_q_ack: queue for tx frames waiting for ack
* @tdls_con_cap: tdls concurrency support
* @tdls_send_mgmt_req: store eWNI_SME_TDLS_SEND_MGMT_REQ value
@@ -215,7 +214,6 @@ struct tdls_soc_priv_obj {
void *tdls_evt_cb_data;
void *tdls_peer_context;
tdls_register_peer_callback tdls_reg_peer;
tdls_deregister_peer_callback tdls_dereg_peer;
tdls_dp_vdev_update_flags_callback tdls_dp_vdev_update;
qdf_list_t tx_q_ack;
enum tdls_conc_cap tdls_con_cap;