Sfoglia il codice sorgente

qcacld-3.0: Converge on struct tdls_del_sta_req

During TDLS componentization the legacy typedef tSirTdlsDelStaReq was
replicated, creating struct tdls_del_sta_req. Unfortunately this left
the driver with two different data structures which serve the same
purpose. Not only is this pointless, but due to the way in which these
structures are used there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
exclusively use the TDLS component struct.

Note that this struct must be promoted to be a public struct since it
is now accessed from outside the component.

Change-Id: I054ee24e07062a60c4e00b935cd1bc5b4a9aef95
CRs-Fixed: 2400769
Jeff Johnson 6 anni fa
parent
commit
9b98a0deb4

+ 0 - 19
tdls/core/src/wlan_tdls_cmds_process.h

@@ -29,25 +29,6 @@
 	((TDLS_SETUP_REQUEST <= action) && \
 	(TDLS_SETUP_CONFIRM >= action))
 
-/**
- * struct tdls_del_sta_req - TDLS Request struct TDLS module --> PE
- *                           same as sSirTdlsDelStaReq
- * @message_type: message type eWNI_SME_TDLS_DEL_STA_REQ
- * @length: message length
- * @session_id: session id
- * @transaction_id: transaction id for cmd
- * @bssid: bssid
- * @peermac: MAC address of the TDLS peer
- */
-struct tdls_del_sta_req {
-	uint16_t message_type;
-	uint16_t length;
-	uint8_t session_id;
-	uint16_t transaction_id;
-	struct qdf_mac_addr bssid;
-	struct qdf_mac_addr peermac;
-};
-
 /**
  * tdls_process_add_peer() - add TDLS peer
  * @req: TDLS add peer request

+ 18 - 0
tdls/dispatcher/inc/wlan_tdls_public_structs.h

@@ -1288,4 +1288,22 @@ struct tdls_add_sta_req {
 	uint8_t max_sp;
 };
 
+/**
+ * struct tdls_del_sta_req - TDLS Request struct TDLS module --> PE
+ * @message_type: message type eWNI_SME_TDLS_DEL_STA_REQ
+ * @length: message length
+ * @session_id: session id
+ * @transaction_id: transaction id for cmd
+ * @bssid: bssid
+ * @peermac: MAC address of the TDLS peer
+ */
+struct tdls_del_sta_req {
+	uint16_t message_type;
+	uint16_t length;
+	uint8_t session_id;
+	uint16_t transaction_id;
+	struct qdf_mac_addr bssid;
+	struct qdf_mac_addr peermac;
+};
+
 #endif